Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode

From: Sakari Ailus <sakari.ailus@iki.fi>
To: Shravan.Chippa@microchip.com
Cc: paul.j.murphy@intel.com, daniele.alessandrelli@intel.com,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, Conor.Dooley@microchip.com,
	Prakash.Battu@microchip.com
Subject: Re: [PATCH v4] media: i2c: imx334: support lower bandwidth mode
Date: Sun, 2 Oct 2022 15:00:12 +0300	[thread overview]
Message-ID: <Yzl9TCGtR/ddHNOG@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <PH0PR11MB56110214AA9709893DD5100281589@PH0PR11MB5611.namprd11.prod.outlook.com>

On Sun, Oct 02, 2022 at 04:42:06AM +0000, Shravan.Chippa@microchip.com wrote:
> > > > > > +830,13 @@ static int imx334_set_pad_format(struct v4l2_subdev
> > > > > > *sd,
> > > > > >
> > > > > >       mutex_lock(&imx334->mutex);
> > > > > >
> > > > > > -     mode = &supported_mode;
> > > > > > +     imx334->cur_code = imx334_get_format_code(imx334, fmt);
> > > > >
> > > > > This should be done only for the active format.
> > > > Are you expecting  if condition to check the current bus code with
> > > set_pad_fromat bus code?
> > >
> > > Only assign the cur_code field when setting the active format.
> > I have taken reference from imx219 driver cur_code will update if the requested
> > format bus code maches with available bus_codes list if not mached with
> > available bus_codes it will use defaults one only.
> > am I missing any thing here ?
> 
> R u expecting to change the current bus code when get the V4L2_SUBDEV_FORMAT_ACTIVE requested?
> I will try to modify in the next revision this case.

Yes, please.

-- 
Sakari Ailus