* [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
@ 2021-07-06 8:23 Emily Deng
2021-07-06 13:51 ` Chen, Guchun
0 siblings, 1 reply; 8+ messages in thread
From: Emily Deng @ 2021-07-06 8:23 UTC (permalink / raw)
To: amd-gfx; +Cc: Emily Deng
The irq number should be decided by num_crtc, and the num_crtc could change
by parameter.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 33324427b555..7e0d8c092c7e 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
{
- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
}
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-06 8:23 [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc Emily Deng
@ 2021-07-06 13:51 ` Chen, Guchun
2021-07-06 14:14 ` Deng, Emily
0 siblings, 1 reply; 8+ messages in thread
From: Chen, Guchun @ 2021-07-06 13:51 UTC (permalink / raw)
To: Deng, Emily, amd-gfx; +Cc: Deng, Emily
[Public]
A spelling typo in subject.
s/ctrc/crtc
Regards,
Guchun
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Emily Deng
Sent: Tuesday, July 6, 2021 4:23 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deng, Emily <Emily.Deng@amd.com>
Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
The irq number should be decided by num_crtc, and the num_crtc could change by parameter.
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 33324427b555..7e0d8c092c7e 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev) {
- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs; }
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cguchun.chen%40amd.com%7Ca4ebf76a046d421cf07c08d94057515e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637611566042100458%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=kh2vwkTyod4ajvt03GB6%2F%2B4FYc%2BwZLCC%2FusgWuijPCU%3D&reserved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-06 13:51 ` Chen, Guchun
@ 2021-07-06 14:14 ` Deng, Emily
0 siblings, 0 replies; 8+ messages in thread
From: Deng, Emily @ 2021-07-06 14:14 UTC (permalink / raw)
To: Chen, Guchun, amd-gfx
Thanks, corrected.
Best wishes
Emily Deng
>-----Original Message-----
>From: Chen, Guchun <Guchun.Chen@amd.com>
>Sent: Tuesday, July 6, 2021 9:52 PM
>To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily <Emily.Deng@amd.com>
>Subject: RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
>
>[Public]
>
>A spelling typo in subject.
>
>s/ctrc/crtc
>
>Regards,
>Guchun
>
>-----Original Message-----
>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Emily
>Deng
>Sent: Tuesday, July 6, 2021 4:23 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily <Emily.Deng@amd.com>
>Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
>
>The irq number should be decided by num_crtc, and the num_crtc could change
>by parameter.
>
>Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>index 33324427b555..7e0d8c092c7e 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
>dce_virtual_crtc_irq_funcs = {
>
> static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev) {
>- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
>+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
> adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs; }
>
>--
>2.25.1
>
>_______________________________________________
>amd-gfx mailing list
>amd-gfx@lists.freedesktop.org
>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.fre
>edesktop.org%2Fmailman%2Flistinfo%2Famd-
>gfx&data=04%7C01%7Cguchun.chen%40amd.com%7Ca4ebf76a046d421cf
>07c08d94057515e%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C6
>37611566042100458%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
>AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=k
>h2vwkTyod4ajvt03GB6%2F%2B4FYc%2BwZLCC%2FusgWuijPCU%3D&reser
>ved=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-02 9:02 ` Das, Nirmoy
@ 2021-07-06 8:24 ` Deng, Emily
0 siblings, 0 replies; 8+ messages in thread
From: Deng, Emily @ 2021-07-06 8:24 UTC (permalink / raw)
To: Das, Nirmoy, amd-gfx; +Cc: Zhao, Victor
[AMD Official Use Only]
Hi Nirmoy,
Thanks, already send out another patch with updating the commit.
Best wishes
Emily Deng
>-----Original Message-----
>From: Das, Nirmoy <Nirmoy.Das@amd.com>
>Sent: Friday, July 2, 2021 5:03 PM
>To: Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org
>Cc: Zhao, Victor <Victor.Zhao@amd.com>
>Subject: Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
>
>Please describe bit more with a commit message.
>
>On 7/1/2021 6:37 AM, Emily Deng wrote:
>> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>> Signed-off-by: Victor <Victor.Zhao@amd.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> index 33324427b555..7e0d8c092c7e 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>> @@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
>dce_virtual_crtc_irq_funcs = {
>>
>> static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
>> {
>> - adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
>> + adev->crtc_irq.num_types = adev->mode_info.num_crtc;
>> adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
>> }
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-01 4:37 Emily Deng
2021-07-01 9:18 ` Deng, Emily
@ 2021-07-02 9:02 ` Das, Nirmoy
2021-07-06 8:24 ` Deng, Emily
1 sibling, 1 reply; 8+ messages in thread
From: Das, Nirmoy @ 2021-07-02 9:02 UTC (permalink / raw)
To: Emily Deng, amd-gfx; +Cc: Victor
Please describe bit more with a commit message.
On 7/1/2021 6:37 AM, Emily Deng wrote:
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> Signed-off-by: Victor <Victor.Zhao@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> index 33324427b555..7e0d8c092c7e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> +++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> @@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
>
> static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
> {
> - adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
> + adev->crtc_irq.num_types = adev->mode_info.num_crtc;
> adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-01 9:18 ` Deng, Emily
@ 2021-07-01 15:57 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2021-07-01 15:57 UTC (permalink / raw)
To: Deng, Emily; +Cc: amd-gfx
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
On Thu, Jul 1, 2021 at 5:18 AM Deng, Emily <Emily.Deng@amd.com> wrote:
>
> [AMD Official Use Only]
>
> Ping......
>
> >-----Original Message-----
> >From: Emily Deng <Emily.Deng@amd.com>
> >Sent: Thursday, July 1, 2021 12:38 PM
> >To: amd-gfx@lists.freedesktop.org
> >Cc: Deng, Emily <Emily.Deng@amd.com>; Zhao, Victor <Victor.Zhao@amd.com>
> >Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
> >
> >Signed-off-by: Emily Deng <Emily.Deng@amd.com>
> >Signed-off-by: Victor <Victor.Zhao@amd.com>
> >---
> > drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >index 33324427b555..7e0d8c092c7e 100644
> >--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
> >@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
> >dce_virtual_crtc_irq_funcs = {
> >
> > static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev) {
> >- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
> >+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
> > adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs; }
> >
> >--
> >2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
2021-07-01 4:37 Emily Deng
@ 2021-07-01 9:18 ` Deng, Emily
2021-07-01 15:57 ` Alex Deucher
2021-07-02 9:02 ` Das, Nirmoy
1 sibling, 1 reply; 8+ messages in thread
From: Deng, Emily @ 2021-07-01 9:18 UTC (permalink / raw)
To: Deng, Emily, amd-gfx
[AMD Official Use Only]
Ping......
>-----Original Message-----
>From: Emily Deng <Emily.Deng@amd.com>
>Sent: Thursday, July 1, 2021 12:38 PM
>To: amd-gfx@lists.freedesktop.org
>Cc: Deng, Emily <Emily.Deng@amd.com>; Zhao, Victor <Victor.Zhao@amd.com>
>Subject: [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
>
>Signed-off-by: Emily Deng <Emily.Deng@amd.com>
>Signed-off-by: Victor <Victor.Zhao@amd.com>
>---
> drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>index 33324427b555..7e0d8c092c7e 100644
>--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
>@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs
>dce_virtual_crtc_irq_funcs = {
>
> static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev) {
>- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
>+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
> adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs; }
>
>--
>2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc
@ 2021-07-01 4:37 Emily Deng
2021-07-01 9:18 ` Deng, Emily
2021-07-02 9:02 ` Das, Nirmoy
0 siblings, 2 replies; 8+ messages in thread
From: Emily Deng @ 2021-07-01 4:37 UTC (permalink / raw)
To: amd-gfx; +Cc: Emily Deng, Victor
Signed-off-by: Emily Deng <Emily.Deng@amd.com>
Signed-off-by: Victor <Victor.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 33324427b555..7e0d8c092c7e 100644
--- a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
+++ b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
@@ -766,7 +766,7 @@ static const struct amdgpu_irq_src_funcs dce_virtual_crtc_irq_funcs = {
static void dce_virtual_set_irq_funcs(struct amdgpu_device *adev)
{
- adev->crtc_irq.num_types = AMDGPU_CRTC_IRQ_VBLANK6 + 1;
+ adev->crtc_irq.num_types = adev->mode_info.num_crtc;
adev->crtc_irq.funcs = &dce_virtual_crtc_irq_funcs;
}
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-06 14:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-06 8:23 [PATCH] drm/amdgpu: Correct the irq numbers for virtual ctrc Emily Deng
2021-07-06 13:51 ` Chen, Guchun
2021-07-06 14:14 ` Deng, Emily
-- strict thread matches above, loose matches on Subject: below --
2021-07-01 4:37 Emily Deng
2021-07-01 9:18 ` Deng, Emily
2021-07-01 15:57 ` Alex Deucher
2021-07-02 9:02 ` Das, Nirmoy
2021-07-06 8:24 ` Deng, Emily
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.