From: Parav Pandit <parav@nvidia.com> To: "Zhu, Lingshan" <lingshan.zhu@intel.com>, "jasowang@redhat.com" <jasowang@redhat.com>, "mst@redhat.com" <mst@redhat.com> Cc: "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "xieyongji@bytedance.com" <xieyongji@bytedance.com>, "gautam.dawar@amd.com" <gautam.dawar@amd.com> Subject: RE: [PATCH V4 3/6] vDPA: allow userspace to query features of a vDPA device Date: Sun, 24 Jul 2022 15:21:32 +0000 [thread overview] Message-ID: <PH0PR12MB5481D9BBC9C249840E4CDF7EDC929@PH0PR12MB5481.namprd12.prod.outlook.com> (raw) In-Reply-To: <6dc2229c-f2f3-017f-16fa-4611e53c774e@intel.com> > From: Zhu, Lingshan <lingshan.zhu@intel.com> > Sent: Saturday, July 23, 2022 7:24 AM > > > On 7/22/2022 9:12 PM, Parav Pandit wrote: > >> From: Zhu Lingshan <lingshan.zhu@intel.com> > >> Sent: Friday, July 22, 2022 7:53 AM > >> > >> This commit adds a new vDPA netlink attribution > >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query > features > >> of vDPA devices through this new attr. > >> > >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > >> --- > >> drivers/vdpa/vdpa.c | 13 +++++++++---- > >> include/uapi/linux/vdpa.h | 1 + > >> 2 files changed, 10 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index > >> ebf2f363fbe7..9b0e39b2f022 100644 > >> --- a/drivers/vdpa/vdpa.c > >> +++ b/drivers/vdpa/vdpa.c > >> @@ -815,7 +815,7 @@ static int vdpa_dev_net_mq_config_fill(struct > >> vdpa_device *vdev, static int vdpa_dev_net_config_fill(struct > >> vdpa_device *vdev, struct sk_buff *msg) { > >> struct virtio_net_config config = {}; > >> - u64 features; > >> + u64 features_device, features_driver; > >> u16 val_u16; > >> > >> vdpa_get_config_unlocked(vdev, 0, &config, sizeof(config)); @@ - > >> 832,12 +832,17 @@ static int vdpa_dev_net_config_fill(struct > >> vdpa_device *vdev, struct sk_buff *ms > >> if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MTU, val_u16)) > >> return -EMSGSIZE; > >> > >> - features = vdev->config->get_driver_features(vdev); > >> - if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features, > >> + features_driver = vdev->config->get_driver_features(vdev); > >> + if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features_driver, > >> + VDPA_ATTR_PAD)) > >> + return -EMSGSIZE; > >> + > >> + features_device = vdev->config->get_device_features(vdev); > >> + if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, > >> +features_device, > >> VDPA_ATTR_PAD)) > >> return -EMSGSIZE; > >> > >> - return vdpa_dev_net_mq_config_fill(vdev, msg, features, &config); > >> + return vdpa_dev_net_mq_config_fill(vdev, msg, features_driver, > >> +&config); > >> } > >> > >> static int > >> diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h > >> index > >> 25c55cab3d7c..39f1c3d7c112 100644 > >> --- a/include/uapi/linux/vdpa.h > >> +++ b/include/uapi/linux/vdpa.h > >> @@ -47,6 +47,7 @@ enum vdpa_attr { > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, /* u64 */ > >> VDPA_ATTR_DEV_MGMTDEV_MAX_VQS, /* u32 */ > >> VDPA_ATTR_DEV_SUPPORTED_FEATURES, /* u64 */ > >> + VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, /* u64 */ > >> > > I have answered in previous emails. > > I disagree with the change. > > Please reuse VDPA_ATTR_DEV_SUPPORTED_FEATURES. > I believe we have already discussed this before in the V3 thread. > I have told you that reusing this attr will lead to a new race condition. > Returning attribute cannot lead to any race condition. > Pleas refer to the previous thread, and you did not answer my questions in > that thread. > > Thanks, > Zhu Lingshan > > > > MST, > > I nack this patch. > > As mentioned in the previous versions, also it is missing the example > output in the commit log. > > Please include example output. > > > >> VDPA_ATTR_DEV_QUEUE_INDEX, /* u32 */ > >> VDPA_ATTR_DEV_VENDOR_ATTR_NAME, /* string */ > >> -- > >> 2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit via Virtualization <virtualization@lists.linux-foundation.org> To: "Zhu, Lingshan" <lingshan.zhu@intel.com>, "jasowang@redhat.com" <jasowang@redhat.com>, "mst@redhat.com" <mst@redhat.com> Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "xieyongji@bytedance.com" <xieyongji@bytedance.com>, "gautam.dawar@amd.com" <gautam.dawar@amd.com>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org> Subject: RE: [PATCH V4 3/6] vDPA: allow userspace to query features of a vDPA device Date: Sun, 24 Jul 2022 15:21:32 +0000 [thread overview] Message-ID: <PH0PR12MB5481D9BBC9C249840E4CDF7EDC929@PH0PR12MB5481.namprd12.prod.outlook.com> (raw) In-Reply-To: <6dc2229c-f2f3-017f-16fa-4611e53c774e@intel.com> > From: Zhu, Lingshan <lingshan.zhu@intel.com> > Sent: Saturday, July 23, 2022 7:24 AM > > > On 7/22/2022 9:12 PM, Parav Pandit wrote: > >> From: Zhu Lingshan <lingshan.zhu@intel.com> > >> Sent: Friday, July 22, 2022 7:53 AM > >> > >> This commit adds a new vDPA netlink attribution > >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES. Userspace can query > features > >> of vDPA devices through this new attr. > >> > >> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com> > >> --- > >> drivers/vdpa/vdpa.c | 13 +++++++++---- > >> include/uapi/linux/vdpa.h | 1 + > >> 2 files changed, 10 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c index > >> ebf2f363fbe7..9b0e39b2f022 100644 > >> --- a/drivers/vdpa/vdpa.c > >> +++ b/drivers/vdpa/vdpa.c > >> @@ -815,7 +815,7 @@ static int vdpa_dev_net_mq_config_fill(struct > >> vdpa_device *vdev, static int vdpa_dev_net_config_fill(struct > >> vdpa_device *vdev, struct sk_buff *msg) { > >> struct virtio_net_config config = {}; > >> - u64 features; > >> + u64 features_device, features_driver; > >> u16 val_u16; > >> > >> vdpa_get_config_unlocked(vdev, 0, &config, sizeof(config)); @@ - > >> 832,12 +832,17 @@ static int vdpa_dev_net_config_fill(struct > >> vdpa_device *vdev, struct sk_buff *ms > >> if (nla_put_u16(msg, VDPA_ATTR_DEV_NET_CFG_MTU, val_u16)) > >> return -EMSGSIZE; > >> > >> - features = vdev->config->get_driver_features(vdev); > >> - if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features, > >> + features_driver = vdev->config->get_driver_features(vdev); > >> + if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, features_driver, > >> + VDPA_ATTR_PAD)) > >> + return -EMSGSIZE; > >> + > >> + features_device = vdev->config->get_device_features(vdev); > >> + if (nla_put_u64_64bit(msg, > >> VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, > >> +features_device, > >> VDPA_ATTR_PAD)) > >> return -EMSGSIZE; > >> > >> - return vdpa_dev_net_mq_config_fill(vdev, msg, features, &config); > >> + return vdpa_dev_net_mq_config_fill(vdev, msg, features_driver, > >> +&config); > >> } > >> > >> static int > >> diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h > >> index > >> 25c55cab3d7c..39f1c3d7c112 100644 > >> --- a/include/uapi/linux/vdpa.h > >> +++ b/include/uapi/linux/vdpa.h > >> @@ -47,6 +47,7 @@ enum vdpa_attr { > >> VDPA_ATTR_DEV_NEGOTIATED_FEATURES, /* u64 */ > >> VDPA_ATTR_DEV_MGMTDEV_MAX_VQS, /* u32 */ > >> VDPA_ATTR_DEV_SUPPORTED_FEATURES, /* u64 */ > >> + VDPA_ATTR_VDPA_DEV_SUPPORTED_FEATURES, /* u64 */ > >> > > I have answered in previous emails. > > I disagree with the change. > > Please reuse VDPA_ATTR_DEV_SUPPORTED_FEATURES. > I believe we have already discussed this before in the V3 thread. > I have told you that reusing this attr will lead to a new race condition. > Returning attribute cannot lead to any race condition. > Pleas refer to the previous thread, and you did not answer my questions in > that thread. > > Thanks, > Zhu Lingshan > > > > MST, > > I nack this patch. > > As mentioned in the previous versions, also it is missing the example > output in the commit log. > > Please include example output. > > > >> VDPA_ATTR_DEV_QUEUE_INDEX, /* u32 */ > >> VDPA_ATTR_DEV_VENDOR_ATTR_NAME, /* string */ > >> -- > >> 2.31.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-07-24 15:21 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-22 11:53 [PATCH V4 0/6] ifcvf/vDPA: support query device config space through netlink Zhu Lingshan 2022-07-22 11:53 ` [PATCH V4 1/6] vDPA/ifcvf: get_config_size should return a value no greater than dev implementation Zhu Lingshan 2022-07-22 11:53 ` [PATCH V4 2/6] vDPA/ifcvf: support userspace to query features and MQ of a management device Zhu Lingshan 2022-07-22 11:53 ` [PATCH V4 3/6] vDPA: allow userspace to query features of a vDPA device Zhu Lingshan 2022-07-22 13:12 ` Parav Pandit 2022-07-22 13:12 ` Parav Pandit via Virtualization 2022-07-23 11:23 ` Zhu, Lingshan 2022-07-24 15:21 ` Parav Pandit [this message] 2022-07-24 15:21 ` Parav Pandit via Virtualization 2022-07-26 11:02 ` Zhu, Lingshan 2022-07-26 11:06 ` Parav Pandit 2022-07-26 11:06 ` Parav Pandit via Virtualization 2022-07-26 11:15 ` Zhu Lingshan 2022-07-27 6:02 ` Zhu, Lingshan 2022-08-09 19:27 ` Parav Pandit 2022-08-09 19:27 ` Parav Pandit via Virtualization 2022-08-09 19:24 ` Michael S. Tsirkin 2022-08-09 19:24 ` Michael S. Tsirkin 2022-08-09 19:28 ` Parav Pandit 2022-08-09 19:28 ` Parav Pandit via Virtualization 2022-08-10 2:51 ` Zhu, Lingshan 2022-07-22 11:53 ` [PATCH V4 4/6] vDPA: !FEATURES_OK should not block querying device config space Zhu Lingshan 2022-07-22 11:53 ` [PATCH V4 5/6] vDPA: answer num of queue pairs = 1 to userspace when VIRTIO_NET_F_MQ == 0 Zhu Lingshan 2022-07-22 13:14 ` Parav Pandit 2022-07-22 13:14 ` Parav Pandit via Virtualization 2022-07-23 11:24 ` Zhu, Lingshan 2022-08-09 19:36 ` Michael S. Tsirkin 2022-08-09 19:36 ` Michael S. Tsirkin 2022-08-09 19:48 ` Parav Pandit via Virtualization 2022-08-09 19:48 ` Parav Pandit 2022-08-10 0:54 ` Si-Wei Liu 2022-08-10 0:54 ` Si-Wei Liu 2022-08-10 1:09 ` Jason Wang 2022-08-10 1:09 ` Jason Wang 2022-08-11 0:58 ` Si-Wei Liu 2022-08-11 0:58 ` Si-Wei Liu 2022-08-10 2:40 ` Zhu, Lingshan 2022-07-22 11:53 ` [PATCH V4 6/6] vDPA: fix 'cast to restricted le16' warnings in vdpa.c Zhu Lingshan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=PH0PR12MB5481D9BBC9C249840E4CDF7EDC929@PH0PR12MB5481.namprd12.prod.outlook.com \ --to=parav@nvidia.com \ --cc=gautam.dawar@amd.com \ --cc=jasowang@redhat.com \ --cc=lingshan.zhu@intel.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ --cc=xieyongji@bytedance.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.