From: Parav Pandit <parav@nvidia.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: [virtio-dev] RE: [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number
Date: Mon, 27 Mar 2023 13:41:33 +0000 [thread overview]
Message-ID: <PH0PR12MB5481E49E7F5C8E4634EB2D00DC8B9@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <sfu7ficnxkfnjrpbl4mnc3lwanrcocxxnoegk7smwy5a4g3jtf@hgh3e3ex4hxv>
Hi Stefano,
> From: Stefano Garzarella <sgarzare@redhat.com>
> Sent: Monday, March 27, 2023 6:04 AM
> Maybe we can also remove `index` from the last sentence in this section.
> I mean something like this:
>
> --- a/transport-mmio.tex
> +++ b/transport-mmio.tex
> @@ -113,8 +113,8 @@ \subsection{MMIO Device Register
> Layout}\label{sec:Virtio Transport Options / Vi
> following operations on \field{QueueSizeMax},
> \field{QueueSize}, \field{QueueReady},
> \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow},
> \field{QueueDriverHigh},
> - \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> apply to. The index
> - number of the first queue is zero (0x0).
> + \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> apply to.
> + The number of the first queue is zero (0x0).
> }
> \hline
> \mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{%
>
> Thanks,
> Stefano
>
With Michael suggestion, the first patch describes the vq number range.
I think we can drop this duplicate text from here all together.
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Parav Pandit <parav@nvidia.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"virtio-comment@lists.oasis-open.org"
<virtio-comment@lists.oasis-open.org>,
Shahaf Shuler <shahafs@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: RE: [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number
Date: Mon, 27 Mar 2023 13:41:33 +0000 [thread overview]
Message-ID: <PH0PR12MB5481E49E7F5C8E4634EB2D00DC8B9@PH0PR12MB5481.namprd12.prod.outlook.com> (raw)
In-Reply-To: <sfu7ficnxkfnjrpbl4mnc3lwanrcocxxnoegk7smwy5a4g3jtf@hgh3e3ex4hxv>
Hi Stefano,
> From: Stefano Garzarella <sgarzare@redhat.com>
> Sent: Monday, March 27, 2023 6:04 AM
> Maybe we can also remove `index` from the last sentence in this section.
> I mean something like this:
>
> --- a/transport-mmio.tex
> +++ b/transport-mmio.tex
> @@ -113,8 +113,8 @@ \subsection{MMIO Device Register
> Layout}\label{sec:Virtio Transport Options / Vi
> following operations on \field{QueueSizeMax},
> \field{QueueSize}, \field{QueueReady},
> \field{QueueDescLow}, \field{QueueDescHigh}, \field{QueueDriverlLow},
> \field{QueueDriverHigh},
> - \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> apply to. The index
> - number of the first queue is zero (0x0).
> + \field{QueueDeviceLow}, \field{QueueDeviceHigh} and \field{QueueReset}
> apply to.
> + The number of the first queue is zero (0x0).
> }
> \hline
> \mmioreg{QueueSizeMax}{Maximum virtual queue size}{0x034}{R}{%
>
> Thanks,
> Stefano
>
With Michael suggestion, the first patch describes the vq number range.
I think we can drop this duplicate text from here all together.
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
next prev parent reply other threads:[~2023-03-27 13:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 1:04 [virtio-dev] [PATCH v6 0/8] Rename queue index to queue number Parav Pandit
2023-03-24 1:04 ` [virtio-comment] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 1/8] content: Add vq number text Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 2/8] transport-pci: Refer to the vq by its number Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
2023-03-24 1:04 ` [virtio-dev] [PATCH v6 3/8] transport-mmio: Rename QueueNum register Parav Pandit
2023-03-24 1:04 ` [virtio-comment] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 4/8] transport-mmio: Refer to the vq by its number Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
2023-03-27 10:03 ` [virtio-dev] Re: [virtio-comment] " Stefano Garzarella
2023-03-27 10:03 ` Stefano Garzarella
2023-03-27 13:41 ` Parav Pandit [this message]
2023-03-27 13:41 ` Parav Pandit
2023-03-27 13:58 ` [virtio-dev] " Stefano Garzarella
2023-03-27 13:58 ` Stefano Garzarella
2023-03-27 14:14 ` [virtio-dev] " Parav Pandit
2023-03-27 14:14 ` Parav Pandit
2023-03-24 1:04 ` [virtio-dev] [PATCH v6 5/8] transport-ccw: Rename queue depth/size to other transports Parav Pandit
2023-03-24 1:04 ` [virtio-comment] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 6/8] transport-ccw: Refer to the vq by its number Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 7/8] virtio-net: Avoid duplicate receive queue example Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
2023-03-24 1:04 ` [virtio-comment] [PATCH v6 8/8] virtio-net: Describe RSS using rss rq id Parav Pandit
2023-03-24 1:04 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB5481E49E7F5C8E4634EB2D00DC8B9@PH0PR12MB5481.namprd12.prod.outlook.com \
--to=parav@nvidia.com \
--cc=cohuck@redhat.com \
--cc=jiri@nvidia.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=sgarzare@redhat.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.