[PATCH] PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

[PATCH] PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

[Samuel Holland]

The cpumask that is passed to this function ultimately comes from
irq_data_get_effective_affinity_mask(), which was recently changed to
return a const cpumask pointer. The first level of functions handling
the affinity mask were updated, but not this helper function.

Fixes: 4d0b8298818b ("genirq: Return a const cpumask from irq_data_get_affinity_mask")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
---

 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index aebada45569b..e7c6f6629e7c 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -1635,7 +1635,7 @@ static u32 hv_compose_msi_req_v1(
  * Create MSI w/ dummy vCPU set targeting just one vCPU, overwritten
  * by subsequent retarget in hv_irq_unmask().
  */
-static int hv_compose_msi_req_get_cpu(struct cpumask *affinity)
+static int hv_compose_msi_req_get_cpu(const struct cpumask *affinity)
 {
 	return cpumask_first_and(affinity, cpu_online_mask);
 }
-- 
2.35.1

RE: [PATCH] PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

[Michael Kelley (LINUX)]

From: Samuel Holland <samuel@sholland.org> Sent: Thursday, July 7, 2022 5:50 PM
> 
> The cpumask that is passed to this function ultimately comes from
> irq_data_get_effective_affinity_mask(), which was recently changed to
> return a const cpumask pointer. The first level of functions handling
> the affinity mask were updated, but not this helper function.
> 
> Fixes: 4d0b8298818b ("genirq: Return a const cpumask from irq_data_get_affinity_mask")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> 
>  drivers/pci/controller/pci-hyperv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index aebada45569b..e7c6f6629e7c 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -1635,7 +1635,7 @@ static u32 hv_compose_msi_req_v1(
>   * Create MSI w/ dummy vCPU set targeting just one vCPU, overwritten
>   * by subsequent retarget in hv_irq_unmask().
>   */
> -static int hv_compose_msi_req_get_cpu(struct cpumask *affinity)
> +static int hv_compose_msi_req_get_cpu(const struct cpumask *affinity)
>  {
>  	return cpumask_first_and(affinity, cpu_online_mask);
>  }
> --
> 2.35.1

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

[irqchip: irq/irqchip-next] PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

[irqchip-bot for Samuel Holland]

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID:     9167fd5d5549bcea6d4735a270908da2a3475f3a
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/9167fd5d5549bcea6d4735a270908da2a3475f3a
Author:        Samuel Holland <samuel@sholland.org>
AuthorDate:    Thu, 07 Jul 2022 19:49:31 -05:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Fri, 08 Jul 2022 08:44:15 +01:00

PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

The cpumask that is passed to this function ultimately comes from
irq_data_get_effective_affinity_mask(), which was recently changed to
return a const cpumask pointer. The first level of functions handling
the affinity mask were updated, but not this helper function.

Fixes: 4d0b8298818b ("genirq: Return a const cpumask from irq_data_get_affinity_mask")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220708004931.1672-1-samuel@sholland.org
---
 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index aebada4..e7c6f66 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -1635,7 +1635,7 @@ static u32 hv_compose_msi_req_v1(
  * Create MSI w/ dummy vCPU set targeting just one vCPU, overwritten
  * by subsequent retarget in hv_irq_unmask().
  */
-static int hv_compose_msi_req_get_cpu(struct cpumask *affinity)
+static int hv_compose_msi_req_get_cpu(const struct cpumask *affinity)
 {
 	return cpumask_first_and(affinity, cpu_online_mask);
 }

Re: [PATCH] PCI: hv: Take a const cpumask in hv_compose_msi_req_get_cpu()

[Wei Liu]

On Fri, Jul 08, 2022 at 04:27:00AM +0000, Michael Kelley (LINUX) wrote:
> From: Samuel Holland <samuel@sholland.org> Sent: Thursday, July 7, 2022 5:50 PM
> > 
> > The cpumask that is passed to this function ultimately comes from
> > irq_data_get_effective_affinity_mask(), which was recently changed to
> > return a const cpumask pointer. The first level of functions handling
> > the affinity mask were updated, but not this helper function.
> > 
> > Fixes: 4d0b8298818b ("genirq: Return a const cpumask from irq_data_get_affinity_mask")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > 
> >  drivers/pci/controller/pci-hyperv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index aebada45569b..e7c6f6629e7c 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -1635,7 +1635,7 @@ static u32 hv_compose_msi_req_v1(
> >   * Create MSI w/ dummy vCPU set targeting just one vCPU, overwritten
> >   * by subsequent retarget in hv_irq_unmask().
> >   */
> > -static int hv_compose_msi_req_get_cpu(struct cpumask *affinity)
> > +static int hv_compose_msi_req_get_cpu(const struct cpumask *affinity)
> >  {
> >  	return cpumask_first_and(affinity, cpu_online_mask);
> >  }
> > --
> > 2.35.1
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Applied to hyperv-next. Thanks.