All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/i40e: fix PCTYPE configuration for X722
@ 2022-11-03 16:57 Mingjin Ye
  2022-11-09  1:35 ` Chen, LingliX
  0 siblings, 1 reply; 3+ messages in thread
From: Mingjin Ye @ 2022-11-03 16:57 UTC (permalink / raw)
  To: dev
  Cc: stable, yidingx.zhou, Mingjin Ye, Yuying Zhang, Beilei Xing,
	Alvin Zhang, Qi Zhang

To make X722's PCTYPE is compatible with X710, the PCTYPE in the
FD programming descriptor is translated into different types by using
GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP'
and 'MULTICAST_IPV4_UDP' are only supported for X722, so that
the corresponding registers can not be configured after translation.

This patch removes the transition before the FD filter is programmed.

Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
Cc: stable@dpdk.org

Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
 drivers/net/i40e/i40e_hash.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
index a1ff85fceb..0c84818977 100644
--- a/drivers/net/i40e/i40e_hash.c
+++ b/drivers/net/i40e/i40e_hash.c
@@ -659,10 +659,6 @@ i40e_hash_config_pctype_symmetric(struct i40e_hw *hw,
 	struct i40e_pf *pf = &((struct i40e_adapter *)hw->back)->pf;
 	uint32_t reg;
 
-	/* For X722, get translated pctype in fd pctype register */
-	if (hw->mac.type == I40E_MAC_X722)
-		pctype = i40e_read_rx_ctl(hw, I40E_GLQF_FD_PCTYPES(pctype));
-
 	reg = i40e_read_rx_ctl(hw, I40E_GLQF_HSYM(pctype));
 	if (symmetric) {
 		if (reg & I40E_GLQF_HSYM_SYMH_ENA_MASK)
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* RE: [PATCH] net/i40e: fix PCTYPE configuration for X722
  2022-11-03 16:57 [PATCH] net/i40e: fix PCTYPE configuration for X722 Mingjin Ye
@ 2022-11-09  1:35 ` Chen, LingliX
  2022-11-09  2:28   ` Zhang, Qi Z
  0 siblings, 1 reply; 3+ messages in thread
From: Chen, LingliX @ 2022-11-09  1:35 UTC (permalink / raw)
  To: dev
  Cc: stable, Zhou, YidingX, Ye, MingjinX, Zhang, Yuying, Xing, Beilei,
	Alvin Zhang, Zhang, Qi Z


> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Friday, November 4, 2022 12:57 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Alvin Zhang <alvinx.zhang@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722
> 
> To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD
> programming descriptor is translated into different types by using
> GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP'
> and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the
> corresponding registers can not be configured after translation.
> 
> This patch removes the transition before the FD filter is programmed.
> 
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---

Tested-by: Lingli Chen <linglix.chen@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread
* RE: [PATCH] net/i40e: fix PCTYPE configuration for X722
  2022-11-09  1:35 ` Chen, LingliX
@ 2022-11-09  2:28   ` Zhang, Qi Z
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2022-11-09  2:28 UTC (permalink / raw)
  To: Chen, LingliX, dev
  Cc: stable, Zhou, YidingX, Ye, MingjinX, Zhang, Yuying, Xing, Beilei,
	Alvin Zhang



> -----Original Message-----
> From: Chen, LingliX <linglix.chen@intel.com>
> Sent: Wednesday, November 9, 2022 9:36 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>; Xing,
> Beilei <beilei.xing@intel.com>; Alvin Zhang <alvinx.zhang@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>
> Subject: RE: [PATCH] net/i40e: fix PCTYPE configuration for X722
> 
> 
> > -----Original Message-----
> > From: Mingjin Ye <mingjinx.ye@intel.com>
> > Sent: Friday, November 4, 2022 12:57 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>; Ye,
> > MingjinX <mingjinx.ye@intel.com>; Zhang, Yuying
> > <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Alvin
> > Zhang <alvinx.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Subject: [PATCH] net/i40e: fix PCTYPE configuration for X722
> >
> > To make X722's PCTYPE is compatible with X710, the PCTYPE in the FD
> > programming descriptor is translated into different types by using
> > GLQF_FD_PCTYPE table. But the types of 'UNICAST_IPV4_UDP'
> > and 'MULTICAST_IPV4_UDP' are only supported for X722, so that the
> > corresponding registers can not be configured after translation.
> >
> > This patch removes the transition before the FD filter is programmed.
> >
> > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> > ---
> 
> Tested-by: Lingli Chen <linglix.chen@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-09  2:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 16:57 [PATCH] net/i40e: fix PCTYPE configuration for X722 Mingjin Ye
2022-11-09  1:35 ` Chen, LingliX
2022-11-09  2:28   ` Zhang, Qi Z

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.