* [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
@ 2022-07-22 14:17 ` Venkata Prasad Potturu
0 siblings, 0 replies; 8+ messages in thread
From: Venkata Prasad Potturu @ 2022-07-22 14:17 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: vsujithkumar.reddy, Vijendar.Mukunda, Basavaraj.Hiregoudar,
Sunil-kumar.Dommati, ssabakar, Venkata Prasad Potturu,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Ajit Kumar Pandey,
V sujith kumar Reddy, open list
Update dai_id macros to make code generic for all platforms.
Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
---
sound/soc/amd/acp/amd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
index 148a9ab6206d..ff2fb476fa6c 100644
--- a/sound/soc/amd/acp/amd.h
+++ b/sound/soc/amd/acp/amd.h
@@ -21,9 +21,9 @@
#define ACP3X_DEV 3
#define ACP6X_DEV 6
-#define I2S_SP_INSTANCE 0x00
-#define I2S_BT_INSTANCE 0x01
-#define DMIC_INSTANCE 0x02
+#define DMIC_INSTANCE 0x00
+#define I2S_SP_INSTANCE 0x01
+#define I2S_BT_INSTANCE 0x02
#define I2S_HS_INSTANCE 0x03
#define MEM_WINDOW_START 0x4080000
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
@ 2022-07-22 14:17 ` Venkata Prasad Potturu
0 siblings, 0 replies; 8+ messages in thread
From: Venkata Prasad Potturu @ 2022-07-22 14:17 UTC (permalink / raw)
To: broonie, alsa-devel
Cc: Sunil-kumar.Dommati, ssabakar, Ajit Kumar Pandey,
Venkata Prasad Potturu, open list, Basavaraj.Hiregoudar,
Takashi Iwai, Liam Girdwood, Vijendar.Mukunda,
V sujith kumar Reddy
Update dai_id macros to make code generic for all platforms.
Signed-off-by: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>
---
sound/soc/amd/acp/amd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
index 148a9ab6206d..ff2fb476fa6c 100644
--- a/sound/soc/amd/acp/amd.h
+++ b/sound/soc/amd/acp/amd.h
@@ -21,9 +21,9 @@
#define ACP3X_DEV 3
#define ACP6X_DEV 6
-#define I2S_SP_INSTANCE 0x00
-#define I2S_BT_INSTANCE 0x01
-#define DMIC_INSTANCE 0x02
+#define DMIC_INSTANCE 0x00
+#define I2S_SP_INSTANCE 0x01
+#define I2S_BT_INSTANCE 0x02
#define I2S_HS_INSTANCE 0x03
#define MEM_WINDOW_START 0x4080000
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
2022-07-22 14:17 ` Venkata Prasad Potturu
@ 2022-07-22 14:52 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2022-07-22 14:52 UTC (permalink / raw)
To: Venkata Prasad Potturu
Cc: alsa-devel, vsujithkumar.reddy, Vijendar.Mukunda,
Basavaraj.Hiregoudar, Sunil-kumar.Dommati, ssabakar,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Ajit Kumar Pandey,
open list
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote:
> Update dai_id macros to make code generic for all platforms.
> -#define I2S_SP_INSTANCE 0x00
> -#define I2S_BT_INSTANCE 0x01
> -#define DMIC_INSTANCE 0x02
> +#define DMIC_INSTANCE 0x00
> +#define I2S_SP_INSTANCE 0x01
> +#define I2S_BT_INSTANCE 0x02
This looks like it's just an indentation/formatting change which isn't
what the changelog said?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
@ 2022-07-22 14:52 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2022-07-22 14:52 UTC (permalink / raw)
To: Venkata Prasad Potturu
Cc: alsa-devel, Sunil-kumar.Dommati, ssabakar, Ajit Kumar Pandey,
open list, Basavaraj.Hiregoudar, Takashi Iwai, Liam Girdwood,
Vijendar.Mukunda, vsujithkumar.reddy
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote:
> Update dai_id macros to make code generic for all platforms.
> -#define I2S_SP_INSTANCE 0x00
> -#define I2S_BT_INSTANCE 0x01
> -#define DMIC_INSTANCE 0x02
> +#define DMIC_INSTANCE 0x00
> +#define I2S_SP_INSTANCE 0x01
> +#define I2S_BT_INSTANCE 0x02
This looks like it's just an indentation/formatting change which isn't
what the changelog said?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
2022-07-22 14:52 ` Mark Brown
(?)
@ 2022-07-25 10:27 ` Prasad, Prasad
2022-07-25 12:02 ` Mark Brown
-1 siblings, 1 reply; 8+ messages in thread
From: Prasad, Prasad @ 2022-07-25 10:27 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Dommati, Sunil-kumar, Ajit Kumar Pandey, open list,
Hiregoudar, Basavaraj, Takashi Iwai, Liam Girdwood, Saba Kareem,
Syed, Mukunda, Vijendar, Reddy, V sujith kumar
[AMD Official Use Only - General]
On 7/22/2022 8:22 PM, Mark Brown wrote:
Thanks for your time.
On Fri, Jul 22, 2022 at 07:47:03PM +0530, Venkata Prasad Potturu wrote:
Update dai_id macros to make code generic for all platforms.
-#define I2S_SP_INSTANCE 0x00
-#define I2S_BT_INSTANCE 0x01
-#define DMIC_INSTANCE 0x02
+#define DMIC_INSTANCE 0x00
+#define I2S_SP_INSTANCE 0x01
+#define I2S_BT_INSTANCE 0x02
This looks like it's just an indentation/formatting change which isn't
what the changelog said?
We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
I2S_HS_INSTANCE is already 0x03.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
2022-07-25 10:27 ` Prasad, Prasad
@ 2022-07-25 12:02 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2022-07-25 12:02 UTC (permalink / raw)
To: Prasad, Prasad
Cc: alsa-devel, Reddy, V sujith kumar, Mukunda, Vijendar, Hiregoudar,
Basavaraj, Dommati, Sunil-kumar, Saba Kareem, Syed,
Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Ajit Kumar Pandey,
open list
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:
> This looks like it's just an indentation/formatting change which isn't
>
> what the changelog said?
> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
>
> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
> I2S_HS_INSTANCE is already 0x03.
Please write a better changelog which makes this clear.
Please fix your e-mail client to clearly distinguish between quoted and
non-quoted text, it's very hard to find your new text in your mail.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
@ 2022-07-25 12:02 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2022-07-25 12:02 UTC (permalink / raw)
To: Prasad, Prasad
Cc: alsa-devel, Dommati, Sunil-kumar, Ajit Kumar Pandey, open list,
Hiregoudar, Basavaraj, Takashi Iwai, Liam Girdwood, Saba Kareem,
Syed, Mukunda, Vijendar, Reddy, V sujith kumar
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:
> This looks like it's just an indentation/formatting change which isn't
>
> what the changelog said?
> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
>
> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
> I2S_HS_INSTANCE is already 0x03.
Please write a better changelog which makes this clear.
Please fix your e-mail client to clearly distinguish between quoted and
non-quoted text, it's very hard to find your new text in your mail.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic
2022-07-25 12:02 ` Mark Brown
(?)
@ 2022-07-29 10:43 ` Venkata Prasad Potturu
-1 siblings, 0 replies; 8+ messages in thread
From: Venkata Prasad Potturu @ 2022-07-29 10:43 UTC (permalink / raw)
To: Mark Brown
Cc: alsa-devel, Dommati, Sunil-kumar, open list, Hiregoudar,
Basavaraj, Takashi Iwai, Liam Girdwood, Saba Kareem, Syed,
Mukunda, Vijendar, Reddy, V sujith kumar
On 7/25/22 17:32, Mark Brown wrote:
Thanks for your time.
> On Mon, Jul 25, 2022 at 10:27:19AM +0000, Prasad, Prasad wrote:
>
>> This looks like it's just an indentation/formatting change which isn't
>>
>> what the changelog said?
>> We are changing dai_id macro numbers, as renoir platform has 2 I2S instances and Rembrandt platform has 3 I2S instances.
>>
>> To make I2S instances as order, change DMIC_INSTANCE to 0x00, I2S_SP_INSTANCE to 0x01 and I2S_BT_INSTANCE to 0x02.
>> I2S_HS_INSTANCE is already 0x03.
> Please write a better changelog which makes this clear.
Okay, we will change accordingly.
>
> Please fix your e-mail client to clearly distinguish between quoted and
> non-quoted text, it's very hard to find your new text in your mail.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-29 10:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-22 14:17 [PATCH] ASoC: amd: acp: Modify dai_id macros to be more generic Venkata Prasad Potturu
2022-07-22 14:17 ` Venkata Prasad Potturu
2022-07-22 14:52 ` Mark Brown
2022-07-22 14:52 ` Mark Brown
2022-07-25 10:27 ` Prasad, Prasad
2022-07-25 12:02 ` Mark Brown
2022-07-25 12:02 ` Mark Brown
2022-07-29 10:43 ` Venkata Prasad Potturu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.