* [PATCH v4] riscv: don't allow write but not read page mapping request in mmap
@ 2022-06-24 10:14 ` Celeste Liu
0 siblings, 0 replies; 2+ messages in thread
From: Celeste Liu @ 2022-06-24 10:14 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou, Guo Ren, Atish Patra,
Jisheng Zhang, linux-riscv
Cc: Celeste Liu, Xiongchuan Tan, Wang Ruikang, Ruizhe Pan,
linux-kernel, Yash Shah
When Xiongchuan Tan tries to run oe of libaio's tests[1], it encounters
a strange behavior: for the same PROT_WRITE only mapping, there was a
discrepancy in whether it could be read before and after writing
(readable before writing, unreadable after writing).
After some investigation, I found that mmap allows write only mapping,
an undefined behavior, on RISC-V.
As mentioned in Table 4.5 in RISC-V spec Volume 2 Section 4.3 version
"20211203 Privileged Architecture v1.12, Ratified"[2], the PTE permission
bit combination of "write+!read" is "Reserved for future use.". Hence,
don't allow such mapping request in mmap call.
In the current code[3], write+exec only is marked as invalid,
but write only is not marked as invalid.
This patch refines that judgment.
[1]: https://pagure.io/libaio/blob/1b18bfafc6a2f7b9fa2c6be77a95afed8b7be448/f/harness/cases/5.t
[2]: https://github.com/riscv/riscv-isa-manual/releases/download/Priv-v1.12/riscv-privileged-20211203.pdf
[3]: commit e0d17c842c0f ("RISC-V: Don't allow write+exec only page mapping request in mmap")
Reported-by: Xiongchuan Tan <xc-tan@outlook.com>
Co-developed-by: Wang Ruikang <dramforever@live.com>
Signed-off-by: Wang Ruikang <dramforever@live.com>
Co-developed-by: Ruizhe Pan <c141028@gmail.com>
Signed-off-by: Ruizhe Pan <c141028@gmail.com>
Signed-off-by: Celeste Liu <coelacanthus@outlook.com>
Reviewed-by: Guo Ren <guoren@kernel.org>
Cc: linux-riscv@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Guo Ren <guoren@kernel.org>
Cc: Yash Shah <yash.shah@sifive.com>
---
v2: This version adds a link to the referenced spec, and reference of the
previous related modification.
v3: fix DCO signoff name and add comment for reason
v4: fix typo in changelog and comment
arch/riscv/kernel/sys_riscv.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index 9c0194f176fc..f29456cfe68a 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -18,9 +18,14 @@ static long riscv_sys_mmap(unsigned long addr, unsigned long len,
if (unlikely(offset & (~PAGE_MASK >> page_shift_offset)))
return -EINVAL;
- if ((prot & PROT_WRITE) && (prot & PROT_EXEC))
- if (unlikely(!(prot & PROT_READ)))
- return -EINVAL;
+ /*
+ * As mentioned in Table 4.5 in RISC-V spec (20211203) Volume 2
+ * Section 4.3 the PTE permission bit combination of "write+!read"
+ * is "Reserved for future use.". Hence, don't allow such mapping
+ * request in mmap call.
+ */
+ if (unlikely((prot & PROT_WRITE) && !(prot & PROT_READ)))
+ return -EINVAL;
return ksys_mmap_pgoff(addr, len, prot, flags, fd,
offset >> (PAGE_SHIFT - page_shift_offset));
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v4] riscv: don't allow write but not read page mapping request in mmap
@ 2022-06-24 10:14 ` Celeste Liu
0 siblings, 0 replies; 2+ messages in thread
From: Celeste Liu @ 2022-06-24 10:14 UTC (permalink / raw)
To: Palmer Dabbelt, Paul Walmsley, Albert Ou, Guo Ren, Atish Patra,
Jisheng Zhang, linux-riscv
Cc: Celeste Liu, Xiongchuan Tan, Wang Ruikang, Ruizhe Pan,
linux-kernel, Yash Shah
When Xiongchuan Tan tries to run oe of libaio's tests[1], it encounters
a strange behavior: for the same PROT_WRITE only mapping, there was a
discrepancy in whether it could be read before and after writing
(readable before writing, unreadable after writing).
After some investigation, I found that mmap allows write only mapping,
an undefined behavior, on RISC-V.
As mentioned in Table 4.5 in RISC-V spec Volume 2 Section 4.3 version
"20211203 Privileged Architecture v1.12, Ratified"[2], the PTE permission
bit combination of "write+!read" is "Reserved for future use.". Hence,
don't allow such mapping request in mmap call.
In the current code[3], write+exec only is marked as invalid,
but write only is not marked as invalid.
This patch refines that judgment.
[1]: https://pagure.io/libaio/blob/1b18bfafc6a2f7b9fa2c6be77a95afed8b7be448/f/harness/cases/5.t
[2]: https://github.com/riscv/riscv-isa-manual/releases/download/Priv-v1.12/riscv-privileged-20211203.pdf
[3]: commit e0d17c842c0f ("RISC-V: Don't allow write+exec only page mapping request in mmap")
Reported-by: Xiongchuan Tan <xc-tan@outlook.com>
Co-developed-by: Wang Ruikang <dramforever@live.com>
Signed-off-by: Wang Ruikang <dramforever@live.com>
Co-developed-by: Ruizhe Pan <c141028@gmail.com>
Signed-off-by: Ruizhe Pan <c141028@gmail.com>
Signed-off-by: Celeste Liu <coelacanthus@outlook.com>
Reviewed-by: Guo Ren <guoren@kernel.org>
Cc: linux-riscv@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: Guo Ren <guoren@kernel.org>
Cc: Yash Shah <yash.shah@sifive.com>
---
v2: This version adds a link to the referenced spec, and reference of the
previous related modification.
v3: fix DCO signoff name and add comment for reason
v4: fix typo in changelog and comment
arch/riscv/kernel/sys_riscv.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
index 9c0194f176fc..f29456cfe68a 100644
--- a/arch/riscv/kernel/sys_riscv.c
+++ b/arch/riscv/kernel/sys_riscv.c
@@ -18,9 +18,14 @@ static long riscv_sys_mmap(unsigned long addr, unsigned long len,
if (unlikely(offset & (~PAGE_MASK >> page_shift_offset)))
return -EINVAL;
- if ((prot & PROT_WRITE) && (prot & PROT_EXEC))
- if (unlikely(!(prot & PROT_READ)))
- return -EINVAL;
+ /*
+ * As mentioned in Table 4.5 in RISC-V spec (20211203) Volume 2
+ * Section 4.3 the PTE permission bit combination of "write+!read"
+ * is "Reserved for future use.". Hence, don't allow such mapping
+ * request in mmap call.
+ */
+ if (unlikely((prot & PROT_WRITE) && !(prot & PROT_READ)))
+ return -EINVAL;
return ksys_mmap_pgoff(addr, len, prot, flags, fd,
offset >> (PAGE_SHIFT - page_shift_offset));
--
2.36.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-24 10:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 10:14 [PATCH v4] riscv: don't allow write but not read page mapping request in mmap Celeste Liu
2022-06-24 10:14 ` Celeste Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.