* [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS
@ 2003-10-10 5:58 Noah J. Misch
2003-10-10 16:03 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Noah J. Misch @ 2003-10-10 5:58 UTC (permalink / raw)
To: acme; +Cc: linux-kernel, linux-net, torvalds
Hello Arnaldo,
This is a trivial patch against ipx_proc.c that allows it to compile with
CONFIG_PROC_FS unset. The patch simply makes ipx_proc.c include init.h
unconditionally, which ensures that __init and __exit are always defined.
This patch depends upon the patch "Make linux/init.h include linux/compiler.h",
which I have CC-ed to all recipients of this patch. Should Linus decline that
patch, I can make the trivial changes necessary to make this patch work on its
own, if you wish.
Thanks,
Noah
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1342 -> 1.1343
# net/ipx/ipx_proc.c 1.9 -> 1.10
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/10 noah@caltech.edu 1.1343
# This file needs the __init macro in all cases, so include init.h
# regardless of CONFIG_PROC_FS. This fixes a compilation error in
# the absence of CONFIG_PROC_FS.
# --------------------------------------------
#
diff -Nru a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
--- a/net/ipx/ipx_proc.c Fri Oct 10 01:05:06 2003
+++ b/net/ipx/ipx_proc.c Fri Oct 10 01:05:06 2003
@@ -5,8 +5,8 @@
*/
#include <linux/config.h>
-#ifdef CONFIG_PROC_FS
#include <linux/init.h>
+#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
#include <linux/spinlock.h>
#include <linux/seq_file.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS
2003-10-10 5:58 [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS Noah J. Misch
@ 2003-10-10 16:03 ` Arnaldo Carvalho de Melo
2003-10-11 19:14 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2003-10-10 16:03 UTC (permalink / raw)
To: Noah J. Misch; +Cc: David S. Miller, linux-kernel, linux-net
Em Thu, Oct 09, 2003 at 10:58:57PM -0700, Noah J. Misch escreveu:
> Hello Arnaldo,
>
> This is a trivial patch against ipx_proc.c that allows it to compile with
> CONFIG_PROC_FS unset. The patch simply makes ipx_proc.c include init.h
> unconditionally, which ensures that __init and __exit are always defined.
>
> This patch depends upon the patch "Make linux/init.h include linux/compiler.h",
> which I have CC-ed to all recipients of this patch. Should Linus decline that
> patch, I can make the trivial changes necessary to make this patch work on its
> own, if you wish.
>
> Thanks,
> Noah
I don't have any problem with this patch, Dave, could you please apply it?
- Arnaldo
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1342 -> 1.1343
# net/ipx/ipx_proc.c 1.9 -> 1.10
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/10 noah@caltech.edu 1.1343
# This file needs the __init macro in all cases, so include init.h
# regardless of CONFIG_PROC_FS. This fixes a compilation error in
# the absence of CONFIG_PROC_FS.
# --------------------------------------------
#
diff -Nru a/net/ipx/ipx_proc.c b/net/ipx/ipx_proc.c
--- a/net/ipx/ipx_proc.c Fri Oct 10 01:05:06 2003
+++ b/net/ipx/ipx_proc.c Fri Oct 10 01:05:06 2003
@@ -5,8 +5,8 @@
*/
#include <linux/config.h>
-#ifdef CONFIG_PROC_FS
#include <linux/init.h>
+#ifdef CONFIG_PROC_FS
#include <linux/proc_fs.h>
#include <linux/spinlock.h>
#include <linux/seq_file.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS
2003-10-10 16:03 ` Arnaldo Carvalho de Melo
@ 2003-10-11 19:14 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2003-10-11 19:14 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: noah, linux-kernel, linux-net
On Fri, 10 Oct 2003 13:03:09 -0300
Arnaldo Carvalho de Melo <acme@conectiva.com.br> wrote:
> I don't have any problem with this patch, Dave, could you please apply it?
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-11 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-10 5:58 [PATCH] Make net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS Noah J. Misch
2003-10-10 16:03 ` Arnaldo Carvalho de Melo
2003-10-11 19:14 ` David S. Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.