All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Make linux/init.h include linux/compiler.h
@ 2003-10-10  5:57 Noah J. Misch
  0 siblings, 0 replies; only message in thread
From: Noah J. Misch @ 2003-10-10  5:57 UTC (permalink / raw)
  To: torvalds, linux-kernel; +Cc: acme, linux-net

Greetings Linus,

Since __exit and __exit_call from init.h use __attribute_used__ from compiler.h
and are two of the most common macros for which files include init.h, init.h
should include compiler.h.

I think this patch would be appropriate anyway, but note the patch "Make
net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS", which I have CC-ed to all
recipients of this message, and that depends upon this patch.  Without this
patch, ipx_proc.c would need to include both init.h and compiler.h, the latter
for no other reason than to support init.h.  I don't think that's good.

Thanks,
Noah

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1341  -> 1.1342
#	include/linux/init.h	1.27    -> 1.28
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/10	noah@caltech.edu	1.1342
# Make linux/init.h include linux/compiler.h.  The __exit and __exit_call
# macros, among others, need the __attribute_used__ macro defined there.
# --------------------------------------------
#
diff -Nru a/include/linux/init.h b/include/linux/init.h
--- a/include/linux/init.h	Fri Oct 10 00:58:50 2003
+++ b/include/linux/init.h	Fri Oct 10 00:58:50 2003
@@ -2,6 +2,7 @@
 #define _LINUX_INIT_H

 #include <linux/config.h>
+#include <linux/compiler.h>

 /* These macros are used to mark some functions or
  * initialized data (doesn't apply to uninitialized data)


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-10-10  5:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-10  5:57 [PATCH] Make linux/init.h include linux/compiler.h Noah J. Misch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.