* [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h
@ 2011-07-21 14:24 Shawn Guo
2011-07-27 2:09 ` Shawn Guo
2011-07-30 21:54 ` Uwe Kleine-König
0 siblings, 2 replies; 4+ messages in thread
From: Shawn Guo @ 2011-07-21 14:24 UTC (permalink / raw)
To: linux-arm-kernel
As cpu_is_mx stuff is being used in the driver, header mach/hardware.h
should be explicitly included.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
The missing of the header is causing today's linux-next build error
as bleow.
CC drivers/usb/host/ehci-hcd.o
In file included from linux-next/drivers/usb/host/ehci-hcd.c:1190:0:
linux-next/drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx35'
linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx25'
linux-next/drivers/usb/host/ehci-mxc.c:185:2: error: implicit declaration of function 'cpu_is_mx51'
drivers/usb/host/ehci-mxc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
index 0c058be..555a73c 100644
--- a/drivers/usb/host/ehci-mxc.c
+++ b/drivers/usb/host/ehci-mxc.c
@@ -24,6 +24,7 @@
#include <linux/usb/ulpi.h>
#include <linux/slab.h>
+#include <mach/hardware.h>
#include <mach/mxc_ehci.h>
#include <asm/mach-types.h>
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h
2011-07-21 14:24 [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h Shawn Guo
@ 2011-07-27 2:09 ` Shawn Guo
2011-07-27 20:42 ` Alan Stern
2011-07-30 21:54 ` Uwe Kleine-König
1 sibling, 1 reply; 4+ messages in thread
From: Shawn Guo @ 2011-07-27 2:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alan,
Linus tree is currently failing on i.mx build because of this.
Regards,
Shawn
On Thu, Jul 21, 2011 at 10:24:10PM +0800, Shawn Guo wrote:
> As cpu_is_mx stuff is being used in the driver, header mach/hardware.h
> should be explicitly included.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> The missing of the header is causing today's linux-next build error
> as bleow.
>
> CC drivers/usb/host/ehci-hcd.o
> In file included from linux-next/drivers/usb/host/ehci-hcd.c:1190:0:
> linux-next/drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
> linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx35'
> linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx25'
> linux-next/drivers/usb/host/ehci-mxc.c:185:2: error: implicit declaration of function 'cpu_is_mx51'
>
> drivers/usb/host/ehci-mxc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> index 0c058be..555a73c 100644
> --- a/drivers/usb/host/ehci-mxc.c
> +++ b/drivers/usb/host/ehci-mxc.c
> @@ -24,6 +24,7 @@
> #include <linux/usb/ulpi.h>
> #include <linux/slab.h>
>
> +#include <mach/hardware.h>
> #include <mach/mxc_ehci.h>
>
> #include <asm/mach-types.h>
> --
> 1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h
2011-07-27 2:09 ` Shawn Guo
@ 2011-07-27 20:42 ` Alan Stern
0 siblings, 0 replies; 4+ messages in thread
From: Alan Stern @ 2011-07-27 20:42 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 27 Jul 2011, Shawn Guo wrote:
> Hi Alan,
>
> Linus tree is currently failing on i.mx build because of this.
Greg KH is the USB maintainer. He's on vacation right now, but he'll
merge your patch when he has a chance.
Alan Stern
> Regards,
> Shawn
>
> On Thu, Jul 21, 2011 at 10:24:10PM +0800, Shawn Guo wrote:
> > As cpu_is_mx stuff is being used in the driver, header mach/hardware.h
> > should be explicitly included.
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > ---
> > The missing of the header is causing today's linux-next build error
> > as bleow.
> >
> > CC drivers/usb/host/ehci-hcd.o
> > In file included from linux-next/drivers/usb/host/ehci-hcd.c:1190:0:
> > linux-next/drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
> > linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx35'
> > linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx25'
> > linux-next/drivers/usb/host/ehci-mxc.c:185:2: error: implicit declaration of function 'cpu_is_mx51'
> >
> > drivers/usb/host/ehci-mxc.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c
> > index 0c058be..555a73c 100644
> > --- a/drivers/usb/host/ehci-mxc.c
> > +++ b/drivers/usb/host/ehci-mxc.c
> > @@ -24,6 +24,7 @@
> > #include <linux/usb/ulpi.h>
> > #include <linux/slab.h>
> >
> > +#include <mach/hardware.h>
> > #include <mach/mxc_ehci.h>
> >
> > #include <asm/mach-types.h>
> > --
> > 1.7.4.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h
2011-07-21 14:24 [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h Shawn Guo
2011-07-27 2:09 ` Shawn Guo
@ 2011-07-30 21:54 ` Uwe Kleine-König
1 sibling, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2011-07-30 21:54 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jul 21, 2011 at 10:24:10PM +0800, Shawn Guo wrote:
> As cpu_is_mx stuff is being used in the driver, header mach/hardware.h
> should be explicitly included.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> The missing of the header is causing today's linux-next build error
> as bleow.
>
> CC drivers/usb/host/ehci-hcd.o
> In file included from linux-next/drivers/usb/host/ehci-hcd.c:1190:0:
> linux-next/drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
> linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx35'
> linux-next/drivers/usb/host/ehci-mxc.c:175:2: error: implicit declaration of function 'cpu_is_mx25'
> linux-next/drivers/usb/host/ehci-mxc.c:185:2: error: implicit declaration of function 'cpu_is_mx51'
I just hit this problem while build testing some of my patches.
IMHO the build failure can go in the commit log, too.
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-30 21:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-21 14:24 [PATCH] usb/ehci-mxc: add missing inclusion of mach/hardware.h Shawn Guo
2011-07-27 2:09 ` Shawn Guo
2011-07-27 20:42 ` Alan Stern
2011-07-30 21:54 ` Uwe Kleine-König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.