From: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
To: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
Cc: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>,
USB list <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 1/2] USB: Update EHCI-platform driver to devicetree.
Date: Mon, 22 Oct 2012 10:51:19 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1210221046140.1724-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1350771032-11527-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
On Sun, 21 Oct 2012, Tony Prisk wrote:
> +static u64 ehci_dma_mask = DMA_BIT_MASK(32);
...
> + /* Right now device-tree probed devices don't get dma_mask set.
> + * Since shared usb code relies on it, set it here for now.
> + * Once we have dma capability bindings this can go away.
> + */
> + if (!dev->dev.dma_mask)
> + dev->dev.dma_mask = &ehci_dma_mask;
Grant:
I have seen this sort of thing added to many drivers. Why can't this
be centralized in a way that will apply once and for all to all
appropriate DT-based drivers?
Eventually DMA capabilities will be supported properly in DT, right?
Then all these additions made to hundreds(?) of drivers will have to be
removed. Why not start the ball rolling now and prevent things from
getting even worse?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-10-22 14:51 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 22:10 [PATCH v2 0/2] Update ehci-platform driver to support devicetree Tony Prisk
2012-10-20 22:10 ` Tony Prisk
[not found] ` <1350771032-11527-1-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-10-20 22:10 ` [PATCH v2 1/2] USB: Update EHCI-platform driver to devicetree Tony Prisk
2012-10-20 22:10 ` Tony Prisk
[not found] ` <1350771032-11527-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-10-21 2:02 ` Alan Stern
2012-10-21 2:02 ` Alan Stern
2012-10-22 14:51 ` Alan Stern [this message]
2012-10-20 22:10 ` [PATCH v2 2/2] USB: doc: Binding document for ehci-platform driver Tony Prisk
2012-10-20 22:10 ` Tony Prisk
[not found] ` <1350771032-11527-3-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
2012-10-21 17:34 ` Florian Fainelli
2012-10-21 17:34 ` Florian Fainelli
2012-10-22 16:07 ` Stephen Warren
2012-10-22 16:07 ` Stephen Warren
[not found] ` <50856F41.7000205-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-22 17:34 ` Alan Stern
2012-10-22 17:34 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210221324580.1724-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-22 17:48 ` Stephen Warren
2012-10-22 17:48 ` Stephen Warren
[not found] ` <508586ED.1010106-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-22 19:00 ` Alan Stern
2012-10-22 19:00 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210221443580.1724-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-22 22:10 ` Stephen Warren
2012-10-22 22:10 ` Stephen Warren
[not found] ` <5085C470.4040707-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-23 14:10 ` Alan Stern
2012-10-23 14:10 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210231004310.1635-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-23 16:15 ` Stephen Warren
2012-10-23 16:15 ` Stephen Warren
[not found] ` <5086C2B0.6070006-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-23 17:59 ` Alan Stern
2012-10-23 17:59 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210231340340.1635-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-23 18:47 ` Stephen Warren
2012-10-23 18:47 ` Stephen Warren
[not found] ` <5086E62D.8040407-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-23 19:33 ` Alan Stern
2012-10-23 19:33 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210231522230.1635-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-23 20:06 ` Rob Herring
2012-10-23 20:06 ` Rob Herring
[not found] ` <5086F8D6.5050605-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-24 14:57 ` Alan Stern
2012-10-24 14:57 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241013310.1481-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 15:26 ` Sebastian Andrzej Siewior
2012-10-24 15:26 ` Sebastian Andrzej Siewior
[not found] ` <20121024152652.GG4368-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2012-10-24 16:16 ` Stephen Warren
2012-10-24 16:16 ` Stephen Warren
[not found] ` <5088145F.1040504-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 16:36 ` Florian Fainelli
2012-10-24 16:36 ` Florian Fainelli
2012-10-24 16:38 ` Alan Stern
2012-10-24 16:38 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241233040.1282-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 16:44 ` Florian Fainelli
2012-10-24 16:44 ` Florian Fainelli
2012-10-24 18:04 ` Alan Stern
2012-10-24 18:04 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241358090.1282-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 18:18 ` Florian Fainelli
2012-10-24 18:18 ` Florian Fainelli
2012-10-24 16:45 ` Stephen Warren
2012-10-24 16:45 ` Stephen Warren
[not found] ` <50881B19.3080609-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 17:46 ` Alan Stern
2012-10-24 17:46 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241329230.1282-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 18:09 ` Stephen Warren
2012-10-24 18:09 ` Stephen Warren
[not found] ` <50882EED.9020200-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 18:55 ` Mitch Bradley
2012-10-24 18:55 ` Mitch Bradley
[not found] ` <5088399F.2000102-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-10-24 19:30 ` Alan Stern
2012-10-24 19:30 ` Alan Stern
2012-10-25 10:23 ` Sebastian Andrzej Siewior
2012-10-25 10:23 ` Sebastian Andrzej Siewior
[not found] ` <20121025102301.GA3469-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2012-10-25 14:36 ` Alan Stern
2012-10-25 14:36 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210251035270.1278-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-26 8:02 ` Sebastian Andrzej Siewior
2012-10-26 8:02 ` Sebastian Andrzej Siewior
[not found] ` <20121026080254.GD3009-E0PNVn5OA6ohrxcnuTQ+TQ@public.gmane.org>
2012-10-26 14:54 ` Alan Stern
2012-10-26 14:54 ` Alan Stern
2012-10-25 15:53 ` Stephen Warren
2012-10-25 15:53 ` Stephen Warren
2012-10-24 19:41 ` Alan Stern
2012-10-24 19:41 ` Alan Stern
2012-10-24 16:44 ` Alan Stern
2012-10-24 16:44 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241238570.1282-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 16:48 ` Stephen Warren
2012-10-24 16:48 ` Stephen Warren
2012-10-24 17:42 ` Rob Herring
2012-10-24 17:42 ` Rob Herring
[not found] ` <50882882.1090806-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-10-24 17:57 ` Alan Stern
2012-10-24 17:57 ` Alan Stern
2012-10-24 16:28 ` Stephen Warren
2012-10-24 16:28 ` Stephen Warren
[not found] ` <50881727.10601-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-10-24 16:54 ` Alan Stern
2012-10-24 16:54 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.1210241249010.1282-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2012-10-24 17:37 ` Florian Fainelli
2012-10-24 17:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1210221046140.1724-100000@iolanthe.rowland.org \
--to=stern-nwvwt67g6+6dfdvte/nmlpvzexx5g7lz@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org \
--cc=linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.