From: Alan Stern <stern@rowland.harvard.edu>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Prisk <linux@prisktech.co.nz>,
"moderated list:ARM/VT8500 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:USB EHCI DRIVER" <linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: ehci-platform: use helper variables in probe function
Date: Thu, 14 Jul 2016 10:11:29 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1607141008500.32397-100000@netrider.rowland.org> (raw)
In-Reply-To: <1468398548-5050-1-git-send-email-zajec5@gmail.com>
On Wed, 13 Jul 2016, Rafał Miłecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Okay except for...
> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> - "phys", "#phy-cells");
> + priv->num_phys = of_count_phandle_with_args(np, "phys",
> + "#phy-cells");
Please indent continuation lines two tab stops beyond the original
line, to match the style in the rest of the source file.
With that change,
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: stern@rowland.harvard.edu (Alan Stern)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: ehci-platform: use helper variables in probe function
Date: Thu, 14 Jul 2016 10:11:29 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1607141008500.32397-100000@netrider.rowland.org> (raw)
In-Reply-To: <1468398548-5050-1-git-send-email-zajec5@gmail.com>
On Wed, 13 Jul 2016, Rafa? Mi?ecki wrote:
> Probing function was using &dev->dev and dev->dev.of_node over 20 times
> so I believe it made sense to use helper variables for both of them.
> To avoid some uncommon variable name for struct device I first replaced
> existing dev variable with pdev.
>
> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
Okay except for...
> - priv->num_phys = of_count_phandle_with_args(dev->dev.of_node,
> - "phys", "#phy-cells");
> + priv->num_phys = of_count_phandle_with_args(np, "phys",
> + "#phy-cells");
Please indent continuation lines two tab stops beyond the original
line, to match the style in the rest of the source file.
With that change,
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Alan Stern
next prev parent reply other threads:[~2016-07-14 14:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 8:29 [PATCH] usb: ehci-platform: use helper variables in probe function Rafał Miłecki
2016-07-13 8:29 ` Rafał Miłecki
2016-07-14 14:11 ` Alan Stern [this message]
2016-07-14 14:11 ` Alan Stern
2016-07-14 15:22 ` Rafał Miłecki
2016-07-14 15:22 ` Rafał Miłecki
2016-07-15 0:58 ` Alan Stern
2016-07-15 0:58 ` Alan Stern
2016-07-15 5:05 ` [PATCH V2] " Rafał Miłecki
2016-07-15 5:05 ` Rafał Miłecki
2016-08-09 13:59 ` Greg Kroah-Hartman
2016-08-09 13:59 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1607141008500.32397-100000@netrider.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.