All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>, <gregkh@linuxfoundation.org>,
	USB list <linux-usb@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	<linux-pm@vger.kernel.org>
Subject: Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller
Date: Thu, 15 Jun 2017 10:12:15 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1706151008380.1573-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <CAAd53p4-84G=NeJMOGcL_3fd7_s6EC4udLEGTcNNSBF=4FxHyA@mail.gmail.com>

On Thu, 15 Jun 2017, Kai-Heng Feng wrote:

> On Wed, Jun 14, 2017 at 1:28 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > The lspci output [1] shows:
> >
> >   00:12.0 USB controller: Advanced Micro Devices, Inc. [AMD] FCH USB EHCI Controller (rev 39) (prog-if 20 [EHCI])
> >     Capabilities: [c0] Power Management version 2
> >       Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
> >       Status: D3 NoSoftRst- PME-Enable+ DSel=0 DScale=0 PME-
> >       Bridge: PM- B3+
> >
> > The device claims it can assert PME# from D3hot.  If it can't, that
> > sounds like a hardware defect that should be addressed with a quirk.
> > Ideally we would also have a pointer to the AMD hardware erratum.
> 
> Looks like it's pretty similar to "23 USB Wake on Connect/Disconnect
> with Low Speed Devices" in [1].
> It points to a workaround in appendix A2 from [2].
> However it says this bug only effects Low Speed devices, but it
> actually also happens on High Speed devices.
> 
> [1] https://support.amd.com/TechDocs/46837.pdf
> [2] https://support.amd.com/TechDocs/42413.pdf

Those documents refer to a hardware bug with a workaround in the BIOS.  
Have you checked to see if your BIOS is up to date?

Alan Stern

WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	gregkh@linuxfoundation.org, USB list <linux-usb@vger.kernel.org>,
	linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller
Date: Thu, 15 Jun 2017 10:12:15 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.44L0.1706151008380.1573-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <CAAd53p4-84G=NeJMOGcL_3fd7_s6EC4udLEGTcNNSBF=4FxHyA@mail.gmail.com>

On Thu, 15 Jun 2017, Kai-Heng Feng wrote:

> On Wed, Jun 14, 2017 at 1:28 AM, Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > The lspci output [1] shows:
> >
> >   00:12.0 USB controller: Advanced Micro Devices, Inc. [AMD] FCH USB EHCI Controller (rev 39) (prog-if 20 [EHCI])
> >     Capabilities: [c0] Power Management version 2
> >       Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
> >       Status: D3 NoSoftRst- PME-Enable+ DSel=0 DScale=0 PME-
> >       Bridge: PM- B3+
> >
> > The device claims it can assert PME# from D3hot.  If it can't, that
> > sounds like a hardware defect that should be addressed with a quirk.
> > Ideally we would also have a pointer to the AMD hardware erratum.
> 
> Looks like it's pretty similar to "23 USB Wake on Connect/Disconnect
> with Low Speed Devices" in [1].
> It points to a workaround in appendix A2 from [2].
> However it says this bug only effects Low Speed devices, but it
> actually also happens on High Speed devices.
> 
> [1] https://support.amd.com/TechDocs/46837.pdf
> [2] https://support.amd.com/TechDocs/42413.pdf

Those documents refer to a hardware bug with a workaround in the BIOS.  
Have you checked to see if your BIOS is up to date?

Alan Stern

  reply	other threads:[~2017-06-15 14:12 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09  7:22 [PATCH] usb: host: ehci: workaround PME bug on AMD EHCI controller Kai-Heng Feng
2017-06-09 14:43 ` Alan Stern
2017-06-12  7:04   ` Kai-Heng Feng
2017-06-12 10:12     ` Kai-Heng Feng
2017-06-12 14:18       ` Alan Stern
2017-06-13  4:21         ` Kai-Heng Feng
2017-06-13 17:28           ` Bjorn Helgaas
2017-06-14 18:55             ` Alan Stern
2017-06-14 18:55               ` Alan Stern
2017-06-14 18:55               ` Alan Stern
2017-06-15  7:02               ` Kai-Heng Feng
2017-06-15  7:02                 ` Kai-Heng Feng
2017-06-15 13:23                 ` Bjorn Helgaas
2017-06-15  6:57             ` Kai-Heng Feng
2017-06-15 14:12               ` Alan Stern [this message]
2017-06-15 14:12                 ` Alan Stern
2017-06-16  3:07                 ` Kai-Heng Feng
2017-06-16  3:07                   ` Kai-Heng Feng
2017-06-16 16:18                   ` Kai-Heng Feng
2017-06-16 17:30                     ` Alan Stern
2017-06-16 17:30                       ` Alan Stern
2017-06-19  3:30                       ` Kai-Heng Feng
2017-06-19  3:30                         ` Kai-Heng Feng
2017-06-19 17:45                         ` Bjorn Helgaas
2017-06-19 18:32                           ` Alan Stern
2017-06-19 18:32                             ` Alan Stern
2017-06-19 18:32                             ` Alan Stern
2017-06-19 22:00                             ` Rafael J. Wysocki
2017-06-20  2:36                             ` Kai-Heng Feng
2017-06-23  0:48                             ` [PATCH] PCI / PM: Avoid using device_may_wakeup() for runtime PM Rafael J. Wysocki
2017-06-23 12:58                               ` [PATCH v2] " Rafael J. Wysocki
2017-06-29 22:37                                 ` Rafael J. Wysocki
2017-06-30  8:44                                   ` Mika Westerberg
2017-06-30  8:44                                     ` Mika Westerberg
2017-06-30 16:16                                 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44L0.1706151008380.1573-100000@iolanthe.rowland.org \
    --to=stern@rowland.harvard.edu \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=helgaas@kernel.org \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.