* [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()
@ 2017-11-03 11:23 Roger Quadros
2017-11-03 17:47 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2017-11-03 11:23 UTC (permalink / raw)
To: balbi, stern; +Cc: linux-usb, linux-kernel, Roger Quadros
There will never be a case when gadget.speed isn't already
USB_SPEED_FULL if connection is not USB-3 and gadget.speed
is not USB_SPEED_HIGH or USB_SPEED_LOW.
Remove the unnecessary code.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/gadget/udc/dummy_hcd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
index c42ca8e..41cefc5 100644
--- a/drivers/usb/gadget/udc/dummy_hcd.c
+++ b/drivers/usb/gadget/udc/dummy_hcd.c
@@ -2166,8 +2166,6 @@ static int dummy_hub_control(
USB_PORT_STAT_LOW_SPEED;
break;
default:
- dum_hcd->dum->gadget.speed =
- USB_SPEED_FULL;
break;
}
}
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control()
2017-11-03 11:23 [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control() Roger Quadros
@ 2017-11-03 17:47 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2017-11-03 17:47 UTC (permalink / raw)
To: Roger Quadros; +Cc: balbi, linux-usb, linux-kernel
On Fri, 3 Nov 2017, Roger Quadros wrote:
> There will never be a case when gadget.speed isn't already
> USB_SPEED_FULL if connection is not USB-3 and gadget.speed
> is not USB_SPEED_HIGH or USB_SPEED_LOW.
>
> Remove the unnecessary code.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/usb/gadget/udc/dummy_hcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/dummy_hcd.c
> index c42ca8e..41cefc5 100644
> --- a/drivers/usb/gadget/udc/dummy_hcd.c
> +++ b/drivers/usb/gadget/udc/dummy_hcd.c
> @@ -2166,8 +2166,6 @@ static int dummy_hub_control(
> USB_PORT_STAT_LOW_SPEED;
> break;
> default:
> - dum_hcd->dum->gadget.speed =
> - USB_SPEED_FULL;
> break;
> }
> }
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-03 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 11:23 [PATCH] USB: dummy-hcd: don't set gadget.speed in dummy_hub_control() Roger Quadros
2017-11-03 17:47 ` Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.