* usb: host: ehci: Use dma_pool_zalloc()
@ 2018-02-14 17:55 Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2018-02-14 17:55 UTC (permalink / raw)
To: Souptick Joarder; +Cc: linux-usb
On Wed, 14 Feb 2018, Souptick Joarder wrote:
> Use dma_pool_zalloc() instead of dma_pool_alloc + memset
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
> drivers/usb/host/ehci-mem.c | 3 +--
> drivers/usb/host/ehci-sched.c | 6 ++----
> 2 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
> index 21307d8..4c6c08b 100644
> --- a/drivers/usb/host/ehci-mem.c
> +++ b/drivers/usb/host/ehci-mem.c
> @@ -73,10 +73,9 @@ static struct ehci_qh *ehci_qh_alloc (struct ehci_hcd *ehci, gfp_t flags)
> if (!qh)
> goto done;
> qh->hw = (struct ehci_qh_hw *)
> - dma_pool_alloc(ehci->qh_pool, flags, &dma);
> + dma_pool_zalloc(ehci->qh_pool, flags, &dma);
> if (!qh->hw)
> goto fail;
> - memset(qh->hw, 0, sizeof *qh->hw);
> qh->qh_dma = dma;
> // INIT_LIST_HEAD (&qh->qh_list);
> INIT_LIST_HEAD (&qh->qtd_list);
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index e56db44..28e2a33 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1287,7 +1287,7 @@ static void scan_intr(struct ehci_hcd *ehci)
> } else {
> alloc_itd:
> spin_unlock_irqrestore(&ehci->lock, flags);
> - itd = dma_pool_alloc(ehci->itd_pool, mem_flags,
> + itd = dma_pool_zalloc(ehci->itd_pool, mem_flags,
> &itd_dma);
> spin_lock_irqsave(&ehci->lock, flags);
> if (!itd) {
> @@ -1297,7 +1297,6 @@ static void scan_intr(struct ehci_hcd *ehci)
> }
> }
>
> - memset(itd, 0, sizeof(*itd));
> itd->itd_dma = itd_dma;
> itd->frame = NO_FRAME;
> list_add(&itd->itd_list, &sched->td_list);
> @@ -2081,7 +2080,7 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
> } else {
> alloc_sitd:
> spin_unlock_irqrestore(&ehci->lock, flags);
> - sitd = dma_pool_alloc(ehci->sitd_pool, mem_flags,
> + sitd = dma_pool_zalloc(ehci->sitd_pool, mem_flags,
> &sitd_dma);
> spin_lock_irqsave(&ehci->lock, flags);
> if (!sitd) {
> @@ -2091,7 +2090,6 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
> }
> }
>
> - memset(sitd, 0, sizeof(*sitd));
> sitd->sitd_dma = sitd_dma;
> sitd->frame = NO_FRAME;
> list_add(&sitd->sitd_list, &iso_sched->td_list);
> --
> 1.9.1
>
>
>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
* usb: host: ehci: Use dma_pool_zalloc()
@ 2018-02-14 17:48 Souptick Joarder
0 siblings, 0 replies; 2+ messages in thread
From: Souptick Joarder @ 2018-02-14 17:48 UTC (permalink / raw)
To: stern; +Cc: linux-usb
Use dma_pool_zalloc() instead of dma_pool_alloc + memset
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/usb/host/ehci-mem.c | 3 +--
drivers/usb/host/ehci-sched.c | 6 ++----
2 files changed, 3 insertions(+), 6 deletions(-)
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/usb/host/ehci-mem.c b/drivers/usb/host/ehci-mem.c
index 21307d8..4c6c08b 100644
--- a/drivers/usb/host/ehci-mem.c
+++ b/drivers/usb/host/ehci-mem.c
@@ -73,10 +73,9 @@ static struct ehci_qh *ehci_qh_alloc (struct ehci_hcd *ehci, gfp_t flags)
if (!qh)
goto done;
qh->hw = (struct ehci_qh_hw *)
- dma_pool_alloc(ehci->qh_pool, flags, &dma);
+ dma_pool_zalloc(ehci->qh_pool, flags, &dma);
if (!qh->hw)
goto fail;
- memset(qh->hw, 0, sizeof *qh->hw);
qh->qh_dma = dma;
// INIT_LIST_HEAD (&qh->qh_list);
INIT_LIST_HEAD (&qh->qtd_list);
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index e56db44..28e2a33 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1287,7 +1287,7 @@ static void scan_intr(struct ehci_hcd *ehci)
} else {
alloc_itd:
spin_unlock_irqrestore(&ehci->lock, flags);
- itd = dma_pool_alloc(ehci->itd_pool, mem_flags,
+ itd = dma_pool_zalloc(ehci->itd_pool, mem_flags,
&itd_dma);
spin_lock_irqsave(&ehci->lock, flags);
if (!itd) {
@@ -1297,7 +1297,6 @@ static void scan_intr(struct ehci_hcd *ehci)
}
}
- memset(itd, 0, sizeof(*itd));
itd->itd_dma = itd_dma;
itd->frame = NO_FRAME;
list_add(&itd->itd_list, &sched->td_list);
@@ -2081,7 +2080,7 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
} else {
alloc_sitd:
spin_unlock_irqrestore(&ehci->lock, flags);
- sitd = dma_pool_alloc(ehci->sitd_pool, mem_flags,
+ sitd = dma_pool_zalloc(ehci->sitd_pool, mem_flags,
&sitd_dma);
spin_lock_irqsave(&ehci->lock, flags);
if (!sitd) {
@@ -2091,7 +2090,6 @@ static int itd_submit(struct ehci_hcd *ehci, struct urb *urb,
}
}
- memset(sitd, 0, sizeof(*sitd));
sitd->sitd_dma = sitd_dma;
sitd->frame = NO_FRAME;
list_add(&sitd->sitd_list, &iso_sched->td_list);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-14 17:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 17:55 usb: host: ehci: Use dma_pool_zalloc() Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2018-02-14 17:48 Souptick Joarder
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.