* usb: core: Simplify return value of usb_get_configuration()
@ 2019-01-07 15:10 Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2019-01-07 15:10 UTC (permalink / raw)
To: Suwan Kim; +Cc: gregkh, linux-usb, mathias.nyman
On Mon, 7 Jan 2019, Suwan Kim wrote:
> It is better to initialize the return value "result" to -ENOMEM
> than to 0. And because "result" takes the return value of
> usb_parse_configuration() which returns 0 for success, setting
> "result" to 0 at before and after of the for loop is unnecessary.
>
> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
> ---
> drivers/usb/core/config.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> index 7b5cb28ffb35..4a0945c04b4c 100644
> --- a/drivers/usb/core/config.c
> +++ b/drivers/usb/core/config.c
> @@ -800,13 +800,12 @@ int usb_get_configuration(struct usb_device *dev)
> {
> struct device *ddev = &dev->dev;
> int ncfg = dev->descriptor.bNumConfigurations;
> - int result = 0;
> + int result = -ENOMEM;
> unsigned int cfgno, length;
> unsigned char *bigbuffer;
> struct usb_config_descriptor *desc;
>
> cfgno = 0;
> - result = -ENOMEM;
> if (ncfg > USB_MAXCONFIG) {
> dev_warn(ddev, "too many configurations: %d, "
> "using maximum allowed: %d\n", ncfg, USB_MAXCONFIG);
> @@ -832,7 +831,6 @@ int usb_get_configuration(struct usb_device *dev)
> if (!desc)
> goto err2;
>
> - result = 0;
> for (; cfgno < ncfg; cfgno++) {
> /* We grab just the first descriptor so we know how long
> * the whole configuration is */
> @@ -889,7 +887,6 @@ int usb_get_configuration(struct usb_device *dev)
> goto err;
> }
> }
> - result = 0;
>
> err:
> kfree(desc);
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
* usb: core: Simplify return value of usb_get_configuration()
@ 2019-01-07 14:21 Suwan Kim
0 siblings, 0 replies; 2+ messages in thread
From: Suwan Kim @ 2019-01-07 14:21 UTC (permalink / raw)
To: gregkh, stern; +Cc: linux-usb, mathias.nyman
It is better to initialize the return value "result" to -ENOMEM
than to 0. And because "result" takes the return value of
usb_parse_configuration() which returns 0 for success, setting
"result" to 0 at before and after of the for loop is unnecessary.
Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
---
drivers/usb/core/config.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 7b5cb28ffb35..4a0945c04b4c 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -800,13 +800,12 @@ int usb_get_configuration(struct usb_device *dev)
{
struct device *ddev = &dev->dev;
int ncfg = dev->descriptor.bNumConfigurations;
- int result = 0;
+ int result = -ENOMEM;
unsigned int cfgno, length;
unsigned char *bigbuffer;
struct usb_config_descriptor *desc;
cfgno = 0;
- result = -ENOMEM;
if (ncfg > USB_MAXCONFIG) {
dev_warn(ddev, "too many configurations: %d, "
"using maximum allowed: %d\n", ncfg, USB_MAXCONFIG);
@@ -832,7 +831,6 @@ int usb_get_configuration(struct usb_device *dev)
if (!desc)
goto err2;
- result = 0;
for (; cfgno < ncfg; cfgno++) {
/* We grab just the first descriptor so we know how long
* the whole configuration is */
@@ -889,7 +887,6 @@ int usb_get_configuration(struct usb_device *dev)
goto err;
}
}
- result = 0;
err:
kfree(desc);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-07 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-07 15:10 usb: core: Simplify return value of usb_get_configuration() Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2019-01-07 14:21 Suwan Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.