From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: Kento.A.Kobayashi@sony.com, <gregkh@linuxfoundation.org>,
<usb-storage@lists.one-eyed-alien.net>,
<linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port
Date: Fri, 8 Mar 2019 12:33:14 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1903081231260.1412-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1552063928.29776.2.camel@suse.com>
On Fri, 8 Mar 2019, Oliver Neukum wrote:
> On Fr, 2019-03-08 at 09:13 +0000, Kento.A.Kobayashi@sony.com wrote:
> > The usb_reset_and_verify_device included in usb_reset_device fails
> > with -ENODEV after power off hub port, and the -ENODEV error will
> > be reported to uas_eh_bus_reset_handler and upper layer, so it
> > doesn't need to do rebind if -ENODEV happens.
>
> Hi,
>
> no I am sorry, that is an assumption you just cannot make.
> Anything can trigger a reset. That being SCSI is the common
> case certainly, but not the only case. And in those cases
> we cannot depend on upper layers doing the right thing, if
> we just ignore an error.
>
> NACK
>
> Sorry
> Oliver
Note that the reset routines in usb-storage do not make any exceptions
for -ENODEV.
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: Kento.A.Kobayashi@sony.com, gregkh@linuxfoundation.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: usb: uas: fix usb subsystem hang after power off hub port
Date: Fri, 8 Mar 2019 12:33:14 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1903081231260.1412-100000@iolanthe.rowland.org> (raw)
On Fri, 8 Mar 2019, Oliver Neukum wrote:
> On Fr, 2019-03-08 at 09:13 +0000, Kento.A.Kobayashi@sony.com wrote:
> > The usb_reset_and_verify_device included in usb_reset_device fails
> > with -ENODEV after power off hub port, and the -ENODEV error will
> > be reported to uas_eh_bus_reset_handler and upper layer, so it
> > doesn't need to do rebind if -ENODEV happens.
>
> Hi,
>
> no I am sorry, that is an assumption you just cannot make.
> Anything can trigger a reset. That being SCSI is the common
> case certainly, but not the only case. And in those cases
> we cannot depend on upper layers doing the right thing, if
> we just ignore an error.
>
> NACK
>
> Sorry
> Oliver
Note that the reset routines in usb-storage do not make any exceptions
for -ENODEV.
Alan Stern
WARNING: multiple messages have this Message-ID (diff)
From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: Kento.A.Kobayashi@sony.com, gregkh@linuxfoundation.org,
usb-storage@lists.one-eyed-alien.net,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: uas: fix usb subsystem hang after power off hub port
Date: Fri, 8 Mar 2019 12:33:14 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1903081231260.1412-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1552063928.29776.2.camel@suse.com>
On Fri, 8 Mar 2019, Oliver Neukum wrote:
> On Fr, 2019-03-08 at 09:13 +0000, Kento.A.Kobayashi@sony.com wrote:
> > The usb_reset_and_verify_device included in usb_reset_device fails
> > with -ENODEV after power off hub port, and the -ENODEV error will
> > be reported to uas_eh_bus_reset_handler and upper layer, so it
> > doesn't need to do rebind if -ENODEV happens.
>
> Hi,
>
> no I am sorry, that is an assumption you just cannot make.
> Anything can trigger a reset. That being SCSI is the common
> case certainly, but not the only case. And in those cases
> we cannot depend on upper layers doing the right thing, if
> we just ignore an error.
>
> NACK
>
> Sorry
> Oliver
Note that the reset routines in usb-storage do not make any exceptions
for -ENODEV.
Alan Stern
next prev parent reply other threads:[~2019-03-08 17:33 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-08 9:13 [PATCH] usb: uas: fix usb subsystem hang after power off hub port Kento.A.Kobayashi
2019-03-08 9:13 ` Kento.A.Kobayashi
2019-03-08 9:13 ` Kento.A.Kobayashi
2019-03-08 16:52 ` [PATCH] " Oliver Neukum
2019-03-08 16:52 ` Oliver Neukum
2019-03-08 17:33 ` Alan Stern [this message]
2019-03-08 17:33 ` [PATCH] " Alan Stern
2019-03-08 17:33 ` Alan Stern
2019-03-11 8:36 ` [PATCH] " Kento.A.Kobayashi
2019-03-11 8:36 ` Kento.A.Kobayashi
2019-03-11 8:36 ` Kento.A.Kobayashi
2019-03-12 15:37 ` [PATCH] " Oliver Neukum
2019-03-12 15:37 ` Oliver Neukum
2019-03-15 2:28 ` [PATCH] " Kento.A.Kobayashi
2019-03-15 2:28 ` Kento.A.Kobayashi
2019-03-15 2:28 ` Kento.A.Kobayashi
2019-03-25 10:21 ` [PATCH] " Kento.A.Kobayashi
2019-03-25 10:21 ` Kento.A.Kobayashi
2019-03-25 10:21 ` Kento.A.Kobayashi
2019-03-25 10:34 ` [PATCH] " Oliver Neukum
2019-03-25 10:34 ` Oliver Neukum
2019-03-28 7:53 ` [PATCH] " Kento.A.Kobayashi
2019-03-28 7:53 ` Kento.A.Kobayashi
2019-03-28 7:53 ` Kento.A.Kobayashi
2019-03-28 15:15 ` [PATCH] " Oliver Neukum
2019-03-28 15:15 ` Oliver Neukum
2019-03-28 15:57 ` [PATCH] " Alan Stern
2019-03-28 15:57 ` Alan Stern
2019-03-28 15:57 ` Alan Stern
2019-03-28 16:49 ` [PATCH] " Oliver Neukum
2019-03-28 16:49 ` Oliver Neukum
2019-03-29 14:13 ` [PATCH] " Alan Stern
2019-03-29 14:13 ` Alan Stern
2019-03-29 14:13 ` Alan Stern
2019-04-02 0:28 ` [PATCH] " Kento.A.Kobayashi
2019-04-02 0:28 ` Kento.A.Kobayashi
2019-04-02 0:28 ` Kento.A.Kobayashi
2019-04-02 14:38 ` [PATCH] " Alan Stern
2019-04-02 14:38 ` Alan Stern
2019-04-02 14:38 ` Alan Stern
2019-04-04 3:57 ` [PATCH] " Kento.A.Kobayashi
2019-04-04 3:57 ` Kento.A.Kobayashi
2019-04-04 3:57 ` Kento.A.Kobayashi
2019-04-04 19:33 ` [PATCH] " Alan Stern
2019-04-04 19:33 ` Alan Stern
2019-04-04 19:33 ` Alan Stern
2019-04-09 0:28 ` [PATCH] " Kento.A.Kobayashi
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 0:28 ` Kento.A.Kobayashi
2019-04-09 1:21 ` [PATCH] " Alan Stern
2019-04-09 1:21 ` Alan Stern
2019-04-09 1:21 ` Alan Stern
2019-04-09 2:10 ` [PATCH] " Martin K. Petersen
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 2:10 ` Martin K. Petersen
2019-04-09 14:44 ` [PATCH] " Alan Stern
2019-04-09 14:44 ` Alan Stern
2019-04-09 14:44 ` Alan Stern
2019-04-09 15:16 ` [PATCH] " Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 15:16 ` Bart Van Assche
2019-04-09 16:45 ` [PATCH] " Alan Stern
2019-04-09 16:45 ` Alan Stern
2019-04-09 16:45 ` Alan Stern
2019-04-15 0:27 ` [PATCH] " Kento.A.Kobayashi
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 0:27 ` Kento.A.Kobayashi
2019-04-15 15:18 ` [PATCH] " Alan Stern
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:18 ` Alan Stern
2019-04-15 15:32 ` [PATCH] " Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-15 15:32 ` Alan Stern
2019-04-16 2:31 ` [PATCH] " Kento.A.Kobayashi
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-16 2:31 ` Kento.A.Kobayashi
2019-04-10 2:11 ` [PATCH] " Martin K. Petersen
2019-04-10 2:11 ` Martin K. Petersen
[not found] <16EA1F625E922C43B00B9D8225022050086961B5@APYOKXMS108.ap.sony.com>
2019-03-04 6:23 ` [PATCH] " Greg KH
2019-03-04 7:19 ` Jacky.Cao
2019-03-04 7:19 ` Jacky.Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1903081231260.1412-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=Kento.A.Kobayashi@sony.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.