* [PATCH][TRIVIAL] question marks again
@ 2003-10-13 15:54 Rik van Riel
2003-10-13 16:09 ` Thomas Horsten
0 siblings, 1 reply; 3+ messages in thread
From: Rik van Riel @ 2003-10-13 15:54 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: Kernel Mailing List
No question about it.
diff -urNp linux-5110/drivers/scsi/imm.c linux-10010/drivers/scsi/imm.c
--- linux-5110/drivers/scsi/imm.c
+++ linux-10010/drivers/scsi/imm.c
@@ -322,10 +322,10 @@ static unsigned char imm_wait(int host_n
* STR imm imm
* ===================================
* 0x80 S_REQ S_REQ
- * 0x40 !S_BSY (????)
+ * 0x40 !S_BSY (?)
* 0x20 !S_CD !S_CD
* 0x10 !S_IO !S_IO
- * 0x08 (????) !S_BSY
+ * 0x08 (?) !S_BSY
*
* imm imm meaning
* ==================================
@@ -927,7 +927,7 @@ static void imm_interrupt(void *data)
printk("imm: told to abort\n");
break;
case DID_PARITY:
- printk("imm: parity error (???)\n");
+ printk("imm: parity error (?)\n");
break;
case DID_ERROR:
printk("imm: internal driver error\n");
@@ -936,7 +936,7 @@ static void imm_interrupt(void *data)
printk("imm: told to reset device\n");
break;
case DID_BAD_INTR:
- printk("imm: bad interrupt (???)\n");
+ printk("imm: bad interrupt (?)\n");
break;
default:
printk("imm: bad return code (%02x)\n", (cmd->result >> 16) & 0xff);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][TRIVIAL] question marks again
2003-10-13 15:54 [PATCH][TRIVIAL] question marks again Rik van Riel
@ 2003-10-13 16:09 ` Thomas Horsten
2003-10-13 16:17 ` Rik van Riel
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Horsten @ 2003-10-13 16:09 UTC (permalink / raw)
To: Rik van Riel; +Cc: Marcelo Tosatti, Kernel Mailing List
On Mon, 13 Oct 2003, Rik van Riel wrote:
> No question about it.
>
> diff -urNp linux-5110/drivers/scsi/imm.c linux-10010/drivers/scsi/imm.c
> --- linux-5110/drivers/scsi/imm.c
> +++ linux-10010/drivers/scsi/imm.c
> @@ -322,10 +322,10 @@ static unsigned char imm_wait(int host_n
> * STR imm imm
> * ===================================
> * 0x80 S_REQ S_REQ
> - * 0x40 !S_BSY (????)
> + * 0x40 !S_BSY (?)
> * 0x20 !S_CD !S_CD
> * 0x10 !S_IO !S_IO
> - * 0x08 (????) !S_BSY
> + * 0x08 (?) !S_BSY
At least keep it lined up..
// Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][TRIVIAL] question marks again
2003-10-13 16:09 ` Thomas Horsten
@ 2003-10-13 16:17 ` Rik van Riel
0 siblings, 0 replies; 3+ messages in thread
From: Rik van Riel @ 2003-10-13 16:17 UTC (permalink / raw)
To: Thomas Horsten; +Cc: Marcelo Tosatti, Kernel Mailing List
On Mon, 13 Oct 2003, Thomas Horsten wrote:
> > + * 0x08 (?) !S_BSY
>
> At least keep it lined up..
Oops. Too many patches at once. Fixed now.
diff -urNp linux-5110/drivers/scsi/imm.c linux-10010/drivers/scsi/imm.c
--- linux-5110/drivers/scsi/imm.c
+++ linux-10010/drivers/scsi/imm.c
@@ -322,10 +322,10 @@ static unsigned char imm_wait(int host_n
* STR imm imm
* ===================================
* 0x80 S_REQ S_REQ
- * 0x40 !S_BSY (????)
+ * 0x40 !S_BSY (?)
* 0x20 !S_CD !S_CD
* 0x10 !S_IO !S_IO
- * 0x08 (????) !S_BSY
+ * 0x08 (?) !S_BSY
*
* imm imm meaning
* ==================================
@@ -927,7 +927,7 @@ static void imm_interrupt(void *data)
printk("imm: told to abort\n");
break;
case DID_PARITY:
- printk("imm: parity error (???)\n");
+ printk("imm: parity error (?)\n");
break;
case DID_ERROR:
printk("imm: internal driver error\n");
@@ -936,7 +936,7 @@ static void imm_interrupt(void *data)
printk("imm: told to reset device\n");
break;
case DID_BAD_INTR:
- printk("imm: bad interrupt (???)\n");
+ printk("imm: bad interrupt (?)\n");
break;
default:
printk("imm: bad return code (%02x)\n", (cmd->result >> 16) & 0xff);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-10-13 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-13 15:54 [PATCH][TRIVIAL] question marks again Rik van Riel
2003-10-13 16:09 ` Thomas Horsten
2003-10-13 16:17 ` Rik van Riel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.