From: Linus Torvalds <torvalds@osdl.org>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Christian Kujau <evil@g-house.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chuck Ebbert <76306.1226@compuserve.com>
Subject: Re: Oops in 2.6.10-rc1 (almost solved)
Date: Sat, 13 Nov 2004 20:43:34 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.58.0411132040330.12386@ppc970.osdl.org> (raw)
In-Reply-To: <20041114025814.GA20342@lists.us.dell.com>
On Sat, 13 Nov 2004, Matt Domsch wrote:
>
> Not ready for Linus yet
Indeed. Please don't use pushfl/popfl to save the carry flag. There are
tons of better ways.
For example, use "lea" instead of "add" to not write the flags (and add a
comment). Or save the carry flag in a register with
sbb %bx,%bx
ant test %bx later. Or any of a million other _standard_ ways to handle
this problem.
Linus
next prev parent reply other threads:[~2004-11-14 4:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-13 3:45 Oops in 2.6.10-rc1 (almost solved) Chuck Ebbert
2004-11-13 14:28 ` Matt Domsch
2004-11-13 18:55 ` Matt Domsch
2004-11-14 2:58 ` Matt Domsch
2004-11-14 4:43 ` Linus Torvalds [this message]
2004-11-14 11:45 ` Christian
2004-11-14 20:02 ` Christian Kujau
2004-11-14 21:55 ` Matt Domsch
2004-11-15 12:41 ` Oops in 2.6.10-rc1 (solved) Christian Kujau
-- strict thread matches above, loose matches on Subject: below --
2004-10-28 13:12 Oops in 2.6.10-rc1 Christian
2004-11-07 16:57 ` Linus Torvalds
2004-11-07 18:31 ` Christian Kujau
2004-11-07 23:45 ` Christian Kujau
2004-11-08 1:16 ` Linus Torvalds
2004-11-08 13:01 ` Christian Kujau
2004-11-08 18:13 ` Linus Torvalds
2004-11-08 20:59 ` Christian Kujau
2004-11-08 23:49 ` Christian Kujau
2004-11-09 1:31 ` Christian Kujau
2004-11-09 7:40 ` Pekka Enberg
2004-11-09 12:33 ` Christian Kujau
2004-11-09 17:26 ` Oops in 2.6.10-rc1 (almost solved) Christian Kujau
2004-11-09 18:53 ` Linus Torvalds
2004-11-09 23:30 ` Christian Kujau
2004-11-09 23:40 ` Matt Domsch
2004-11-10 0:21 ` Christian Kujau
2004-11-10 1:01 ` Linus Torvalds
2004-11-11 22:43 ` Matt Domsch
2004-11-11 22:53 ` Linus Torvalds
2004-11-11 22:55 ` Matt Domsch
2004-11-12 0:27 ` Christian Kujau
2004-11-12 0:49 ` Linus Torvalds
2004-11-12 1:27 ` Christian Kujau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0411132040330.12386@ppc970.osdl.org \
--to=torvalds@osdl.org \
--cc=76306.1226@compuserve.com \
--cc=Matt_Domsch@dell.com \
--cc=evil@g-house.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.