Re: Re: Changeset "acpi: disable PCI links at boot again, fix ELCR" -> on-board nic adapter not working

[Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org>]

On Sat, 2 Jul 2005, Alexander Nyberg wrote:
> 
> It appears this change:
> 
> diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c
> --- a/drivers/acpi/pci_irq.c
> +++ b/drivers/acpi/pci_irq.c
> @@ -435,6 +435,7 @@ acpi_pci_irq_enable (
>                 /* Interrupt Line values above 0xF are forbidden */
>                 if (dev->irq >= 0 && (dev->irq <= 0xF)) {
>                         printk(" - using IRQ %d\n", dev->irq);
> +                       acpi_register_gsi(dev->irq, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW);
>                         return_VALUE(0);
>                 }

Yes, that guy has:


	ACPI: PCI Interrupt 0000:00:10.0[A]: no GSI - using IRQ 0

and the fix is obvious: we should _not_ consider "irq 0" to be a valid 
irq, it's a sign that we don't have any irq at all.

I bet the correct thing to do is to change the "dev->irq >= 0" to 
"dev->irq > 0".

		Linus


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click