From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Johannes Sixt <johannes.sixt@telecom.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Do not change the file type if the filesystem does not support symlinks.
Date: Wed, 28 Feb 2007 18:53:13 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.63.0702281846360.22628@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <200702281840.07893.johannes.sixt@telecom.at>
Hi,
On Wed, 28 Feb 2007, Johannes Sixt wrote:
> On Tuesday 27 February 2007 23:54, Johannes Schindelin wrote:
> > On Tue, 27 Feb 2007, Johannes Sixt wrote:
> >
> > > @@ -125,7 +126,8 @@ static int ce_match_stat_basic(struct cache_entry
> > > *ce, struct stat *st) changed |= MODE_CHANGED;
> > > break;
> > > case S_IFLNK:
> > > - changed |= !S_ISLNK(st->st_mode) ? TYPE_CHANGED : 0;
> > > + if (trust_symlink_fmt && !S_ISLNK(st->st_mode))
> > > + changed |= TYPE_CHANGED;
> >
> > This does not handle the case symlink->directory, right?
>
> Something like:
>
> if (!S_ISLNK(st->st_mode) &&
> (trust_symlink_fmt || !S_ISREG(st->st_mode)))
> changed |= TYPE_CHANGE;
Yes.
> BTW, considering the size of the entire patch series, I'm thinking of
> submitting it in a single patch.
Makes sense.
Ciao,
Dscho
next prev parent reply other threads:[~2007-02-28 17:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 21:41 Implement core.symlinks to support filesystems without symlinks Johannes Sixt
2007-02-27 21:41 ` [PATCH] Add a flag core.symlinks analogous to core.filemode Johannes Sixt
2007-02-27 21:41 ` [PATCH] Do not change the file type if the filesystem does not support symlinks Johannes Sixt
2007-02-27 21:41 ` [PATCH] Create a symbolic link as a regular file on filesystems without symlinks Johannes Sixt
2007-02-27 21:41 ` [PATCH] diff-lib.c: Ignore type differences if the filesystem does not support symlinks Johannes Sixt
2007-02-27 21:41 ` [PATCH] Describe core.symlinks in the man pages Johannes Sixt
2007-02-27 22:44 ` [PATCH] Create a symbolic link as a regular file on filesystems without symlinks Johannes Schindelin
2007-02-28 17:18 ` Johannes Sixt
2007-02-27 22:54 ` [PATCH] Do not change the file type if the filesystem does not support symlinks Johannes Schindelin
2007-02-28 17:40 ` Johannes Sixt
2007-02-28 17:53 ` Johannes Schindelin [this message]
2007-02-27 23:13 ` Implement core.symlinks to support filesystems without symlinks Robin Rosenberg
2007-02-28 0:07 ` Johannes Schindelin
2007-02-28 22:48 ` Robin Rosenberg
2007-03-01 1:18 ` Johannes Schindelin
2007-03-01 11:56 ` Robin Rosenberg
2007-03-01 17:13 ` Johannes Schindelin
2007-03-01 19:24 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.63.0702281846360.22628@wbgn013.biozentrum.uni-wuerzburg.de \
--to=johannes.schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=johannes.sixt@telecom.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.