All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: Johannes Sixt <johannes.sixt@telecom.at>, git@vger.kernel.org
Subject: Re: Implement core.symlinks to support filesystems without symlinks
Date: Thu, 1 Mar 2007 02:18:22 +0100 (CET)	[thread overview]
Message-ID: <Pine.LNX.4.63.0703010213420.22628@wbgn013.biozentrum.uni-wuerzburg.de> (raw)
In-Reply-To: <200702282348.51478.robin.rosenberg.lists@dewire.com>

Hi,

On Wed, 28 Feb 2007, Robin Rosenberg wrote:

> onsdag 28 februari 2007 01:07 skrev Johannes Schindelin:
>
> > Your solution would fall short if one of the two files is changed. 
> > Since they are supposed to be symlinks, the application expects them 
> > to be identical, and weird sh*t happens.
>
> As will it when the file contain something completly different than 
> expected.

My points are these:

- If your project depends on symlinks, and you are on a system that does 
  not do symlinks, you're screwed. However, you might want to checkout the 
  project nevertheless.

- If you have a symlink, and your system does not do symlinks, you want 
  the information where the symlink points to, at least _somewhere_. 
  Without digging deep into Git internals.

- If you have a symlink, and your system ..., you want it to fail _early_.

The last point is reaaaaally important. There is a reason why we have 
compiler errors, instead of just blindly compiling it, and if that 
particular code path is triggered, explode in the face of the user.

So, all I would like to do on top of Johannes' patch is to add a _big_ 
_fat_ warning whenever Git realizes it has to substitute a file for a 
link, but I DON'T WANT THE BLOODY FILE TO BE COPIED.

Ciao,
Dscho

  reply	other threads:[~2007-03-01  1:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-27 21:41 Implement core.symlinks to support filesystems without symlinks Johannes Sixt
2007-02-27 21:41 ` [PATCH] Add a flag core.symlinks analogous to core.filemode Johannes Sixt
2007-02-27 21:41   ` [PATCH] Do not change the file type if the filesystem does not support symlinks Johannes Sixt
2007-02-27 21:41     ` [PATCH] Create a symbolic link as a regular file on filesystems without symlinks Johannes Sixt
2007-02-27 21:41       ` [PATCH] diff-lib.c: Ignore type differences if the filesystem does not support symlinks Johannes Sixt
2007-02-27 21:41         ` [PATCH] Describe core.symlinks in the man pages Johannes Sixt
2007-02-27 22:44       ` [PATCH] Create a symbolic link as a regular file on filesystems without symlinks Johannes Schindelin
2007-02-28 17:18         ` Johannes Sixt
2007-02-27 22:54     ` [PATCH] Do not change the file type if the filesystem does not support symlinks Johannes Schindelin
2007-02-28 17:40       ` Johannes Sixt
2007-02-28 17:53         ` Johannes Schindelin
2007-02-27 23:13 ` Implement core.symlinks to support filesystems without symlinks Robin Rosenberg
2007-02-28  0:07   ` Johannes Schindelin
2007-02-28 22:48     ` Robin Rosenberg
2007-03-01  1:18       ` Johannes Schindelin [this message]
2007-03-01 11:56         ` Robin Rosenberg
2007-03-01 17:13           ` Johannes Schindelin
2007-03-01 19:24           ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.63.0703010213420.22628@wbgn013.biozentrum.uni-wuerzburg.de \
    --to=johannes.schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=johannes.sixt@telecom.at \
    --cc=robin.rosenberg.lists@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.