From: James Simmons <jsimmons@infradead.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] mfd: SM501 core driver
Date: Thu, 8 Feb 2007 17:56:02 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0702081755290.7686@pentafluge.infradead.org> (raw)
In-Reply-To: <20070207170949.GD21120@fluff.org.uk>
Do you have a new patch?
> > No, that shuldn't be necessary. If it was, the compiler would optimise
> > away the first readl() in
> >
> > my_local = readl(foo);
> > my_local = readl(bar);
> >
> > which would break stuff. readl() implementations use volatile to prevent
> > this.
>
> Ok, i've moved these into their own function called
> sm501_sync_regs() to make it more explicit what it is
> being used for.
>
>
WARNING: multiple messages have this Message-ID (diff)
From: James Simmons <jsimmons@infradead.org>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Greg KH <greg@kroah.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: SM501 core driver
Date: Thu, 8 Feb 2007 17:56:02 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0702081755290.7686@pentafluge.infradead.org> (raw)
In-Reply-To: <20070207170949.GD21120@fluff.org.uk>
Do you have a new patch?
> > No, that shuldn't be necessary. If it was, the compiler would optimise
> > away the first readl() in
> >
> > my_local = readl(foo);
> > my_local = readl(bar);
> >
> > which would break stuff. readl() implementations use volatile to prevent
> > this.
>
> Ok, i've moved these into their own function called
> sm501_sync_regs() to make it more explicit what it is
> being used for.
>
>
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
next prev parent reply other threads:[~2007-02-08 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 19:26 [PATCH] mfd: SM501 core driver Ben Dooks
2007-02-07 5:09 ` Andrew Morton
2007-02-07 5:09 ` Andrew Morton
2007-02-07 11:48 ` Ben Dooks
2007-02-07 11:48 ` Ben Dooks
2007-02-07 14:24 ` Greg KH
2007-02-07 15:29 ` Ben Dooks
2007-02-07 16:52 ` Andrew Morton
2007-02-07 17:09 ` Ben Dooks
2007-02-07 17:09 ` Ben Dooks
2007-02-08 17:56 ` James Simmons [this message]
2007-02-08 17:56 ` James Simmons
2007-02-12 11:12 ` [Linux-fbdev-devel] " Ben Dooks
2007-02-07 17:38 ` Vincent Sanders
2007-02-07 17:38 ` Vincent Sanders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702081755290.7686@pentafluge.infradead.org \
--to=jsimmons@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=greg@kroah.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.