* [PATCH] Fix modular AGPGART (ia64 allmodconfig)
@ 2007-02-16 6:09 Zwane Mwaikambo
2007-02-16 6:23 ` Kyle McMartin
0 siblings, 1 reply; 3+ messages in thread
From: Zwane Mwaikambo @ 2007-02-16 6:09 UTC (permalink / raw)
To: Andrew Morton; +Cc: Dave Jones, Linux Kernel
My previous compat AGP patch broke modular AGPGART.
Test built on;
i386 CONFIG_AGP=y,m
x86_64 CONFIG_AGP=y
ia64 CONFIG_AGP=m
Signed-off-by: Zwane Mwaikambo <zwane@infradead.org>
Index: linux-2.6.20-mm1-ia64/drivers/char/agp/Makefile
===================================================================
RCS file: /home/cvsroot/linux-2.6.20-mm1/drivers/char/agp/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -B -r1.1.1.1 Makefile
--- linux-2.6.20-mm1-ia64/drivers/char/agp/Makefile 15 Feb 2007 17:35:27 -0000 1.1.1.1
+++ linux-2.6.20-mm1-ia64/drivers/char/agp/Makefile 16 Feb 2007 05:47:27 -0000
@@ -1,7 +1,10 @@
agpgart-y := backend.o frontend.o generic.o isoch.o
+ifeq ($(CONFIG_COMPAT),y)
+agpgart-y += compat_ioctl.o
+endif
+
obj-$(CONFIG_AGP) += agpgart.o
-obj-$(CONFIG_COMPAT) += compat_ioctl.o
obj-$(CONFIG_AGP_ALI) += ali-agp.o
obj-$(CONFIG_AGP_ATI) += ati-agp.o
obj-$(CONFIG_AGP_AMD) += amd-k7-agp.o
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)
2007-02-16 6:09 [PATCH] Fix modular AGPGART (ia64 allmodconfig) Zwane Mwaikambo
@ 2007-02-16 6:23 ` Kyle McMartin
2007-02-16 6:45 ` Zwane Mwaikambo
0 siblings, 1 reply; 3+ messages in thread
From: Kyle McMartin @ 2007-02-16 6:23 UTC (permalink / raw)
To: Zwane Mwaikambo; +Cc: Andrew Morton, Dave Jones, Linux Kernel
On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote:
> +ifeq ($(CONFIG_COMPAT),y)
> +agpgart-y += compat_ioctl.o
> +endif
> +
eh?
Couldn't this be?
agpgart-$(CONFIG_COMPAT) += compat_ioctl.o
Cheers,
Kyle M.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix modular AGPGART (ia64 allmodconfig)
2007-02-16 6:23 ` Kyle McMartin
@ 2007-02-16 6:45 ` Zwane Mwaikambo
0 siblings, 0 replies; 3+ messages in thread
From: Zwane Mwaikambo @ 2007-02-16 6:45 UTC (permalink / raw)
To: Kyle McMartin; +Cc: Andrew Morton, Dave Jones, Linux Kernel
On Fri, 16 Feb 2007, Kyle McMartin wrote:
> On Thu, Feb 15, 2007 at 10:09:57PM -0800, Zwane Mwaikambo wrote:
> > +ifeq ($(CONFIG_COMPAT),y)
> > +agpgart-y += compat_ioctl.o
> > +endif
> > +
>
> eh?
>
> Couldn't this be?
> agpgart-$(CONFIG_COMPAT) += compat_ioctl.o
Yep thay works too and does look cleaner
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-02-16 6:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-16 6:09 [PATCH] Fix modular AGPGART (ia64 allmodconfig) Zwane Mwaikambo
2007-02-16 6:23 ` Kyle McMartin
2007-02-16 6:45 ` Zwane Mwaikambo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.