All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6/15] arch/arm/mach-shark: Use DIV_ROUND_CLOSEST
@ 2009-08-02  8:46 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2009-08-02  8:46 UTC (permalink / raw)
  To: alex, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression x,__divisor;
@@

- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 arch/arm/mach-shark/core.c          |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-shark/core.c b/arch/arm/mach-shark/core.c
index 358d875..a4eae65 100644
--- a/arch/arm/mach-shark/core.c
+++ b/arch/arm/mach-shark/core.c
@@ -119,7 +119,7 @@ static void __init shark_map_io(void)
 }
 
 #define IRQ_TIMER 0
-#define HZ_TIME ((1193180 + HZ/2) / HZ)
+#define HZ_TIME DIV_ROUND_CLOSEST(1193180, HZ)
 
 static irqreturn_t
 shark_timer_interrupt(int irq, void *dev_id)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 6/15] arch/arm/mach-shark: Use DIV_ROUND_CLOSEST
@ 2009-08-02  8:46 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2009-08-02  8:46 UTC (permalink / raw)
  To: alex, linux-kernel, kernel-janitors

From: Julia Lawall <julia@diku.dk>

The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@haskernel@
@@

#include <linux/kernel.h>

@depends on haskernel@
expression x,__divisor;
@@

- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 arch/arm/mach-shark/core.c          |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-shark/core.c b/arch/arm/mach-shark/core.c
index 358d875..a4eae65 100644
--- a/arch/arm/mach-shark/core.c
+++ b/arch/arm/mach-shark/core.c
@@ -119,7 +119,7 @@ static void __init shark_map_io(void)
 }
 
 #define IRQ_TIMER 0
-#define HZ_TIME ((1193180 + HZ/2) / HZ)
+#define HZ_TIME DIV_ROUND_CLOSEST(1193180, HZ)
 
 static irqreturn_t
 shark_timer_interrupt(int irq, void *dev_id)

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-08-02  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-02  8:46 [PATCH 6/15] arch/arm/mach-shark: Use DIV_ROUND_CLOSEST Julia Lawall
2009-08-02  8:46 ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.