* [PATCH 12/15] drivers/atm: Use DIV_ROUND_CLOSEST
@ 2009-08-02 8:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-02 8:48 UTC (permalink / raw)
To: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression x,__divisor;
@@
- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/atm/horizon.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 6b969f8..01ce241 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -641,7 +641,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
pre = 1;
break;
case round_nearest:
- pre = (br+(c<<div)/2)/(c<<div);
+ pre = DIV_ROUND_CLOSEST(br, c<<div);
// but p must be non-zero
if (!pre)
pre = 1;
@@ -671,7 +671,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
pre = DIV_ROUND_UP(br, c<<div);
break;
case round_nearest:
- pre = (br+(c<<div)/2)/(c<<div);
+ pre = DIV_ROUND_CLOSEST(br, c<<div);
break;
default: /* round_up */
pre = br/(c<<div);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 12/15] drivers/atm: Use DIV_ROUND_CLOSEST
@ 2009-08-02 8:48 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2009-08-02 8:48 UTC (permalink / raw)
To: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@haskernel@
@@
#include <linux/kernel.h>
@depends on haskernel@
expression x,__divisor;
@@
- (((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/atm/horizon.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 6b969f8..01ce241 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -641,7 +641,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
pre = 1;
break;
case round_nearest:
- pre = (br+(c<<div)/2)/(c<<div);
+ pre = DIV_ROUND_CLOSEST(br, c<<div);
// but p must be non-zero
if (!pre)
pre = 1;
@@ -671,7 +671,7 @@ static int make_rate (const hrz_dev * dev, u32 c, rounding r,
pre = DIV_ROUND_UP(br, c<<div);
break;
case round_nearest:
- pre = (br+(c<<div)/2)/(c<<div);
+ pre = DIV_ROUND_CLOSEST(br, c<<div);
break;
default: /* round_up */
pre = br/(c<<div);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 12/15] drivers/atm: Use DIV_ROUND_CLOSEST
2009-08-02 8:48 ` Julia Lawall
@ 2009-08-02 19:55 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-08-02 19:55 UTC (permalink / raw)
To: julia; +Cc: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sun, 2 Aug 2009 10:48:45 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 12/15] drivers/atm: Use DIV_ROUND_CLOSEST
@ 2009-08-02 19:55 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-08-02 19:55 UTC (permalink / raw)
To: julia; +Cc: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Sun, 2 Aug 2009 10:48:45 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-08-02 19:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-02 8:48 [PATCH 12/15] drivers/atm: Use DIV_ROUND_CLOSEST Julia Lawall
2009-08-02 8:48 ` Julia Lawall
2009-08-02 19:55 ` David Miller
2009-08-02 19:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.