* [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs
@ 2009-09-18 18:11 John R. Lange
0 siblings, 0 replies; 3+ messages in thread
From: John R. Lange @ 2009-09-18 18:11 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 737 bytes --]
It looks like there was a minor calculation error in the SVM_EXIT_MSR bitmap
lookup.
---
target-i386/op_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c3f5af6..dcee7a3 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t type,
uint64_t param)
switch((uint32_t)ECX) {
case 0 ... 0x1fff:
t0 = (ECX * 2) % 8;
- t1 = ECX / 8;
+ t1 = (ECX * 2) / 8;
break;
case 0xc0000000 ... 0xc0001fff:
t0 = (8192 + ECX - 0xc0000000) * 2;
--
1.6.0.2
[-- Attachment #2: Type: TEXT/PLAIN, Size: 910 bytes --]
From 37ae301634c1d535f77b879dae48e68abb6e69ba Mon Sep 17 00:00:00 2001
From: Jack Lange <jarusl@cs.northwestern.edu>
Date: Thu, 17 Sep 2009 13:43:14 -0500
Subject: [PATCH] fixed bug in SVM_EXIT_MSR handler's bitmap lookup for low order MSRs
---
target-i386/op_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c3f5af6..dcee7a3 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
switch((uint32_t)ECX) {
case 0 ... 0x1fff:
t0 = (ECX * 2) % 8;
- t1 = ECX / 8;
+ t1 = (ECX * 2) / 8;
break;
case 0xc0000000 ... 0xc0001fff:
t0 = (8192 + ECX - 0xc0000000) * 2;
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs
2009-09-17 20:13 John R. Lange
@ 2009-09-30 19:19 ` Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2009-09-30 19:19 UTC (permalink / raw)
To: John R. Lange; +Cc: qemu-devel
John R. Lange wrote:
>
> It looks like there was a minor calculation error in the SVM_EXIT_MSR
> bitmap lookup.
Missinged Signed-off-by, also doesn't apply to tip.
Regards,
Anthony Liguori
> ---
> target-i386/op_helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
> index c3f5af6..dcee7a3 100644
> --- a/target-i386/op_helper.c
> +++ b/target-i386/op_helper.c
> @@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t
> type, uint64_t param)
> switch((uint32_t)ECX) {
> case 0 ... 0x1fff:
> t0 = (ECX * 2) % 8;
> - t1 = ECX / 8;
> + t1 = (ECX * 2) / 8;
> break;
> case 0xc0000000 ... 0xc0001fff:
> t0 = (8192 + ECX - 0xc0000000) * 2;
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs
@ 2009-09-17 20:13 John R. Lange
2009-09-30 19:19 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: John R. Lange @ 2009-09-17 20:13 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 736 bytes --]
It looks like there was a minor calculation error in the SVM_EXIT_MSR bitmap lookup.
---
target-i386/op_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c3f5af6..dcee7a3 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
switch((uint32_t)ECX) {
case 0 ... 0x1fff:
t0 = (ECX * 2) % 8;
- t1 = ECX / 8;
+ t1 = (ECX * 2) / 8;
break;
case 0xc0000000 ... 0xc0001fff:
t0 = (8192 + ECX - 0xc0000000) * 2;
--
1.6.0.2
[-- Attachment #2: Type: TEXT/PLAIN, Size: 910 bytes --]
From 37ae301634c1d535f77b879dae48e68abb6e69ba Mon Sep 17 00:00:00 2001
From: Jack Lange <jarusl@cs.northwestern.edu>
Date: Thu, 17 Sep 2009 13:43:14 -0500
Subject: [PATCH] fixed bug in SVM_EXIT_MSR handler's bitmap lookup for low order MSRs
---
target-i386/op_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c
index c3f5af6..dcee7a3 100644
--- a/target-i386/op_helper.c
+++ b/target-i386/op_helper.c
@@ -5209,7 +5209,7 @@ void helper_svm_check_intercept_param(uint32_t type, uint64_t param)
switch((uint32_t)ECX) {
case 0 ... 0x1fff:
t0 = (ECX * 2) % 8;
- t1 = ECX / 8;
+ t1 = (ECX * 2) / 8;
break;
case 0xc0000000 ... 0xc0001fff:
t0 = (8192 + ECX - 0xc0000000) * 2;
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-30 19:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-18 18:11 [Qemu-devel] [PATCH] fixed bug in SVM_EXIT_MSR handlers MSR bitmap lookup for low order MSRs John R. Lange
-- strict thread matches above, loose matches on Subject: below --
2009-09-17 20:13 John R. Lange
2009-09-30 19:19 ` Anthony Liguori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.