* [PATCH] v4l2-ctrls.c was missing slab.h
@ 2010-08-12 19:04 Christopher Friedt
2010-08-12 20:20 ` Guennadi Liakhovetski
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Friedt @ 2010-08-12 19:04 UTC (permalink / raw)
To: linux-media; +Cc: Christopher Friedt
Fixed broken compile of drivers/media/video/v4l2-ctrls.c.
It failed due to missing #include <linux/slab.h>, and errored-out with
"implicit declaration of function kzalloc, kmalloc, ..."
Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
---
drivers/media/video/v4l2-ctrls.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
index 84c1a53..1d09804 100644
--- a/drivers/media/video/v4l2-ctrls.c
+++ b/drivers/media/video/v4l2-ctrls.c
@@ -18,6 +18,7 @@
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
+#include <linux/slab.h>
#include <linux/ctype.h>
#include <media/v4l2-ioctl.h>
#include <media/v4l2-device.h>
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] v4l2-ctrls.c was missing slab.h
2010-08-12 19:04 [PATCH] v4l2-ctrls.c was missing slab.h Christopher Friedt
@ 2010-08-12 20:20 ` Guennadi Liakhovetski
0 siblings, 0 replies; 2+ messages in thread
From: Guennadi Liakhovetski @ 2010-08-12 20:20 UTC (permalink / raw)
To: Christopher Friedt; +Cc: linux-media
On Thu, 12 Aug 2010, Christopher Friedt wrote:
> Fixed broken compile of drivers/media/video/v4l2-ctrls.c.
> It failed due to missing #include <linux/slab.h>, and errored-out with
> "implicit declaration of function kzalloc, kmalloc, ..."
>
> Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
> ---
> drivers/media/video/v4l2-ctrls.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
> index 84c1a53..1d09804 100644
> --- a/drivers/media/video/v4l2-ctrls.c
> +++ b/drivers/media/video/v4l2-ctrls.c
> @@ -18,6 +18,7 @@
> Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> +#include <linux/slab.h>
> #include <linux/ctype.h>
an alphabetic order is preferred, even if it is not preserved elsewhere in
the file...
Thanks
Guennadi
> #include <media/v4l2-ioctl.h>
> #include <media/v4l2-device.h>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-12 20:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-12 19:04 [PATCH] v4l2-ctrls.c was missing slab.h Christopher Friedt
2010-08-12 20:20 ` Guennadi Liakhovetski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.