* [PATCH 3/5] fs/btrfs: Eliminate memory leak
@ 2010-08-24 14:39 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2010-08-24 14:39 UTC (permalink / raw)
To: Chris Mason, linux-btrfs, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
This code is preceded by a call to btrfs_alloc_path, which allocates some
memory. There is some error handling code at the end of the function that
frees it, that can be taken advantage of with a little ordering adjustment.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression E;
identifier f1;
iterator I;
@@
x = btrfs_alloc_path(...);
<... when != x
when != true (x == NULL || ...)
when != if (...) { <+...x...+> }
when != I (...) { <+...x...+> }
(
x == NULL
|
x == E
|
x->f1
)
...>
* return ...;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
fs/btrfs/inode.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index c038644..d38587c 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4438,15 +4438,14 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
BUG_ON(!path);
inode = new_inode(root->fs_info->sb);
- if (!inode)
- return ERR_PTR(-ENOMEM);
-
+ if (!inode) {
+ ret = -ENOMEM;
+ goto fail_path;
+ }
if (dir) {
ret = btrfs_set_inode_index(dir, index);
- if (ret) {
- iput(inode);
- return ERR_PTR(ret);
- }
+ if (ret)
+ goto fail_inode;
}
/*
* index_cnt is ignored for everything but a dir,
@@ -4519,8 +4518,10 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
fail:
if (dir)
BTRFS_I(dir)->index_cnt--;
- btrfs_free_path(path);
+fail_inode:
iput(inode);
+fail_path:
+ btrfs_free_path(path);
return ERR_PTR(ret);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 3/5] fs/btrfs: Eliminate memory leak
@ 2010-08-24 14:39 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2010-08-24 14:39 UTC (permalink / raw)
To: Chris Mason, linux-btrfs, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
This code is preceded by a call to btrfs_alloc_path, which allocates some
memory. There is some error handling code at the end of the function that
frees it, that can be taken advantage of with a little ordering adjustment.
A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
local idexpression x;
expression E;
identifier f1;
iterator I;
@@
x = btrfs_alloc_path(...);
<... when != x
when != true (x = NULL || ...)
when != if (...) { <+...x...+> }
when != I (...) { <+...x...+> }
(
x = NULL
|
x = E
|
x->f1
)
...>
* return ...;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
fs/btrfs/inode.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index c038644..d38587c 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4438,15 +4438,14 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
BUG_ON(!path);
inode = new_inode(root->fs_info->sb);
- if (!inode)
- return ERR_PTR(-ENOMEM);
-
+ if (!inode) {
+ ret = -ENOMEM;
+ goto fail_path;
+ }
if (dir) {
ret = btrfs_set_inode_index(dir, index);
- if (ret) {
- iput(inode);
- return ERR_PTR(ret);
- }
+ if (ret)
+ goto fail_inode;
}
/*
* index_cnt is ignored for everything but a dir,
@@ -4519,8 +4518,10 @@ static struct inode *btrfs_new_inode(struct btrfs_trans_handle *trans,
fail:
if (dir)
BTRFS_I(dir)->index_cnt--;
- btrfs_free_path(path);
+fail_inode:
iput(inode);
+fail_path:
+ btrfs_free_path(path);
return ERR_PTR(ret);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/5] fs/btrfs: Eliminate memory leak
[not found] ` <1282776100-21671-4-git-send-email-julia@diku.dk>
@ 2010-08-25 21:57 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2010-08-25 21:57 UTC (permalink / raw)
To: Chris Mason; +Cc: linux-btrfs
Hi all,
I'm really sorry to have spammed your mailbox with my send-email
experiments...
julia
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-25 21:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-24 14:39 [PATCH 3/5] fs/btrfs: Eliminate memory leak Julia Lawall
2010-08-24 14:39 ` Julia Lawall
[not found] <1282776100-21671-1-git-send-email-julia@diku.dk>
[not found] ` <1282776100-21671-4-git-send-email-julia@diku.dk>
2010-08-25 21:57 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.