From: Julia Lawall <julia@diku.dk>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
kernel-janitors@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak
Date: Tue, 31 Aug 2010 18:55:45 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.64.1008311853040.2668@ask.diku.dk> (raw)
In-Reply-To: <20100831165153.GB28015@pengutronix.de>
On Tue, 31 Aug 2010, Wolfram Sang wrote:
> On Tue, Aug 31, 2010 at 05:48:57PM +0200, Julia Lawall wrote:
> > Add a call to of_node_put in the error handling code following a call to
> > of_find_matching_node.
> >
> > This patch also moves the existing call to of_node_put after the call to
> > iounmap in the error handling code, to make it possible to jump to
> > of_node_put without doing iounmap. These appear to be disjoint operations,
> > so the ordering doesn't matter.
>
> Hmm, the function you change returns -ENODEV if a clock cannot be found, but
> the return type is u32. This should better be 0. Can you take care of this as
> well?
I'll look at it. I was trying to make the returned value be signed, which
seemed to have some slightly complicated repercussions, but a return value
of 0 may work out much better.
julia
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia@diku.dk>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
kernel-janitors@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
socketcan-core@lists.berlios.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put
Date: Tue, 31 Aug 2010 16:55:45 +0000 [thread overview]
Message-ID: <Pine.LNX.4.64.1008311853040.2668@ask.diku.dk> (raw)
In-Reply-To: <20100831165153.GB28015@pengutronix.de>
On Tue, 31 Aug 2010, Wolfram Sang wrote:
> On Tue, Aug 31, 2010 at 05:48:57PM +0200, Julia Lawall wrote:
> > Add a call to of_node_put in the error handling code following a call to
> > of_find_matching_node.
> >
> > This patch also moves the existing call to of_node_put after the call to
> > iounmap in the error handling code, to make it possible to jump to
> > of_node_put without doing iounmap. These appear to be disjoint operations,
> > so the ordering doesn't matter.
>
> Hmm, the function you change returns -ENODEV if a clock cannot be found, but
> the return type is u32. This should better be 0. Can you take care of this as
> well?
I'll look at it. I was trying to make the returned value be signed, which
seemed to have some slightly complicated repercussions, but a return value
of 0 may work out much better.
julia
next prev parent reply other threads:[~2010-08-31 16:55 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 15:48 [PATCH 0/4] Add of_node_put to avoid memory leak Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` [PATCH 1/4] drivers/serial/ucc_uart.c: " Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-09-01 18:40 ` Timur Tabi
2010-09-01 18:40 ` Timur Tabi
2010-09-01 18:40 ` [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid Timur Tabi
2010-09-01 18:40 ` [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak Timur Tabi
2010-09-08 19:59 ` Grant Likely
2010-09-08 19:59 ` Grant Likely
2010-09-08 19:59 ` [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to Grant Likely
2011-03-15 15:51 ` [PATCH 1/4] drivers/serial/ucc_uart.c: Add of_node_put to avoid memory leak Kumar Gala
2011-03-15 15:51 ` Kumar Gala
2011-03-15 15:51 ` Kumar Gala
2011-03-15 15:51 ` Kumar Gala
2010-08-31 15:48 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: " Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:59 ` Mark Brown
2010-08-31 15:59 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid Mark Brown
2010-08-31 15:59 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid memory leak Mark Brown
2010-09-01 18:39 ` [alsa-devel] " Timur Tabi
2010-09-01 18:39 ` [alsa-devel] [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add Timur Tabi
2010-09-01 18:49 ` [alsa-devel] [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid memory leak Liam Girdwood
2010-09-01 18:49 ` [alsa-devel] [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add Liam Girdwood
2010-09-01 18:49 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid memory leak Liam Girdwood
2010-09-02 15:30 ` Mark Brown
2010-09-02 15:30 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid Mark Brown
2010-09-02 15:30 ` [PATCH 2/4] sound/soc/fsl/p1022_ds.c: Add of_node_put to avoid memory leak Mark Brown
2010-08-31 15:48 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: " Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 16:51 ` Wolfram Sang
2010-08-31 16:51 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add Wolfram Sang
2010-08-31 16:51 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Wolfram Sang
2010-08-31 16:55 ` Julia Lawall [this message]
2010-08-31 16:55 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put Julia Lawall
2010-08-31 17:44 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Julia Lawall
2010-08-31 17:44 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put Julia Lawall
2010-08-31 17:44 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Julia Lawall
2010-08-31 19:10 ` Wolfram Sang
2010-08-31 19:10 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add Wolfram Sang
2010-08-31 19:10 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Wolfram Sang
2010-08-31 19:22 ` Wolfgang Grandegger
2010-08-31 19:22 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put Wolfgang Grandegger
2010-08-31 19:22 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak Wolfgang Grandegger
2010-09-01 17:59 ` David Miller
2010-09-01 17:59 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add David Miller
2010-09-01 17:59 ` [PATCH 3/4] drivers/net/can/mscan/mpc5xxx_can.c: Add of_node_put to avoid memory leak David Miller
2010-08-31 15:48 ` [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: " Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-08-31 15:48 ` Julia Lawall
2010-09-08 20:00 ` Grant Likely
2010-09-08 20:00 ` Grant Likely
2010-09-08 20:00 ` [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: Add Grant Likely
2010-09-08 20:00 ` [PATCH 4/4] arch/powerpc/platforms/chrp/nvram.c: Add of_node_put to avoid memory leak Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.1008311853040.2668@ask.diku.dk \
--to=julia@diku.dk \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=w.sang@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.