* [PATCH] [media] mx2_camera: use module_platform_driver_probe()
@ 2013-03-18 9:43 Fabio Porcedda
2013-03-18 10:09 ` Guennadi Liakhovetski
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Porcedda @ 2013-03-18 9:43 UTC (permalink / raw)
To: linux-media; +Cc: Fabio Estevam, Guennadi Liakhovetski, Mauro Carvalho Chehab
The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
used module_platform_driver() to make code smaller,
but since the driver used platform_driver_probe is more appropriate
to use module_platform_driver_probe().
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
---
drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
index ffba7d9..848dff9 100644
--- a/drivers/media/platform/soc_camera/mx2_camera.c
+++ b/drivers/media/platform/soc_camera/mx2_camera.c
@@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
},
.id_table = mx2_camera_devtype,
.remove = mx2_camera_remove,
- .probe = mx2_camera_probe,
};
-module_platform_driver(mx2_camera_driver);
+module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
MODULE_AUTHOR("Sascha Hauer <sha@pengutronix.de>");
--
1.8.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()
2013-03-18 9:43 [PATCH] [media] mx2_camera: use module_platform_driver_probe() Fabio Porcedda
@ 2013-03-18 10:09 ` Guennadi Liakhovetski
2013-04-03 9:37 ` Fabio Porcedda
0 siblings, 1 reply; 5+ messages in thread
From: Guennadi Liakhovetski @ 2013-03-18 10:09 UTC (permalink / raw)
To: Fabio Porcedda; +Cc: linux-media, Fabio Estevam, Mauro Carvalho Chehab
Hi Fabio
On Mon, 18 Mar 2013, Fabio Porcedda wrote:
> The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
> used module_platform_driver() to make code smaller,
> but since the driver used platform_driver_probe is more appropriate
> to use module_platform_driver_probe().
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Thanks, will queue for 3.10.
Guennadi
> ---
> drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
> index ffba7d9..848dff9 100644
> --- a/drivers/media/platform/soc_camera/mx2_camera.c
> +++ b/drivers/media/platform/soc_camera/mx2_camera.c
> @@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
> },
> .id_table = mx2_camera_devtype,
> .remove = mx2_camera_remove,
> - .probe = mx2_camera_probe,
> };
>
> -module_platform_driver(mx2_camera_driver);
> +module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
>
> MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
> MODULE_AUTHOR("Sascha Hauer <sha@pengutronix.de>");
> --
> 1.8.2
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()
2013-03-18 10:09 ` Guennadi Liakhovetski
@ 2013-04-03 9:37 ` Fabio Porcedda
2013-04-03 10:30 ` Guennadi Liakhovetski
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Porcedda @ 2013-04-03 9:37 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-media, Fabio Estevam, Mauro Carvalho Chehab
On Mon, Mar 18, 2013 at 11:09 AM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> Hi Fabio
>
> On Mon, 18 Mar 2013, Fabio Porcedda wrote:
>
>> The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
>> used module_platform_driver() to make code smaller,
>> but since the driver used platform_driver_probe is more appropriate
>> to use module_platform_driver_probe().
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> Thanks, will queue for 3.10.
Thanks for taking it.
In which repository/branch is it?
This commit is not in linux-next or in
git://linuxtv.org/mchehab/media-next.git yet.
Best regards
--
Fabio Porcedda
> Guennadi
>
>> ---
>> drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
>> index ffba7d9..848dff9 100644
>> --- a/drivers/media/platform/soc_camera/mx2_camera.c
>> +++ b/drivers/media/platform/soc_camera/mx2_camera.c
>> @@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
>> },
>> .id_table = mx2_camera_devtype,
>> .remove = mx2_camera_remove,
>> - .probe = mx2_camera_probe,
>> };
>>
>> -module_platform_driver(mx2_camera_driver);
>> +module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
>>
>> MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
>> MODULE_AUTHOR("Sascha Hauer <sha@pengutronix.de>");
>> --
>> 1.8.2
>>
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()
2013-04-03 9:37 ` Fabio Porcedda
@ 2013-04-03 10:30 ` Guennadi Liakhovetski
2013-04-04 10:14 ` Fabio Porcedda
0 siblings, 1 reply; 5+ messages in thread
From: Guennadi Liakhovetski @ 2013-04-03 10:30 UTC (permalink / raw)
To: Fabio Porcedda; +Cc: linux-media, Fabio Estevam, Mauro Carvalho Chehab
On Wed, 3 Apr 2013, Fabio Porcedda wrote:
> On Mon, Mar 18, 2013 at 11:09 AM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > Hi Fabio
> >
> > On Mon, 18 Mar 2013, Fabio Porcedda wrote:
> >
> >> The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
> >> used module_platform_driver() to make code smaller,
> >> but since the driver used platform_driver_probe is more appropriate
> >> to use module_platform_driver_probe().
> >>
> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> >> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> >> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> >
> > Thanks, will queue for 3.10.
>
> Thanks for taking it.
> In which repository/branch is it?
> This commit is not in linux-next or in
> git://linuxtv.org/mchehab/media-next.git yet.
Not yet. I'm preparing a branch locally to push to my repository on
git.linuxtv.org. I'll do that within a day or two, if no objections
emerge. Then I'll send a pull request to Mauro, then a couple of days
later he'll pull from my tree, then patches will appear in -next.
Thanks
Guennadi
>
> Best regards
> --
> Fabio Porcedda
>
> > Guennadi
> >
> >> ---
> >> drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
> >> index ffba7d9..848dff9 100644
> >> --- a/drivers/media/platform/soc_camera/mx2_camera.c
> >> +++ b/drivers/media/platform/soc_camera/mx2_camera.c
> >> @@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
> >> },
> >> .id_table = mx2_camera_devtype,
> >> .remove = mx2_camera_remove,
> >> - .probe = mx2_camera_probe,
> >> };
> >>
> >> -module_platform_driver(mx2_camera_driver);
> >> +module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
> >>
> >> MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
> >> MODULE_AUTHOR("Sascha Hauer <sha@pengutronix.de>");
> >> --
> >> 1.8.2
> >>
> >
> > ---
> > Guennadi Liakhovetski, Ph.D.
> > Freelance Open-Source Software Developer
> > http://www.open-technology.de/
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [media] mx2_camera: use module_platform_driver_probe()
2013-04-03 10:30 ` Guennadi Liakhovetski
@ 2013-04-04 10:14 ` Fabio Porcedda
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Porcedda @ 2013-04-04 10:14 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-media, Fabio Estevam, Mauro Carvalho Chehab
On Wed, Apr 3, 2013 at 12:30 PM, Guennadi Liakhovetski
<g.liakhovetski@gmx.de> wrote:
> On Wed, 3 Apr 2013, Fabio Porcedda wrote:
>
>> On Mon, Mar 18, 2013 at 11:09 AM, Guennadi Liakhovetski
>> <g.liakhovetski@gmx.de> wrote:
>> > Hi Fabio
>> >
>> > On Mon, 18 Mar 2013, Fabio Porcedda wrote:
>> >
>> >> The commit 39793c6 "[media] mx2_camera: Convert it to platform driver"
>> >> used module_platform_driver() to make code smaller,
>> >> but since the driver used platform_driver_probe is more appropriate
>> >> to use module_platform_driver_probe().
>> >>
>> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>> >> Cc: Fabio Estevam <fabio.estevam@freescale.com>
>> >> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>> >> Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
>> >
>> > Thanks, will queue for 3.10.
>>
>> Thanks for taking it.
>> In which repository/branch is it?
>> This commit is not in linux-next or in
>> git://linuxtv.org/mchehab/media-next.git yet.
>
> Not yet. I'm preparing a branch locally to push to my repository on
> git.linuxtv.org. I'll do that within a day or two, if no objections
> emerge. Then I'll send a pull request to Mauro, then a couple of days
> later he'll pull from my tree, then patches will appear in -next.
Thanks.
Regards
Fabio Porcedda
> Thanks
> Guennadi
>
>>
>> Best regards
>> --
>> Fabio Porcedda
>>
>> > Guennadi
>> >
>> >> ---
>> >> drivers/media/platform/soc_camera/mx2_camera.c | 3 +--
>> >> 1 file changed, 1 insertion(+), 2 deletions(-)
>> >>
>> >> diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c
>> >> index ffba7d9..848dff9 100644
>> >> --- a/drivers/media/platform/soc_camera/mx2_camera.c
>> >> +++ b/drivers/media/platform/soc_camera/mx2_camera.c
>> >> @@ -1619,10 +1619,9 @@ static struct platform_driver mx2_camera_driver = {
>> >> },
>> >> .id_table = mx2_camera_devtype,
>> >> .remove = mx2_camera_remove,
>> >> - .probe = mx2_camera_probe,
>> >> };
>> >>
>> >> -module_platform_driver(mx2_camera_driver);
>> >> +module_platform_driver_probe(mx2_camera_driver, mx2_camera_probe);
>> >>
>> >> MODULE_DESCRIPTION("i.MX27 SoC Camera Host driver");
>> >> MODULE_AUTHOR("Sascha Hauer <sha@pengutronix.de>");
>> >> --
>> >> 1.8.2
>> >>
>> >
>> > ---
>> > Guennadi Liakhovetski, Ph.D.
>> > Freelance Open-Source Software Developer
>> > http://www.open-technology.de/
>>
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
--
Fabio Porcedda
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-04 10:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-18 9:43 [PATCH] [media] mx2_camera: use module_platform_driver_probe() Fabio Porcedda
2013-03-18 10:09 ` Guennadi Liakhovetski
2013-04-03 9:37 ` Fabio Porcedda
2013-04-03 10:30 ` Guennadi Liakhovetski
2013-04-04 10:14 ` Fabio Porcedda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.