* [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.
@ 2014-08-21 10:09 Anton Altaparmakov
2014-09-04 22:01 ` Anton Altaparmakov
0 siblings, 1 reply; 2+ messages in thread
From: Anton Altaparmakov @ 2014-08-21 10:09 UTC (permalink / raw)
To: Linus Torvalds
Cc: Theodore Ts'o, Al Viro, Christoph Hellwig, Andrew Morton,
linux-kernel, linux-fsdevel
This patch changes sync_filesystem() to be EXPORT_SYMBOL().
The reason this is needed is that starting with 3.15 kernel, due to
Theodore Ts'o's commit 02b9984d640873b7b3809e63f81a0d7e13496886, "fs: push
sync_filesystem() down to the file system's remount_fs()", all file
systems that have dirty data to be written out need to call
sync_filesystem() from their ->remount_fs() method when remounting
read-only.
As this is now a generically required function rather than an internal
only function it should be EXPORT_SYMBOL() so that all file systems can
call it.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
---
Hi Linus,
Can you please apply this patch for inclusion into 3.17? Explanation is
above.
Thanks a lot in advance!
PS. I hope Pine does not mess up the whitespace of the patch!
Best regards,
Anton
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
--- linux/fs/sync.c 2014-08-21 10:30:26.000000000 +0100
+++ linux/fs/sync.c 2014-08-21 10:30:47.000000000 +0100
@@ -65,7 +65,7 @@ int sync_filesystem(struct super_block *
return ret;
return __sync_filesystem(sb, 1);
}
-EXPORT_SYMBOL_GPL(sync_filesystem);
+EXPORT_SYMBOL(sync_filesystem);
static void sync_inodes_one_sb(struct super_block *sb, void *arg)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules.
2014-08-21 10:09 [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules Anton Altaparmakov
@ 2014-09-04 22:01 ` Anton Altaparmakov
0 siblings, 0 replies; 2+ messages in thread
From: Anton Altaparmakov @ 2014-09-04 22:01 UTC (permalink / raw)
To: Linus Torvalds
Cc: Theodore Ts'o, Al Viro, Christoph Hellwig, Andrew Morton,
linux-kernel, linux-fsdevel
Hi Linus,
No-one has objected to the below patch I sent you over two weeks ago.
Would you please apply it?
If you would like it to go through for example Al or Andrew please let me know...
Thanks a lot in advance!
Best regards,
Anton
On 21 Aug 2014, at 11:09, Anton Altaparmakov <aia21@cam.ac.uk> wrote:
> This patch changes sync_filesystem() to be EXPORT_SYMBOL().
>
> The reason this is needed is that starting with 3.15 kernel, due to
> Theodore Ts'o's commit 02b9984d640873b7b3809e63f81a0d7e13496886, "fs: push
> sync_filesystem() down to the file system's remount_fs()", all file
> systems that have dirty data to be written out need to call
> sync_filesystem() from their ->remount_fs() method when remounting
> read-only.
>
> As this is now a generically required function rather than an internal
> only function it should be EXPORT_SYMBOL() so that all file systems can
> call it.
>
> Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
> ---
>
> Hi Linus,
>
> Can you please apply this patch for inclusion into 3.17? Explanation is
> above.
>
> Thanks a lot in advance!
>
> PS. I hope Pine does not mess up the whitespace of the patch!
>
> Best regards,
>
> Anton
> --
> Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
> University of Cambridge Information Services, Roger Needham Building
> 7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
>
> --- linux/fs/sync.c 2014-08-21 10:30:26.000000000 +0100
> +++ linux/fs/sync.c 2014-08-21 10:30:47.000000000 +0100
> @@ -65,7 +65,7 @@ int sync_filesystem(struct super_block *
> return ret;
> return __sync_filesystem(sb, 1);
> }
> -EXPORT_SYMBOL_GPL(sync_filesystem);
> +EXPORT_SYMBOL(sync_filesystem);
>
> static void sync_inodes_one_sb(struct super_block *sb, void *arg)
> {
--
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
University of Cambridge Information Services, Roger Needham Building
7 JJ Thomson Avenue, Cambridge, CB3 0RB, UK
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-04 22:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-21 10:09 [PATCH] Now that sync_filesystem() must be called from ->remount_fs() it needs to be EXPORT_SYMBOL() for kernel modules Anton Altaparmakov
2014-09-04 22:01 ` Anton Altaparmakov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.