* [PATCH] block/amiflop: Don't log an error message for an invalid ioctl
@ 2018-04-12 1:23 Finn Thain
0 siblings, 0 replies; 5+ messages in thread
From: Finn Thain @ 2018-04-12 1:23 UTC (permalink / raw)
To: Jens Axboe; +Cc: Geert Uytterhoeven, linux-m68k, linux-block, linux-kernel
Do as the swim3 driver does and just return -ENOTTY.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/block/amiflop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 3aaf6af3ec23..b9fb794c1255 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1533,9 +1533,7 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode,
return p->type->read_size;
#endif
default:
- printk(KERN_DEBUG "fd_ioctl: unknown cmd %d for drive %d.",
- cmd, drive);
- return -ENOSYS;
+ return -ENOTTY;
}
return 0;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] block/amiflop: Don't log an error message for an invalid ioctl
[not found] <5aceb51e.1c69fb81.c6613.d3e4SMTPIN_ADDED_MISSING@mx.google.com>
@ 2018-04-12 8:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-04-12 8:18 UTC (permalink / raw)
To: Finn Thain; +Cc: Jens Axboe, linux-m68k, linux-block, Linux Kernel Mailing List
On Thu, Apr 12, 2018 at 3:23 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> Do as the swim3 driver does and just return -ENOTTY.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] block/amiflop: Don't log an error message for an invalid ioctl
@ 2018-04-12 8:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-04-12 8:18 UTC (permalink / raw)
To: Finn Thain; +Cc: Jens Axboe, linux-m68k, linux-block, Linux Kernel Mailing List
On Thu, Apr 12, 2018 at 3:23 AM, Finn Thain <fthain@telegraphics.com.au> wrote:
> Do as the swim3 driver does and just return -ENOTTY.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: linux-m68k@lists.linux-m68k.org
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] block/amiflop: Don't log an error message for an invalid ioctl
@ 2018-04-12 1:23 Finn Thain
0 siblings, 0 replies; 5+ messages in thread
From: Finn Thain @ 2018-04-12 1:23 UTC (permalink / raw)
To: Jens Axboe; +Cc: Geert Uytterhoeven, linux-m68k, linux-block, linux-kernel
Do as the swim3 driver does and just return -ENOTTY.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/block/amiflop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 3aaf6af3ec23..b9fb794c1255 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1533,9 +1533,7 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode,
return p->type->read_size;
#endif
default:
- printk(KERN_DEBUG "fd_ioctl: unknown cmd %d for drive %d.",
- cmd, drive);
- return -ENOSYS;
+ return -ENOTTY;
}
return 0;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] block/amiflop: Don't log an error message for an invalid ioctl
@ 2018-04-12 1:23 Finn Thain
0 siblings, 0 replies; 5+ messages in thread
From: Finn Thain @ 2018-04-12 1:23 UTC (permalink / raw)
To: Jens Axboe; +Cc: Geert Uytterhoeven, linux-m68k, linux-block, linux-kernel
Do as the swim3 driver does and just return -ENOTTY.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/block/amiflop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 3aaf6af3ec23..b9fb794c1255 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1533,9 +1533,7 @@ static int fd_locked_ioctl(struct block_device *bdev, fmode_t mode,
return p->type->read_size;
#endif
default:
- printk(KERN_DEBUG "fd_ioctl: unknown cmd %d for drive %d.",
- cmd, drive);
- return -ENOSYS;
+ return -ENOTTY;
}
return 0;
}
--
2.16.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-12 8:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 1:23 [PATCH] block/amiflop: Don't log an error message for an invalid ioctl Finn Thain
[not found] <5aceb51e.1c69fb81.c6613.d3e4SMTPIN_ADDED_MISSING@mx.google.com>
2018-04-12 8:18 ` Geert Uytterhoeven
2018-04-12 8:18 ` Geert Uytterhoeven
-- strict thread matches above, loose matches on Subject: below --
2018-04-12 1:23 Finn Thain
2018-04-12 1:23 Finn Thain
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.