Re: [PATCH v7 0/4] kvm: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory

From: Ankit Agrawal <ankita@nvidia.com>
To: Oliver Upton <oliver.upton@linux.dev>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	"maz@kernel.org" <maz@kernel.org>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
	"yuzenghui@huawei.com" <yuzenghui@huawei.com>,
	"reinette.chatre@intel.com" <reinette.chatre@intel.com>,
	"surenb@google.com" <surenb@google.com>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"brauner@kernel.org" <brauner@kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
	"kevin.tian@intel.com" <kevin.tian@intel.com>,
	"yi.l.liu@intel.com" <yi.l.liu@intel.com>,
	"ardb@kernel.org" <ardb@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"andreyknvl@gmail.com" <andreyknvl@gmail.com>,
	"wangjinchao@xfusion.com" <wangjinchao@xfusion.com>,
	"gshan@redhat.com" <gshan@redhat.com>,
	"shahuang@redhat.com" <shahuang@redhat.com>,
	"ricarkol@google.com" <ricarkol@google.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"rananta@google.com" <rananta@google.com>,
	"ryan.roberts@arm.com" <ryan.roberts@arm.com>,
	"david@redhat.com" <david@redhat.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"bhe@redhat.com" <bhe@redhat.com>,
	Aniket Agashe <aniketa@nvidia.com>, Neo Jia <cjia@nvidia.com>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	"Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
	Vikram Sethi <vsethi@nvidia.com>,
	Andy Currid <acurrid@nvidia.com>,
	Alistair Popple <apopple@nvidia.com>,
	John Hubbard <jhubbard@nvidia.com>,
	Dan Williams <danw@nvidia.com>,
	"kvmarm@lists.linux.dev" <kvmarm@lists.linux.dev>,
	Matt Ochs <mochs@nvidia.com>, Zhi Wang <zhiw@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v7 0/4] kvm: arm64: allow the VM to select DEVICE_* and NORMAL_NC for IO memory
Date: Tue, 13 Feb 2024 02:29:52 +0000	[thread overview]
Message-ID: <SA1PR12MB7199B4F962B580A484BCAFCEB04F2@SA1PR12MB7199.namprd12.prod.outlook.com> (raw)
In-Reply-To: <Zcp-hIlV-ZEu0Jou@linux.dev>

>>
>> The default device stage 2 mapping was chosen in KVM for ARM64 since
>> it was considered safer (i.e. it would not allow guests to trigger
>> uncontained failures ultimately crashing the machine) but this
>> turned out to be asynchronous (SError) defeating the purpose.
>>
>> For these reasons, relax the KVM stage 2 device memory attributes
>> from DEVICE_nGnRE to Normal-NC.
>
> Hi Ankit,
>
> Thanks for being responsive in respinning the series according to the
> feedback. I think we're pretty close here, but it'd be good to address
> the comment / changelog feedback as well.
>
> Can you respin this once more? Hopefully we can get this stuff soaking
> in -next thereafter.

Hi Oliver, yes I am planning to refresh it in the next few days after
incorporating the comments.