All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9
@ 2020-09-16 18:07 Cooper Chiou
  2020-09-16 19:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (26 more replies)
  0 siblings, 27 replies; 70+ messages in thread
From: Cooper Chiou @ 2020-09-16 18:07 UTC (permalink / raw)
  To: intel-gfx; +Cc: Cooper Chiou, William Tseng, Jani Nikula, Chris Wilson

WaProgramMgsrForCorrectSliceSpecificMmioReads applies for Gen9 to
resolve VP8 hardware encoding system hang up on GT1 sku

Reference: HSD#1508045018

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: William Tseng <william.tseng@intel.com>
Cc: Lee Shawn C <shawn.c.lee@intel.com>
Signed-off-by: Cooper Chiou <cooper.chiou@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 5726cd0a37e0..53ea4359545b 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -935,9 +935,13 @@ hsw_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
 	wa_masked_en(wal, HALF_SLICE_CHICKEN3, HSW_SAMPLE_C_PERFORMANCE);
 }
 
+static void wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal);
+
 static void
 gen9_gt_workarounds_init(struct drm_i915_private *i915, struct i915_wa_list *wal)
 {
+	wa_init_mcr(i915, wal);
+
 	/* WaDisableKillLogic:bxt,skl,kbl */
 	if (!IS_COFFEELAKE(i915) && !IS_COMETLAKE(i915))
 		wa_write_or(wal,
@@ -1040,7 +1044,7 @@ wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
 	unsigned int slice, subslice;
 	u32 l3_en, mcr, mcr_mask;
 
-	GEM_BUG_ON(INTEL_GEN(i915) < 10);
+	GEM_BUG_ON(INTEL_GEN(i915) < 9);
 
 	/*
 	 * WaProgramMgsrForL3BankSpecificMmioReads: cnl,icl
@@ -1049,7 +1053,7 @@ wa_init_mcr(struct drm_i915_private *i915, struct i915_wa_list *wal)
 	 * by default, to make sure we correctly read certain registers
 	 * later on (in the range 0xB100 - 0xB3FF).
 	 *
-	 * WaProgramMgsrForCorrectSliceSpecificMmioReads:cnl,icl
+	 * WaProgramMgsrForCorrectSliceSpecificMmioReads:gen9,cnl,icl
 	 * Before any MMIO read into slice/subslice specific registers, MCR
 	 * packet control register needs to be programmed to point to any
 	 * enabled s/ss pair. Otherwise, incorrect values will be returned.
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 70+ messages in thread

end of thread, other threads:[~2021-11-01 10:49 UTC | newest]

Thread overview: 70+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 18:07 [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2020-09-16 19:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-09-21  9:22 ` [Intel-gfx] [drm/i915] 04ff178484: phoronix-test-suite.supertuxkart.1024x768.Fullscreen.Ultimate.1.GranParadisoIsland.frames_per_second -30.4% regression kernel test robot
2020-09-21  9:22   ` kernel test robot
2021-01-21 14:18   ` Chiou, Cooper
2021-01-21 14:18     ` Chiou, Cooper
2021-01-21 14:18     ` [Intel-gfx] " Chiou, Cooper
2021-01-22  3:35     ` Xing, Zhengjun
2021-02-08  0:45     ` [Intel-gfx] " kernel test robot
2021-02-08  0:45       ` kernel test robot
2021-02-08  0:45       ` kernel test robot
2021-02-17  6:56       ` Chiou, Cooper
2021-02-17  6:56         ` Chiou, Cooper
2021-02-17  6:56         ` Chiou, Cooper
2021-02-09  6:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev2) Patchwork
2021-02-09  7:12 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-02-09 11:37   ` Chiou, Cooper
2021-02-17 10:24     ` Tvrtko Ursulin
2021-03-04 18:37       ` Chiou, Cooper
2021-03-04 20:10         ` Matt Roper
2021-02-17  9:31 ` [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Chiou, Cooper
2021-02-17  9:59 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev3) Patchwork
2021-03-02  3:55 ` [Intel-gfx] [PATCH] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-02  5:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev4) Patchwork
2021-03-02  6:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-02  6:23 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-02  6:27 ` [Intel-gfx] [PATCH v3] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-02  7:17   ` Chiou, Cooper
2021-03-04  9:12   ` Tvrtko Ursulin
2021-03-04  9:19     ` Chris Wilson
2021-03-04 11:56       ` Chris Wilson
2021-03-05  0:53         ` Chris Wilson
2021-03-05  9:23           ` Tvrtko Ursulin
2021-03-05 12:20             ` Chris Wilson
2021-03-05 15:23               ` Chris Wilson
2021-03-05 15:24               ` Chiou, Cooper
2021-03-05 16:01                 ` Tvrtko Ursulin
2021-03-06  7:16                   ` Chiou, Cooper
2021-03-08 17:32                   ` Chiou, Cooper
2021-03-10 10:19                     ` Tvrtko Ursulin
2021-03-10 10:54                       ` Chris Wilson
2021-03-11  2:36                         ` Chiou, Cooper
2021-03-11  1:27                       ` Chiou, Cooper
2021-03-11 10:12                         ` Tvrtko Ursulin
2021-03-11 10:47                           ` Chiou, Cooper
2021-03-02  7:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev5) Patchwork
2021-03-02  7:28 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-03 18:09 ` [Intel-gfx] [PATCH v4] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-03 19:54 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev6) Patchwork
2021-03-05 12:58 ` [Intel-gfx] [PATCH v5] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-03-06  7:19   ` Chiou, Cooper
2021-03-10  3:09     ` Chiou, Cooper
2021-03-11 10:45   ` Tvrtko Ursulin
2021-03-11 11:11     ` Joonas Lahtinen
2021-03-23 16:30       ` Rodrigo Vivi
2021-03-05 14:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev7) Patchwork
2021-03-05 17:57 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-21 18:05 ` [Intel-gfx] [PATCH v6] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-10-21 22:15 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev8) Patchwork
2021-10-22  4:14 ` [Intel-gfx] [PATCH v7] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-10-22 13:23   ` Tvrtko Ursulin
2021-10-22  5:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev9) Patchwork
2021-10-22  9:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-10-25  4:26 ` [Intel-gfx] [PATCH v8] drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 Cooper Chiou
2021-11-01 10:15   ` Tvrtko Ursulin
2021-11-01 10:40     ` Joonas Lahtinen
2021-11-01 10:49       ` Tvrtko Ursulin
2021-10-25  5:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev10) Patchwork
2021-10-25  9:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enable WaProgramMgsrForCorrectSliceSpecificMmioReads for Gen9 (rev11) Patchwork
2021-10-25 12:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.