* [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
@ 2023-06-08 9:29 Duke Xin(辛安文)
2023-06-08 16:05 ` Manivannan Sadhasivam
2023-06-09 15:38 ` Manivannan Sadhasivam
0 siblings, 2 replies; 10+ messages in thread
From: Duke Xin(辛安文) @ 2023-06-08 9:29 UTC (permalink / raw)
To: mani, loic.poulain, slark_xiao
Cc: fabio.porcedda, koen.vandeputte, song.fc, bhelgaas, mhi,
linux-arm-msm, jerry.meng, duke.xin,
Duke Xin(辛安文)
The product's would use the same config as previous EM160R-GL
Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
Changelog
v3 -> v4
* Update commit message to include the changelog and reviewd tag.
v2 -> v3
* Add patch CC to mhi@lists.linux.dev.
v1 -> v2
* Remove Space before */ and "for laptop" description.
---
drivers/bus/mhi/host/pci_generic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 70e37c490150..5f204b819e95 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
+ /* EM160R-GL (sdx24) */
+ { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
+ .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
.driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
/* T99W175 (sdx55), Both for eSIM and Non-eSIM */
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-08 9:29 [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product Duke Xin(辛安文)
@ 2023-06-08 16:05 ` Manivannan Sadhasivam
2023-06-09 1:21 ` 回复: " Duke Xin(辛安文)
2023-06-09 15:38 ` Manivannan Sadhasivam
1 sibling, 1 reply; 10+ messages in thread
From: Manivannan Sadhasivam @ 2023-06-08 16:05 UTC (permalink / raw)
To: Duke Xin(辛安文)
Cc: loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm, jerry.meng, duke.xin
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
EM160R-GL is exactly the same name as the old modem with same chipset. What is
the difference between these two?
- Mani
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-08 16:05 ` Manivannan Sadhasivam
@ 2023-06-09 1:21 ` Duke Xin(辛安文)
2023-06-09 15:32 ` Manivannan Sadhasivam
0 siblings, 1 reply; 10+ messages in thread
From: Duke Xin(辛安文) @ 2023-06-09 1:21 UTC (permalink / raw)
To: Manivannan Sadhasivam, Duke Xin(辛安文)
Cc: loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm,
Jerry Meng(蒙杰)
Hi Mani
EM160R-GL is exactly the same name as the old modem with same chipset. What is the difference between these two?
>> From my point of view, there are only two EM160R-GL products with different PCIe ids, and the HW and SW of the module are the same.
The new EM160R-GL product is designed to fit the customer's new laptop.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@kernel.org>
发送时间: 2023年6月9日 0:06
收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
EM160R-GL is exactly the same name as the old modem with same chipset. What is the difference between these two?
- Mani
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-09 1:21 ` 回复: " Duke Xin(辛安文)
@ 2023-06-09 15:32 ` Manivannan Sadhasivam
0 siblings, 0 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2023-06-09 15:32 UTC (permalink / raw)
To: Duke Xin(辛安文)
Cc: Duke Xin(辛安文),
loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm,
Jerry Meng(蒙杰)
On Fri, Jun 09, 2023 at 01:21:02AM +0000, Duke Xin(辛安文) wrote:
> Hi Mani
>
> EM160R-GL is exactly the same name as the old modem with same chipset. What is the difference between these two?
> >> From my point of view, there are only two EM160R-GL products with different PCIe ids, and the HW and SW of the module are the same.
> The new EM160R-GL product is designed to fit the customer's new laptop.
Ok. Previously I used to see same modules having two different IDs because they
share different baseline (from qcom). I will amend the commit message
accordingly.
For future patches, please include these info in the commit message.
- Mani
>
>
> 辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
>
> Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
> Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
>
> Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
> 安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
> HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
> 总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
>
> -----邮件原件-----
> 发件人: Manivannan Sadhasivam <mani@kernel.org>
> 发送时间: 2023年6月9日 0:06
> 收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
> 抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
> 主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
>
> On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> > The product's would use the same config as previous EM160R-GL
> >
> > Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> > ---
> > Changelog
> >
> > v3 -> v4
> >
> > * Update commit message to include the changelog and reviewd tag.
> >
> > v2 -> v3
> >
> > * Add patch CC to mhi@lists.linux.dev.
> >
> > v1 -> v2
> >
> > * Remove Space before */ and "for laptop" description.
> > ---
> > drivers/bus/mhi/host/pci_generic.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c
> > b/drivers/bus/mhi/host/pci_generic.c
> > index 70e37c490150..5f204b819e95 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > + /* EM160R-GL (sdx24) */
> > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> > + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
>
> EM160R-GL is exactly the same name as the old modem with same chipset. What is the difference between these two?
>
> - Mani
>
> > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> > --
> > 2.25.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-08 9:29 [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product Duke Xin(辛安文)
2023-06-08 16:05 ` Manivannan Sadhasivam
@ 2023-06-09 15:38 ` Manivannan Sadhasivam
2023-06-12 2:02 ` 回复: " Duke Xin(辛安文)
1 sibling, 1 reply; 10+ messages in thread
From: Manivannan Sadhasivam @ 2023-06-09 15:38 UTC (permalink / raw)
To: Duke Xin(辛安文)
Cc: loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm, jerry.meng, duke.xin
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
Modified the commit message and subject to reflect the usecase and applied to
mhi-next!
- Mani
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-09 15:38 ` Manivannan Sadhasivam
@ 2023-06-12 2:02 ` Duke Xin(辛安文)
2023-06-21 10:36 ` Duke Xin(辛安文)
0 siblings, 1 reply; 10+ messages in thread
From: Duke Xin(辛安文) @ 2023-06-12 2:02 UTC (permalink / raw)
To: Manivannan Sadhasivam, Duke Xin(辛安文)
Cc: loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm,
Jerry Meng(蒙杰)
Hi Mani
Ok. Previously I used to see same modules having two different IDs because they share different baseline (from qcom). I will amend the commit message accordingly.
For future patches, please include these info in the commit message.
>> Got it. In the future patch, I will add the corresponding supplementary information (such as baseline) to make a difference.
Thank you very much for your patient review again.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@kernel.org>
发送时间: 2023年6月9日 23:38
收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
Modified the commit message and subject to reflect the usecase and applied to mhi-next!
- Mani
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-12 2:02 ` 回复: " Duke Xin(辛安文)
@ 2023-06-21 10:36 ` Duke Xin(辛安文)
2023-06-24 6:57 ` Manivannan Sadhasivam
0 siblings, 1 reply; 10+ messages in thread
From: Duke Xin(辛安文) @ 2023-06-21 10:36 UTC (permalink / raw)
To: Manivannan Sadhasivam, Duke Xin(辛安文)
Cc: loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm,
Jerry Meng(蒙杰)
Hi Mani
Regarding [PATCH v4] submission for review, I would like to confirm with you whether there are any defects that need to be corrected?
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Duke Xin(辛安文)
发送时间: 2023年6月12日 10:02
收件人: Manivannan Sadhasivam <mani@kernel.org>; Duke Xin(辛安文) <duke_xinanwen@163.com>
抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@QUECTEL.COM>
主题: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
Hi Mani
Ok. Previously I used to see same modules having two different IDs because they share different baseline (from qcom). I will amend the commit message accordingly.
For future patches, please include these info in the commit message.
>> Got it. In the future patch, I will add the corresponding supplementary information (such as baseline) to make a difference.
Thank you very much for your patient review again.
辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
-----邮件原件-----
发件人: Manivannan Sadhasivam <mani@kernel.org>
发送时间: 2023年6月9日 23:38
收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> The product's would use the same config as previous EM160R-GL
>
> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
Modified the commit message and subject to reflect the usecase and applied to mhi-next!
- Mani
> Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> ---
> Changelog
>
> v3 -> v4
>
> * Update commit message to include the changelog and reviewd tag.
>
> v2 -> v3
>
> * Add patch CC to mhi@lists.linux.dev.
>
> v1 -> v2
>
> * Remove Space before */ and "for laptop" description.
> ---
> drivers/bus/mhi/host/pci_generic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c
> b/drivers/bus/mhi/host/pci_generic.c
> index 70e37c490150..5f204b819e95 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> + /* EM160R-GL (sdx24) */
> + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
2023-06-21 10:36 ` Duke Xin(辛安文)
@ 2023-06-24 6:57 ` Manivannan Sadhasivam
0 siblings, 0 replies; 10+ messages in thread
From: Manivannan Sadhasivam @ 2023-06-24 6:57 UTC (permalink / raw)
To: Duke Xin(辛安文)
Cc: Duke Xin(辛安文),
loic.poulain, slark_xiao, fabio.porcedda, koen.vandeputte,
song.fc, bhelgaas, mhi, linux-arm-msm,
Jerry Meng(蒙杰)
On Wed, Jun 21, 2023 at 10:36:36AM +0000, Duke Xin(辛安文) wrote:
> Hi Mani
>
> Regarding [PATCH v4] submission for review, I would like to confirm with you whether there are any defects that need to be corrected?
>
Patch has been applied to mhi-next branch and will be part of v6.5 release:
https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/commit/?h=mhi-next&id=6bb6aba2f57ab58a8853bf09cc4e875a46646c0b
- Mani
>
> 辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
>
> Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
> Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
>
> Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
> 安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
> HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
> 总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
>
> -----邮件原件-----
> 发件人: Duke Xin(辛安文)
> 发送时间: 2023年6月12日 10:02
> 收件人: Manivannan Sadhasivam <mani@kernel.org>; Duke Xin(辛安文) <duke_xinanwen@163.com>
> 抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@QUECTEL.COM>
> 主题: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
>
> Hi Mani
>
> Ok. Previously I used to see same modules having two different IDs because they share different baseline (from qcom). I will amend the commit message accordingly.
> For future patches, please include these info in the commit message.
> >> Got it. In the future patch, I will add the corresponding supplementary information (such as baseline) to make a difference.
>
> Thank you very much for your patient review again.
>
> 辛安文 Duke Xin | Software Department IX Engineer | Quectel Wireless Solutions Co., Ltd.
>
> Mobile: +86-15375456183 | Email : Duke.xin@quectel.com | Tel: +86-0551-65869386-8632
> Website: www.quectel.com | QQ: 602659072 | Wechat: 15375456183
>
> Building 1-C, China Speech Valley Area A, 3335 Xiyou Road, High-tech Zone, Hefei, Anhui 230088, China
> 安徽省合肥市高新区习友路3335号中国（合肥）国际智能语音产业园A区1号中试楼 230088
> HQ: Building 5, Shanghai Business Park Phase III (Area B), No.1016 Tianlin Road, Minhang District, Shanghai 200233, China
> 总部：上海市闵行区田林路1016号科技绿洲3期（B区）5号楼 200233
>
> -----邮件原件-----
> 发件人: Manivannan Sadhasivam <mani@kernel.org>
> 发送时间: 2023年6月9日 23:38
> 收件人: Duke Xin(辛安文) <duke_xinanwen@163.com>
> 抄送: loic.poulain@linaro.org; slark_xiao@163.com; fabio.porcedda@gmail.com; koen.vandeputte@citymesh.com; song.fc@gmail.com; bhelgaas@google.com; mhi@lists.linux.dev; linux-arm-msm@vger.kernel.org; Jerry Meng(蒙杰) <jerry.meng@quectel.com>; Duke Xin(辛安文) <duke.xin@quectel.com>
> 主题: Re: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
>
> On Thu, Jun 08, 2023 at 02:29:27AM -0700, Duke Xin(辛安文) wrote:
> > The product's would use the same config as previous EM160R-GL
> >
> > Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
>
> Modified the commit message and subject to reflect the usecase and applied to mhi-next!
>
> - Mani
>
> > Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
> > ---
> > Changelog
> >
> > v3 -> v4
> >
> > * Update commit message to include the changelog and reviewd tag.
> >
> > v2 -> v3
> >
> > * Add patch CC to mhi@lists.linux.dev.
> >
> > v1 -> v2
> >
> > * Remove Space before */ and "for laptop" description.
> > ---
> > drivers/bus/mhi/host/pci_generic.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/bus/mhi/host/pci_generic.c
> > b/drivers/bus/mhi/host/pci_generic.c
> > index 70e37c490150..5f204b819e95 100644
> > --- a/drivers/bus/mhi/host/pci_generic.c
> > +++ b/drivers/bus/mhi/host/pci_generic.c
> > @@ -591,6 +591,9 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x1002), /* EM160R-GL (sdx24) */
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > + /* EM160R-GL (sdx24) */
> > + { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x100d),
> > + .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > { PCI_DEVICE(PCI_VENDOR_ID_QUECTEL, 0x2001), /* EM120R-GL for FCCL (sdx24) */
> > .driver_data = (kernel_ulong_t) &mhi_quectel_em1xx_info },
> > /* T99W175 (sdx55), Both for eSIM and Non-eSIM */
> > --
> > 2.25.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
@ 2023-06-09 14:43 Abdurrahman Eksi
0 siblings, 0 replies; 10+ messages in thread
From: Abdurrahman Eksi @ 2023-06-09 14:43 UTC (permalink / raw)
To: duke.xin
Cc: bhelgaas, duke_xinanwen, fabio.porcedda, jerry.meng,
koen.vandeputte, linux-arm-msm, loic.poulain, mani, mhi,
slark_xiao, song.fc
X
iPhone’umdan gönderildi
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: 回复: [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product
@ 2023-06-09 14:42 Abdurrahman Eksi
0 siblings, 0 replies; 10+ messages in thread
From: Abdurrahman Eksi @ 2023-06-09 14:42 UTC (permalink / raw)
To: duke.xin
Cc: bhelgaas, duke_xinanwen, fabio.porcedda, jerry.meng,
koen.vandeputte, linux-arm-msm, loic.poulain, mani, mhi,
slark_xiao, song.fc
X
iPhone’umdan gönderildi
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-06-24 6:57 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 9:29 [PATCH v4] bus: mhi: host: pci_generic: Add support for quectel's new EM160R-GL product Duke Xin(辛安文)
2023-06-08 16:05 ` Manivannan Sadhasivam
2023-06-09 1:21 ` 回复: " Duke Xin(辛安文)
2023-06-09 15:32 ` Manivannan Sadhasivam
2023-06-09 15:38 ` Manivannan Sadhasivam
2023-06-12 2:02 ` 回复: " Duke Xin(辛安文)
2023-06-21 10:36 ` Duke Xin(辛安文)
2023-06-24 6:57 ` Manivannan Sadhasivam
2023-06-09 14:42 Abdurrahman Eksi
2023-06-09 14:43 Abdurrahman Eksi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.