All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode
@ 2017-11-13 20:41 ` Chris Brandt
  2017-11-27  7:38   ` Jaehoon Chung
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Brandt @ 2017-11-13 20:41 UTC (permalink / raw)
  To: u-boot

Since RZ/A1 (R7S72100) does not support HS mode, remove it from the
host caps.

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 drivers/mmc/sh_mmcif.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c
index 1ff59f06d5..4b62795044 100644
--- a/drivers/mmc/sh_mmcif.c
+++ b/drivers/mmc/sh_mmcif.c
@@ -576,8 +576,12 @@ static const struct mmc_ops sh_mmcif_ops = {
 static struct mmc_config sh_mmcif_cfg = {
 	.name		= DRIVER_NAME,
 	.ops		= &sh_mmcif_ops,
+#if defined(CONFIG_R7S72100)
+	.host_caps	= MMC_MODE_4BIT | MMC_MODE_8BIT,
+#else
 	.host_caps	= MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT |
 			  MMC_MODE_8BIT,
+#endif
 	.voltages	= MMC_VDD_32_33 | MMC_VDD_33_34,
 	.b_max		= CONFIG_SYS_MMC_MAX_BLK_COUNT,
 };
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode
  2017-11-13 20:41 ` [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode Chris Brandt
@ 2017-11-27  7:38   ` Jaehoon Chung
  2017-11-27 12:02     ` Chris Brandt
  0 siblings, 1 reply; 3+ messages in thread
From: Jaehoon Chung @ 2017-11-27  7:38 UTC (permalink / raw)
  To: u-boot

On 11/14/2017 05:41 AM, Chris Brandt wrote:
> Since RZ/A1 (R7S72100) does not support HS mode, remove it from the
> host caps.

Doesn't HS mode? Then it's only supported the legacy mode?

> 
> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
> ---
>  drivers/mmc/sh_mmcif.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/mmc/sh_mmcif.c b/drivers/mmc/sh_mmcif.c
> index 1ff59f06d5..4b62795044 100644
> --- a/drivers/mmc/sh_mmcif.c
> +++ b/drivers/mmc/sh_mmcif.c
> @@ -576,8 +576,12 @@ static const struct mmc_ops sh_mmcif_ops = {
>  static struct mmc_config sh_mmcif_cfg = {
>  	.name		= DRIVER_NAME,
>  	.ops		= &sh_mmcif_ops,
> +#if defined(CONFIG_R7S72100)
> +	.host_caps	= MMC_MODE_4BIT | MMC_MODE_8BIT,
> +#else
>  	.host_caps	= MMC_MODE_HS | MMC_MODE_HS_52MHz | MMC_MODE_4BIT |
>  			  MMC_MODE_8BIT,
> +#endif
>  	.voltages	= MMC_VDD_32_33 | MMC_VDD_33_34,
>  	.b_max		= CONFIG_SYS_MMC_MAX_BLK_COUNT,
>  };
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode
  2017-11-27  7:38   ` Jaehoon Chung
@ 2017-11-27 12:02     ` Chris Brandt
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Brandt @ 2017-11-27 12:02 UTC (permalink / raw)
  To: u-boot

On Monday, November 27, 2017, Jaehoon Chung wrote:
> On 11/14/2017 05:41 AM, Chris Brandt wrote:
> > Since RZ/A1 (R7S72100) does not support HS mode, remove it from the
> > host caps.
> 
> Doesn't HS mode? Then it's only supported the legacy mode?

Sorry, please ignore this patch.

The MMC controller in the RZ/A1 can generate up to a 33MHz clock, so it 
does support "High Speed" mode.

I just tested it and it works fine the way it is.


Chris

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-11-27 12:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20171113204159epcas4p3ecf41db6daadd7895606645f2b40bff9@epcas4p3.samsung.com>
2017-11-13 20:41 ` [U-Boot] [PATCH] mmc: sh_mmcif: RZ/A1 does not support HS mode Chris Brandt
2017-11-27  7:38   ` Jaehoon Chung
2017-11-27 12:02     ` Chris Brandt

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.