All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drivers:net:ethernet:remove repeating expression
@ 2023-06-14 13:13 Wang Ming
  2023-06-14 13:49 ` Pavan Chebbi
  0 siblings, 1 reply; 3+ messages in thread
From: Wang Ming @ 2023-06-14 13:13 UTC (permalink / raw)
  To: Jiawen Wu, Mengyuan Lou, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Wang Ming, Stephen Rothwell, netdev,
	linux-kernel
  Cc: opensource.kernel

Identify issues that arise by using the tests/doublebitand.cocci
semantic patch.Need to remove duplicate expression in statement.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
index 39a9aeee7..6321178fc 100644
--- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
+++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
@@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
        psrtype = WX_RDB_PL_CFG_L4HDR |
                  WX_RDB_PL_CFG_L3HDR |
                  WX_RDB_PL_CFG_L2HDR |
-                 WX_RDB_PL_CFG_TUN_TUNHDR |
                  WX_RDB_PL_CFG_TUN_TUNHDR;
        wr32(wx, WX_RDB_PL_CFG(0), psrtype);

--
2.25.1


________________________________
本邮件及其附件内容可能含有机密和/或隐私信息,仅供指定个人或机构使用。若您非发件人指定收件人或其代理人,请勿使用、传播、复制或存储此邮件之任何内容或其附件。如您误收本邮件,请即以回复或电话方式通知发件人,并将原始邮件、附件及其所有复本删除。谢谢。
The contents of this message and any attachments may contain confidential and/or privileged information and are intended exclusively for the addressee(s). If you are not the intended recipient of this message or their agent, please note that any use, dissemination, copying, or storage of this message or its attachments is not allowed. If you receive this message in error, please notify the sender by reply the message or phone and delete this message, any attachments and any copies immediately.
Thank you

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] drivers:net:ethernet:remove repeating expression
  2023-06-14 13:13 [PATCH v1] drivers:net:ethernet:remove repeating expression Wang Ming
@ 2023-06-14 13:49 ` Pavan Chebbi
  2023-06-15  2:18   ` 回复: " 王明-软件底层技术部
  0 siblings, 1 reply; 3+ messages in thread
From: Pavan Chebbi @ 2023-06-14 13:49 UTC (permalink / raw)
  To: Wang Ming
  Cc: Jiawen Wu, Mengyuan Lou, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Stephen Rothwell, netdev,
	linux-kernel, opensource.kernel

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

On Wed, Jun 14, 2023 at 6:45 PM Wang Ming <machel@vivo.com> wrote:
>
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch.Need to remove duplicate expression in statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---

Please fix the patch format (subject) so that patch goes through
CI/sanity checks.
https://www.kernel.org/doc/html/v5.7/process/submitting-patches.html

>  drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
>  1 file changed, 1 deletion(-)
>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* 回复: [PATCH v1] drivers:net:ethernet:remove repeating expression
  2023-06-14 13:49 ` Pavan Chebbi
@ 2023-06-15  2:18   ` 王明-软件底层技术部
  0 siblings, 0 replies; 3+ messages in thread
From: 王明-软件底层技术部 @ 2023-06-15  2:18 UTC (permalink / raw)
  To: Pavan Chebbi
  Cc: Jiawen Wu, Mengyuan Lou, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni, Stephen Rothwell, netdev,
	linux-kernel, opensource.kernel

Thanks, I will fix the patch format(subject).

-----邮件原件-----
发件人: Pavan Chebbi <pavan.chebbi@broadcom.com> 
发送时间: 2023年6月14日 21:49
收件人: 王明-软件底层技术部 <machel@vivo.com>
抄送: Jiawen Wu <jiawenwu@trustnetic.com>; Mengyuan Lou <mengyuanlou@net-swift.com>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Stephen Rothwell <sfr@canb.auug.org.au>; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; opensource.kernel <opensource.kernel@vivo.com>
主题: Re: [PATCH v1] drivers:net:ethernet:remove repeating expression

On Wed, Jun 14, 2023 at 6:45 PM Wang Ming <machel@vivo.com> wrote:
>
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch.Need to remove duplicate expression in statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---

Please fix the patch format (subject) so that patch goes through
CI/sanity checks.
https://www.kernel.org/doc/html/v5.7/process/submitting-patches.html

>  drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
>  1 file changed, 1 deletion(-)
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-06-15  2:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-14 13:13 [PATCH v1] drivers:net:ethernet:remove repeating expression Wang Ming
2023-06-14 13:49 ` Pavan Chebbi
2023-06-15  2:18   ` 回复: " 王明-软件底层技术部

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.