* [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
@ 2022-05-01 15:31 Kushagra Verma
2022-05-01 15:39 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Kushagra Verma @ 2022-05-01 15:31 UTC (permalink / raw)
To: balbi, gregkh, linux-usb, linux-kernel
This patch removes a possible unnecessary out of memory message from
core.c
as reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Kushagra Verma <kushagra765@outlook.com>
---
drivers/usb/dwc3/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 25c686a752b0..4ee787de2956 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -844,10 +844,8 @@ static void dwc3_set_incr_burst_type(struct dwc3
*dwc)
return;
vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL);
- if (!vals) {
- dev_err(dev, "Error to get memory\n");
+ if (!vals)
return;
- }
/* Get INCR burst type, and parse it */
ret = device_property_read_u32_array(dev,
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
2022-05-01 15:31 [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message Kushagra Verma
@ 2022-05-01 15:39 ` Greg KH
2022-05-01 16:50 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-05-01 15:39 UTC (permalink / raw)
To: Kushagra Verma; +Cc: balbi, linux-usb, linux-kernel
On Sun, May 01, 2022 at 09:01:36PM +0530, Kushagra Verma wrote:
> This patch removes a possible unnecessary out of memory message from
> core.c
> as reported by checkpatch.pl:
> WARNING: Possible unnecessary 'out of memory' message
>
> Signed-off-by: Kushagra Verma <kushagra765@outlook.com>
> ---
> drivers/usb/dwc3/core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 25c686a752b0..4ee787de2956 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -844,10 +844,8 @@ static void dwc3_set_incr_burst_type(struct dwc3
> *dwc)
> return;
>
> vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL);
> - if (!vals) {
> - dev_err(dev, "Error to get memory\n");
> + if (!vals)
> return;
> - }
>
> /* Get INCR burst type, and parse it */
> ret = device_property_read_u32_array(dev,
> --
> 2.32.0
>
>
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
and can not be applied. Please read the file,
Documentation/email-clients.txt in order to fix this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
2022-05-01 15:39 ` Greg KH
@ 2022-05-01 16:50 ` Joe Perches
2022-05-01 17:09 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2022-05-01 16:50 UTC (permalink / raw)
To: Greg KH, Kushagra Verma; +Cc: balbi, linux-usb, linux-kernel
On Sun, 2022-05-01 at 17:39 +0200, Greg KH wrote:
> On Sun, May 01, 2022 at 09:01:36PM +0530, Kushagra Verma wrote:
> > This patch removes a possible unnecessary out of memory message from
> > core.c
> > as reported by checkpatch.pl:
> > WARNING: Possible unnecessary 'out of memory' message
> This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> a patch that has triggered this response. He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created. Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
> and can not be applied. Please read the file,
> Documentation/email-clients.txt in order to fix this.
Seems like a patch-bot false positive patch-bot to me.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
2022-05-01 16:50 ` Joe Perches
@ 2022-05-01 17:09 ` Greg KH
2022-05-01 17:20 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2022-05-01 17:09 UTC (permalink / raw)
To: Joe Perches; +Cc: Kushagra Verma, balbi, linux-usb, linux-kernel
On Sun, May 01, 2022 at 09:50:45AM -0700, Joe Perches wrote:
> On Sun, 2022-05-01 at 17:39 +0200, Greg KH wrote:
> > On Sun, May 01, 2022 at 09:01:36PM +0530, Kushagra Verma wrote:
> > > This patch removes a possible unnecessary out of memory message from
> > > core.c
> > > as reported by checkpatch.pl:
> > > WARNING: Possible unnecessary 'out of memory' message
>
>
> > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > a patch that has triggered this response. He used to manually respond
> > to these common problems, but in order to save his sanity (he kept
> > writing the same thing over and over, yet to different people), I was
> > created. Hopefully you will not take offence and will fix the problem
> > in your patch and resubmit it so that it can be accepted into the Linux
> > kernel tree.
> >
> > You are receiving this message because of the following common error(s)
> > as indicated below:
> >
> > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
> > and can not be applied. Please read the file,
> > Documentation/email-clients.txt in order to fix this.
>
> Seems like a patch-bot false positive patch-bot to me.
>
Try to apply the patch, it is line-wrapped.
It's a good bot :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
2022-05-01 17:09 ` Greg KH
@ 2022-05-01 17:20 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2022-05-01 17:20 UTC (permalink / raw)
To: Greg KH; +Cc: Kushagra Verma, balbi, linux-usb, linux-kernel
On Sun, 2022-05-01 at 19:09 +0200, Greg KH wrote:
> On Sun, May 01, 2022 at 09:50:45AM -0700, Joe Perches wrote:
> > On Sun, 2022-05-01 at 17:39 +0200, Greg KH wrote:
> > > On Sun, May 01, 2022 at 09:01:36PM +0530, Kushagra Verma wrote:
> > > > This patch removes a possible unnecessary out of memory message from
> > > > core.c
> > > > as reported by checkpatch.pl:
> > > > WARNING: Possible unnecessary 'out of memory' message
> >
> >
> > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
> > > a patch that has triggered this response. He used to manually respond
> > > to these common problems, but in order to save his sanity (he kept
> > > writing the same thing over and over, yet to different people), I was
> > > created. Hopefully you will not take offence and will fix the problem
> > > in your patch and resubmit it so that it can be accepted into the Linux
> > > kernel tree.
> > >
> > > You are receiving this message because of the following common error(s)
> > > as indicated below:
> > >
> > > - Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
> > > and can not be applied. Please read the file,
> > > Documentation/email-clients.txt in order to fix this.
> >
> > Seems like a patch-bot false positive patch-bot to me.
> >
>
> Try to apply the patch, it is line-wrapped.
>
> It's a good bot :)
Right, I was just looking at the patch but it's the patch header
that's wrapped.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message
@ 2022-05-02 9:07 Kushagra Verma
0 siblings, 0 replies; 6+ messages in thread
From: Kushagra Verma @ 2022-05-02 9:07 UTC (permalink / raw)
To: balbi, gregkh, linux-usb, linux-kernel
This patch removes a possible unnecessary out of memory message from
core.c as reported by checkpatch.pl:
WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Kushagra Verma <kushagra765@outlook.com>
---
drivers/usb/dwc3/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 25c686a752b0..4ee787de2956 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -844,10 +844,8 @@ static void dwc3_set_incr_burst_type(struct dwc3 *dwc)
return;
vals = kcalloc(ntype, sizeof(u32), GFP_KERNEL);
- if (!vals) {
- dev_err(dev, "Error to get memory\n");
+ if (!vals)
return;
- }
/* Get INCR burst type, and parse it */
ret = device_property_read_u32_array(dev,
--
2.32.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-02 9:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-01 15:31 [PATCH] USB / dwc3: remove a possible unnecessary 'out of memory' message Kushagra Verma
2022-05-01 15:39 ` Greg KH
2022-05-01 16:50 ` Joe Perches
2022-05-01 17:09 ` Greg KH
2022-05-01 17:20 ` Joe Perches
2022-05-02 9:07 Kushagra Verma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.