* [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
@ 2021-11-26 6:54 ` Shaik Sajida Bhanu
0 siblings, 0 replies; 6+ messages in thread
From: Shaik Sajida Bhanu @ 2021-11-26 6:54 UTC (permalink / raw)
To: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel
Cc: stummala, vbadigan, quic_rampraka, quic_pragalla, sartgarg,
Shaik Sajida Bhanu
Add support for winbond W25Q512NW-IM chip.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 96573f6..cdfa2ee 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
@ 2021-11-26 6:54 ` Shaik Sajida Bhanu
0 siblings, 0 replies; 6+ messages in thread
From: Shaik Sajida Bhanu @ 2021-11-26 6:54 UTC (permalink / raw)
To: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel
Cc: stummala, vbadigan, quic_rampraka, quic_pragalla, sartgarg,
Shaik Sajida Bhanu
Add support for winbond W25Q512NW-IM chip.
Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 96573f6..cdfa2ee 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
2021-11-26 6:54 ` Shaik Sajida Bhanu
@ 2021-11-30 21:31 ` Doug Anderson
-1 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2021-11-30 21:31 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, stummala, vbadigan,
quic_rampraka, quic_pragalla, sartgarg
Hi,
On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu
<quic_c_sbhanu@quicinc.com> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..cdfa2ee 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
I have no comments on the contents of this patch, but your spacing is
off. The entry above and below you have a space between the "{" and
the string with the name of the flash part. You should match.
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
@ 2021-11-30 21:31 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2021-11-30 21:31 UTC (permalink / raw)
To: Shaik Sajida Bhanu
Cc: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, stummala, vbadigan,
quic_rampraka, quic_pragalla, sartgarg
Hi,
On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu
<quic_c_sbhanu@quicinc.com> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..cdfa2ee 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
I have no comments on the contents of this patch, but your spacing is
off. The entry above and below you have a space between the "{" and
the string with the name of the flash part. You should match.
-Doug
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
2021-11-30 21:31 ` Doug Anderson
@ 2021-12-01 4:45 ` Sajida Bhanu (Temp) (QUIC)
-1 siblings, 0 replies; 6+ messages in thread
From: Sajida Bhanu (Temp) (QUIC) @ 2021-12-01 4:45 UTC (permalink / raw)
To: Doug Anderson, Sajida Bhanu (Temp) (QUIC)
Cc: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, stummala, vbadigan,
Ram Prakash Gupta (QUIC), Pradeep Pragallapati (QUIC),
sartgarg
Hi Doug,
Sure thanks for the review.
Will address comment and share the patch .
Thanks,
Sajida
-----Original Message-----
From: Doug Anderson <dianders@chromium.org>
Sent: Wednesday, December 1, 2021 3:01 AM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Cc: tudor.ambarus@microchip.com; michael@walle.cc; p.yadav@ti.com; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; stummala@codeaurora.org; vbadigan@codeaurora.org; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; sartgarg@codeaurora.org
Subject: Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..cdfa2ee 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
I have no comments on the contents of this patch, but your spacing is off. The entry above and below you have a space between the "{" and the string with the name of the flash part. You should match.
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
@ 2021-12-01 4:45 ` Sajida Bhanu (Temp) (QUIC)
0 siblings, 0 replies; 6+ messages in thread
From: Sajida Bhanu (Temp) (QUIC) @ 2021-12-01 4:45 UTC (permalink / raw)
To: Doug Anderson, Sajida Bhanu (Temp) (QUIC)
Cc: tudor.ambarus, michael, p.yadav, miquel.raynal, richard,
vigneshr, linux-mtd, linux-kernel, stummala, vbadigan,
Ram Prakash Gupta (QUIC), Pradeep Pragallapati (QUIC),
sartgarg
Hi Doug,
Sure thanks for the review.
Will address comment and share the patch .
Thanks,
Sajida
-----Original Message-----
From: Doug Anderson <dianders@chromium.org>
Sent: Wednesday, December 1, 2021 3:01 AM
To: Sajida Bhanu (Temp) (QUIC) <quic_c_sbhanu@quicinc.com>
Cc: tudor.ambarus@microchip.com; michael@walle.cc; p.yadav@ti.com; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org; stummala@codeaurora.org; vbadigan@codeaurora.org; Ram Prakash Gupta (QUIC) <quic_rampraka@quicinc.com>; Pradeep Pragallapati (QUIC) <quic_pragalla@quicinc.com>; sartgarg@codeaurora.org
Subject: Re: [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
On Thu, Nov 25, 2021 at 10:56 PM Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <quic_c_sbhanu@quicinc.com>
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..cdfa2ee 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + {"w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> { "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_DUAL_READ |
> SPI_NOR_QUAD_READ) },
I have no comments on the contents of this patch, but your spacing is off. The entry above and below you have a space between the "{" and the string with the name of the flash part. You should match.
-Doug
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-01 4:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 6:54 [PATCH V1] mtd: spi-nor: winbond: Add support for winbond chip Shaik Sajida Bhanu
2021-11-26 6:54 ` Shaik Sajida Bhanu
2021-11-30 21:31 ` Doug Anderson
2021-11-30 21:31 ` Doug Anderson
2021-12-01 4:45 ` Sajida Bhanu (Temp) (QUIC)
2021-12-01 4:45 ` Sajida Bhanu (Temp) (QUIC)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.