* [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
@ 2021-07-21 20:29 Ruslan Babayev (fib)
2021-07-21 20:31 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-21 20:29 UTC (permalink / raw)
To: meta-virtualization; +Cc: Bruce Ashfield, Ruslan Babayev
Signed-off-by: Ruslan Babayev <fib@cisco.com>
---
recipes-devtools/python/python3_virtualization.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc
index 55301c7..481db58 100644
--- a/recipes-devtools/python/python3_virtualization.inc
+++ b/recipes-devtools/python/python3_virtualization.inc
@@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
DEPENDS += " ncurses"
-do_compile_prepend() {
+do_compile_prepend_class-target() {
export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
}
--
2.26.2.Cisco
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
2021-07-21 20:29 [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES Ruslan Babayev (fib)
@ 2021-07-21 20:31 ` Bruce Ashfield
2021-07-21 20:37 ` Ruslan Babayev (fib)
[not found] ` <1693E8C660DC5CDD.19034@lists.yoctoproject.org>
0 siblings, 2 replies; 6+ messages in thread
From: Bruce Ashfield @ 2021-07-21 20:31 UTC (permalink / raw)
To: Ruslan Babayev; +Cc: meta-virtualization
You need to elaborate much more in this commit message. We need to
document what exactly were the symptoms, in what sort of build things
weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@cisco.com> wrote:
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_virtualization.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/python/python3_virtualization.inc b/recipes-devtools/python/python3_virtualization.inc
> index 55301c7..481db58 100644
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ b/recipes-devtools/python/python3_virtualization.inc
> @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> DEPENDS += " ncurses"
>
> -do_compile_prepend() {
> +do_compile_prepend_class-target() {
> export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> }
>
> --
> 2.26.2.Cisco
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
2021-07-21 20:31 ` Bruce Ashfield
@ 2021-07-21 20:37 ` Ruslan Babayev (fib)
[not found] ` <1693E8C660DC5CDD.19034@lists.yoctoproject.org>
1 sibling, 0 replies; 6+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-21 20:37 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization
Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Wednesday, July 21, 2021 1:32 PM
To: Ruslan Babayev (fib) <fib@cisco.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@cisco.com> wrote:
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_virtualization.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/python/python3_virtualization.inc
> b/recipes-devtools/python/python3_virtualization.inc
> index 55301c7..481db58 100644
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ b/recipes-devtools/python/python3_virtualization.inc
> @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> DEPENDS += " ncurses"
>
> -do_compile_prepend() {
> +do_compile_prepend_class-target() {
> export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> }
>
> --
> 2.26.2.Cisco
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
[not found] ` <1693E8C660DC5CDD.19034@lists.yoctoproject.org>
@ 2021-07-21 20:49 ` Ruslan Babayev (fib)
2021-07-21 22:34 ` Bruce Ashfield
0 siblings, 1 reply; 6+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-21 20:49 UTC (permalink / raw)
To: Ruslan Babayev (fib), Bruce Ashfield; +Cc: meta-virtualization
Just do add. I am not sure why the prepend with export LIBRARY_PATH was added to begin with. Perhaps it is no longer required.
-----Original Message-----
From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Ruslan Babayev (fib) via lists.yoctoproject.org
Sent: Wednesday, July 21, 2021 1:37 PM
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Wednesday, July 21, 2021 1:32 PM
To: Ruslan Babayev (fib) <fib@cisco.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
Cheers,
Bruce
On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@cisco.com> wrote:
>
> Signed-off-by: Ruslan Babayev <fib@cisco.com>
> ---
> recipes-devtools/python/python3_virtualization.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-devtools/python/python3_virtualization.inc
> b/recipes-devtools/python/python3_virtualization.inc
> index 55301c7..481db58 100644
> --- a/recipes-devtools/python/python3_virtualization.inc
> +++ b/recipes-devtools/python/python3_virtualization.inc
> @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> DEPENDS += " ncurses"
>
> -do_compile_prepend() {
> +do_compile_prepend_class-target() {
> export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> }
>
> --
> 2.26.2.Cisco
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
2021-07-21 20:49 ` Ruslan Babayev (fib)
@ 2021-07-21 22:34 ` Bruce Ashfield
2021-07-21 23:50 ` Ruslan Babayev (fib)
0 siblings, 1 reply; 6+ messages in thread
From: Bruce Ashfield @ 2021-07-21 22:34 UTC (permalink / raw)
To: Ruslan Babayev (fib); +Cc: meta-virtualization
On Wed, Jul 21, 2021 at 4:49 PM Ruslan Babayev (fib) <fib@cisco.com> wrote:
>
> Just do add. I am not sure why the prepend with export LIBRARY_PATH was added to begin with. Perhaps it is no longer required.
It very likely isn't.
The git history shows me wondering that same thing in 2015.
When it was introduced, we needed a patch to make the ncurses DEPENDS
properly cross compile. That patch is gone, so the search path
modification is also probably not required.
If I can ask, what recipe are you building that is showing the error ?
That's really what I want to understand, since we are building many
images on a daily basis with host/target python packages and I've
never seen the issue.
If I can reproduce the breakage here, then I can also confirm that we
can just drop the configure prepend completely.
Bruce
>
> -----Original Message-----
> From: meta-virtualization@lists.yoctoproject.org <meta-virtualization@lists.yoctoproject.org> On Behalf Of Ruslan Babayev (fib) via lists.yoctoproject.org
> Sent: Wednesday, July 21, 2021 1:37 PM
> To: Bruce Ashfield <bruce.ashfield@gmail.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
>
> Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
>
> I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
>
> -----Original Message-----
> From: Bruce Ashfield <bruce.ashfield@gmail.com>
> Sent: Wednesday, July 21, 2021 1:32 PM
> To: Ruslan Babayev (fib) <fib@cisco.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
>
> You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
>
> Cheers,
>
> Bruce
>
> On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@cisco.com> wrote:
> >
> > Signed-off-by: Ruslan Babayev <fib@cisco.com>
> > ---
> > recipes-devtools/python/python3_virtualization.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-devtools/python/python3_virtualization.inc
> > b/recipes-devtools/python/python3_virtualization.inc
> > index 55301c7..481db58 100644
> > --- a/recipes-devtools/python/python3_virtualization.inc
> > +++ b/recipes-devtools/python/python3_virtualization.inc
> > @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > DEPENDS += " ncurses"
> >
> > -do_compile_prepend() {
> > +do_compile_prepend_class-target() {
> > export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> > }
> >
> > --
> > 2.26.2.Cisco
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
2021-07-21 22:34 ` Bruce Ashfield
@ 2021-07-21 23:50 ` Ruslan Babayev (fib)
0 siblings, 0 replies; 6+ messages in thread
From: Ruslan Babayev (fib) @ 2021-07-21 23:50 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: meta-virtualization
In my case it's a custom layer with a recipe that inherits python3native.
To reproduce just build python3-native or anything inheriting python3native thus adding python3-native to DEPENDS.
The key is to add "virtualization" to DISTRO_FEATURES and you'll hit the issue every time.
-----Original Message-----
From: Bruce Ashfield <bruce.ashfield@gmail.com>
Sent: Wednesday, July 21, 2021 3:34 PM
To: Ruslan Babayev (fib) <fib@cisco.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES
On Wed, Jul 21, 2021 at 4:49 PM Ruslan Babayev (fib) <fib@cisco.com> wrote:
>
> Just do add. I am not sure why the prepend with export LIBRARY_PATH was added to begin with. Perhaps it is no longer required.
It very likely isn't.
The git history shows me wondering that same thing in 2015.
When it was introduced, we needed a patch to make the ncurses DEPENDS properly cross compile. That patch is gone, so the search path modification is also probably not required.
If I can ask, what recipe are you building that is showing the error ?
That's really what I want to understand, since we are building many images on a daily basis with host/target python packages and I've never seen the issue.
If I can reproduce the breakage here, then I can also confirm that we can just drop the configure prepend completely.
Bruce
>
> -----Original Message-----
> From: meta-virtualization@lists.yoctoproject.org
> <meta-virtualization@lists.yoctoproject.org> On Behalf Of Ruslan
> Babayev (fib) via lists.yoctoproject.org
> Sent: Wednesday, July 21, 2021 1:37 PM
> To: Bruce Ashfield <bruce.ashfield@gmail.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH] python3: unbreak
> python3-native when virtualization is in DISTRO_FEATURES
>
> Basically, python3-native recipe with DISTRO_FEATURES with virtualization is broken due to ${STAGING_DIR_TARGET} being undefined and LIBRARY_PATH ending up as "/lib".
>
> I can put the part about ${STAGING_DIR_TARGET} not defined for native recipes in the body of the commit if you like.
>
> -----Original Message-----
> From: Bruce Ashfield <bruce.ashfield@gmail.com>
> Sent: Wednesday, July 21, 2021 1:32 PM
> To: Ruslan Babayev (fib) <fib@cisco.com>
> Cc: meta-virtualization@lists.yoctoproject.org
> Subject: Re: [meta-virtualization][PATCH] python3: unbreak
> python3-native when virtualization is in DISTRO_FEATURES
>
> You need to elaborate much more in this commit message. We need to document what exactly were the symptoms, in what sort of build things weren't working, and how this fixes it.
>
> Cheers,
>
> Bruce
>
> On Wed, Jul 21, 2021 at 4:30 PM Ruslan Babayev <fib@cisco.com> wrote:
> >
> > Signed-off-by: Ruslan Babayev <fib@cisco.com>
> > ---
> > recipes-devtools/python/python3_virtualization.inc | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/recipes-devtools/python/python3_virtualization.inc
> > b/recipes-devtools/python/python3_virtualization.inc
> > index 55301c7..481db58 100644
> > --- a/recipes-devtools/python/python3_virtualization.inc
> > +++ b/recipes-devtools/python/python3_virtualization.inc
> > @@ -2,7 +2,7 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > DEPENDS += " ncurses"
> >
> > -do_compile_prepend() {
> > +do_compile_prepend_class-target() {
> > export LIBRARY_PATH=${STAGING_DIR_TARGET}/lib
> > }
> >
> > --
> > 2.26.2.Cisco
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-07-21 23:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 20:29 [meta-virtualization][PATCH] python3: unbreak python3-native when virtualization is in DISTRO_FEATURES Ruslan Babayev (fib)
2021-07-21 20:31 ` Bruce Ashfield
2021-07-21 20:37 ` Ruslan Babayev (fib)
[not found] ` <1693E8C660DC5CDD.19034@lists.yoctoproject.org>
2021-07-21 20:49 ` Ruslan Babayev (fib)
2021-07-21 22:34 ` Bruce Ashfield
2021-07-21 23:50 ` Ruslan Babayev (fib)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.