* [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY type error
@ 2021-05-31 16:55 =?unknown-8bit?q?Micha=C5=82_Ma=C5=82oszewski?=
2021-06-23 20:09 ` Brelinski, TonyX
0 siblings, 1 reply; 2+ messages in thread
From: =?unknown-8bit?q?Micha=C5=82_Ma=C5=82oszewski?= @ 2021-05-31 16:55 UTC (permalink / raw)
To: intel-wired-lan
From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
In case of PHY type error occurs, the message was too generic.
Add additional info to PHY type error indicating that it can be
wrong cable connected.
Fixes: 124ed15bf126 ("i40e: Add dual speed module support")
Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
index 45f5dc2..7a1d2d5 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c
@@ -971,7 +971,7 @@ static void i40e_get_settings_link_up(struct i40e_hw *hw,
default:
/* if we got here and link is up something bad is afoot */
netdev_info(netdev,
- "WARNING: Link is up but PHY type 0x%x is not recognized.\n",
+ "WARNING: Link is up but PHY type 0x%x is not recognized, or incorrect cable is in use\n",
hw_link_info->phy_type);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY type error
2021-05-31 16:55 [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY type error =?unknown-8bit?q?Micha=C5=82_Ma=C5=82oszewski?=
@ 2021-06-23 20:09 ` Brelinski, TonyX
0 siblings, 0 replies; 2+ messages in thread
From: Brelinski, TonyX @ 2021-06-23 20:09 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Michal Maloszewski
> Sent: Monday, May 31, 2021 9:56 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Maloszewski, Michal <michal.maloszewski@intel.com>; Cieplicki, LukaszX
> <lukaszx.cieplicki@intel.com>
> Subject: [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY
> type error
>
> From: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
>
> In case of PHY type error occurs, the message was too generic.
> Add additional info to PHY type error indicating that it can be wrong cable
> connected.
>
> Fixes: 124ed15bf126 ("i40e: Add dual speed module support")
> Signed-off-by: Lukasz Cieplicki <lukaszx.cieplicki@intel.com>
> Signed-off-by: Michal Maloszewski <michal.maloszewski@intel.com>
> ---
> drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> (A Contingent Worker at Intel)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-31 16:55 [Intel-wired-lan] [PATCH net v1] i40e: Add additional info to PHY type error =?unknown-8bit?q?Micha=C5=82_Ma=C5=82oszewski?=
2021-06-23 20:09 ` Brelinski, TonyX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.