Unable to build branch nvme-5.18

Unable to build branch nvme-5.18

[Belanger, Martin]

I tried to build branch nvme-5.18 on Fedora 35, but I get this error:

  LDS     scripts/module.lds
  MODPOST modules-only.symvers
ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-tcp.ko] undefined!
ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-fcloop.ko] undefined!
ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-fc.ko] undefined!
ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-rdma.ko] undefined!
ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-loop.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1746: modules] Error 2

Any thoughts?

Thanks,
Martin

Re: Unable to build branch nvme-5.18

[Chaitanya Kulkarni]

On 3/23/22 12:32, Belanger, Martin wrote:
> I tried to build branch nvme-5.18 on Fedora 35, but I get this error:
> 
>    LDS     scripts/module.lds
>    MODPOST modules-only.symvers
> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-tcp.ko] undefined!
> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-fcloop.ko] undefined!
> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-fc.ko] undefined!
> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-rdma.ko] undefined!
> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-loop.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
> make[1]: *** Deleting file 'modules-only.symvers'
> make: *** [Makefile:1746: modules] Error 2
> 
> Any thoughts?
> 

this should work :-

diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index 8f3762f4450f..7c17a9d79da1 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -18,6 +18,7 @@
  struct workqueue_struct *buffered_io_wq;
  struct workqueue_struct *zbd_wq;
  struct workqueue_struct *nvmet_wq;
+EXPORT_SYMBOL_GPL(nvmet_wq);
  static const struct nvmet_fabrics_ops *nvmet_transports[NVMF_TRTYPE_MAX];
  static DEFINE_IDA(cntlid_ida);



> Thanks,
> Martin
> 

Re: Unable to build branch nvme-5.18

[Sagi Grimberg]

>> I tried to build branch nvme-5.18 on Fedora 35, but I get this error:
>>
>>     LDS     scripts/module.lds
>>     MODPOST modules-only.symvers
>> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-tcp.ko] undefined!
>> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-fcloop.ko] undefined!
>> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-fc.ko] undefined!
>> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvmet-rdma.ko] undefined!
>> ERROR: modpost: "nvmet_wq" [drivers/nvme/target/nvme-loop.ko] undefined!
>> make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
>> make[1]: *** Deleting file 'modules-only.symvers'
>> make: *** [Makefile:1746: modules] Error 2
>>
>> Any thoughts?
>>
> 
> this should work :-
> 
> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
> index 8f3762f4450f..7c17a9d79da1 100644
> --- a/drivers/nvme/target/core.c
> +++ b/drivers/nvme/target/core.c
> @@ -18,6 +18,7 @@
>    struct workqueue_struct *buffered_io_wq;
>    struct workqueue_struct *zbd_wq;
>    struct workqueue_struct *nvmet_wq;
> +EXPORT_SYMBOL_GPL(nvmet_wq);
>    static const struct nvmet_fabrics_ops *nvmet_transports[NVMF_TRTYPE_MAX];
>    static DEFINE_IDA(cntlid_ida);

This fix was already folded in.