RE: [PATCH] qede: fix general protection fault may occur on probe

RE: [PATCH] qede: fix general protection fault may occur on probe

[Amrani, Ram]

> The recent introduction of qedr driver support in qede causes a GPF when
> probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids
> using an uninitialized pointer in such a case. Caught by the kernel test robot.
> 
> ...

Hi Doug,
Note that I've previously sent this patch wrongfully as [PATCH rdma-core].
I guess this made you miss it.
It's an important bug fix that I hope will make it into 4.9.

Thanks,
Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] qede: fix general protection fault may occur on probe

[Amrani, Ram]

> This patch was seriously malformed (spaces instead of tabs, no space
> beginning the line that ends the patch, etc).  I redid it by hand, it's now
> applied.
> 

Hmmm, probably resending it via Outlook and not via git was the cause. Sorry for that. I'll avoid this in the future.
I appreciate this, thank you.

Ram

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] qede: fix general protection fault may occur on probe

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 1463 bytes --]

On 11/23/2016 3:03 AM, Amrani, Ram wrote:
> The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot.
> 
> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
> drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> index 9867f96..4927271 100644
> --- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
> +++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
> @@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
>               }
>               mutex_unlock(&qedr_dev_list_lock);
> 
> -              DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
> -                             qedr_counter);
> +             pr_notice("qedr: discovered and registered %d RoCE funcs\n",
> +                              qedr_counter);
> 
>                return 0;
> }
> --
> 1.8.3.1
> 

This patch was seriously malformed (spaces instead of tabs, no space
beginning the line that ends the patch, etc).  I redid it by hand, it's
now applied.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG Key ID: 0E572FDD


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

[PATCH] qede: fix general protection fault may occur on probe

[Amrani, Ram]

The recent introduction of qedr driver support in qede causes a GPF when probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids using an uninitialized pointer in such a case. Caught by the kernel test robot.

Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
---
drivers/net/ethernet/qlogic/qede/qede_roce.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede_roce.c b/drivers/net/ethernet/qlogic/qede/qede_roce.c
index 9867f96..4927271 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_roce.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_roce.c
@@ -191,8 +191,8 @@ int qede_roce_register_driver(struct qedr_driver *drv)
              }
              mutex_unlock(&qedr_dev_list_lock);

-              DP_INFO(edev, "qedr: discovered and registered %d RoCE funcs\n",
-                             qedr_counter);
+             pr_notice("qedr: discovered and registered %d RoCE funcs\n",
+                              qedr_counter);

               return 0;
}
--
1.8.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] qede: fix general protection fault may occur on probe

[Amrani, Ram]

> The recent introduction of qedr driver support in qede causes a GPF when
> probing the driver in a server without a RoCE enabled QLogic NIC. This fix avoids
> using an uninitialized pointer in such a case. Caught by the kernel test robot.
> 
> ...

This e-mail was wrongly sent as HTML.
I'll resend correctly.

Ram


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html