From: Taylor Simpson <tsimpson@quicinc.com>
To: Peter Maydell <peter.maydell@linaro.org>,
"qemu-arm@nongnu.org" <qemu-arm@nongnu.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Sergio Lopez <slp@redhat.com>
Subject: RE: [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h
Date: Tue, 7 Dec 2021 16:55:36 +0000 [thread overview]
Message-ID: <SN4PR0201MB88084FDFE21708994A1F0BD8DE6E9@SN4PR0201MB8808.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20211129200510.1233037-3-peter.maydell@linaro.org>
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, November 29, 2021 2:05 PM
> To: qemu-arm@nongnu.org; qemu-devel@nongnu.org
> Cc: Paolo Bonzini <pbonzini@redhat.com>; Sergio Lopez <slp@redhat.com>;
> Taylor Simpson <tsimpson@quicinc.com>; Yoshinori Sato
> <ysato@users.sourceforge.jp>; Marcel Apfelbaum
> <marcel.apfelbaum@gmail.com>
> Subject: [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-
> common.h
>
> The qemu-common.h header is not supposed to be included from any other
> header files, only from .c files (as documented in a comment at the start of
> it).
>
> Move the include to linux-user/hexagon/cpu_loop.c, which needs it for the
> declaration of cpu_exec_step_atomic().
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/hexagon/cpu.h | 1 -
> linux-user/hexagon/cpu_loop.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
next prev parent reply other threads:[~2021-12-07 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:05 [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h Peter Maydell
2021-12-07 16:55 ` Taylor Simpson [this message]
2021-11-29 20:05 ` [PATCH for-7.0 3/4] target/rx/cpu.h: Don't " Peter Maydell
2021-12-01 12:26 ` Yoshinori Sato
2021-11-29 20:05 ` [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily Peter Maydell
2021-11-29 20:48 ` [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-30 10:02 ` Markus Armbruster
2021-11-30 8:40 ` Richard Henderson
2021-12-01 13:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0201MB88084FDFE21708994A1F0BD8DE6E9@SN4PR0201MB8808.namprd02.prod.outlook.com \
--to=tsimpson@quicinc.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.