From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Taylor Simpson <tsimpson@quicinc.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Sergio Lopez <slp@redhat.com>
Subject: Re: [PATCH for-7.0 3/4] target/rx/cpu.h: Don't include qemu-common.h
Date: Wed, 01 Dec 2021 21:26:22 +0900 [thread overview]
Message-ID: <87h7bsa4up.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20211129200510.1233037-4-peter.maydell@linaro.org>
On Tue, 30 Nov 2021 05:05:09 +0900,
Peter Maydell wrote:
>
> The qemu-common.h header is not supposed to be included from any
> other header files, only from .c files (as documented in a comment at
> the start of it).
>
> Nothing actually relies on target/rx/cpu.h including it, so we can
> just drop the include.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> target/rx/cpu.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 4ac71aec370..657db84ef0a 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -20,7 +20,6 @@
> #define RX_CPU_H
>
> #include "qemu/bitops.h"
> -#include "qemu-common.h"
> #include "hw/registerfields.h"
> #include "cpu-qom.h"
>
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-12-01 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 20:05 [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 1/4] include/hw/i386: Don't include qemu-common.h in .h files Peter Maydell
2021-11-29 20:05 ` [PATCH for-7.0 2/4] target/hexagon/cpu.h: don't include qemu-common.h Peter Maydell
2021-12-07 16:55 ` Taylor Simpson
2021-11-29 20:05 ` [PATCH for-7.0 3/4] target/rx/cpu.h: Don't " Peter Maydell
2021-12-01 12:26 ` Yoshinori Sato [this message]
2021-11-29 20:05 ` [PATCH for-7.0 4/4] hw/arm: Don't include qemu-common.h unnecessarily Peter Maydell
2021-11-29 20:48 ` [PATCH for-7.0 0/4] qemu-common.h include cleanup Peter Maydell
2021-11-30 10:02 ` Markus Armbruster
2021-11-30 8:40 ` Richard Henderson
2021-12-01 13:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7bsa4up.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.