Re: [OE-core][PATCH] package_manager/ipk: do not pipe stderr to stdout

* Re: [OE-core][PATCH] package_manager/ipk: do not pipe stderr to stdout
@ 2022-06-29 19:22 Shruthi Ravichandran
  2022-06-30  8:46 ` Alexander Kanavin
  0 siblings, 1 reply; 6+ messages in thread
From: Shruthi Ravichandran @ 2022-06-29 19:22 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: openembedded-core

Hi Alex,

I've found that some OE commands print an error during cleanup when
the tmp_dir does not exist and an attempt is made to delete it. I've
submitted a patch to opkg to fix that.
Link: https://git.yoctoproject.org/opkg/commit/?id=8dfdda86afd407a66e3dc00a077bdcc8b53d54ea.
That was the one instance that was causing an issue in our builds.
There may be other instances that I don't know of. Given that, I think
the package_manager code should be resilient against any such
miscellaneous stderr messages, which do not result in the command
itself failing.

Hope that helps,
Shruthi

> -----Original Message-----
> From: Alexander Kanavin <alex.kanavin@gmail.com>
> Sent: Tuesday, June 28, 2022 1:33 PM
> To: Shruthi Ravichandran <shruthi.ravichandran@ni.com>
> Cc: openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH] package_manager/ipk: do not pipe stderr to stdout
>
> This needs additional justification. What are the error messages, why are they harmless and why the solution is to suppress them instead of
> addressing the reasons they appear?
>
> Alex
>
> On Tue 28. Jun 2022 at 23.13, Shruthi Ravichandran <shruthi.ravichandran@ni.com <mailto:shruthi.ravichandran@ni.com> > wrote:
>
>
>       When parsing the output of a command, do not pipe stderr to stdout.
>       Opkg sometimes prints harmless error messages even when the opkg
>       command succeeds. When stderr is piped to stdout, these error
>       messages may clobber the stdout and cause unexpected results while
>       parsing the output.
>
>       Signed-off-by: Shruthi Ravichandran <shruthi.ravichandran@ni.com <mailto:shruthi.ravichandran@ni.com> >
>       ---
>        meta/lib/oe/package_manager/ipk/__init__.py | 2 +-
>        1 file changed, 1 insertion(+), 1 deletion(-)
>
>       diff --git a/meta/lib/oe/package_manager/ipk/__init__.py b/meta/lib/oe/package_manager/ipk/__init__.py
>       index 4cd3963111..d7f3f31853 100644
>       --- a/meta/lib/oe/package_manager/ipk/__init__.py
>       +++ b/meta/lib/oe/package_manager/ipk/__init__.py
>       @@ -103,7 +103,7 @@ class OpkgDpkgPM(PackageManager):
>                """
>
>                try:
>       -            output = subprocess.check_output(cmd, stderr=subprocess.STDOUT, shell=True).decode("utf-8")
>       +            output = subprocess.check_output(cmd, shell=True).decode("utf-8")
>                except subprocess.CalledProcessError as e:
>                    bb.fatal("Unable to list available packages. Command '%s' "
>                             "returned %d:\n%s" % (cmd, e.returncode, e.output.decode("utf-8")))
>       --
>       2.20.1
>
>
>       -=-=-=-=-=-=-=-=-=-=-=-
>       Links: You receive all messages sent to this group.
>       View/Reply Online (#167354): https://lists.openembedded.org/g/openembedded-core/message/167354
> <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-
> core/message/167354__;!!FbZ0ZwI3Qg!qc0xbL3QBz_illnPIJoeHb6mGA1kBLndLjrGDjlfDwR7rkQcM8i7ZTte5y_GL4XNQru-
> qSvIV3p_DxpS6tCIX3jHMdg$>
>       Mute This Topic: https://lists.openembedded.org/mt/92051989/1686489
> <https://urldefense.com/v3/__https://lists.openembedded.org/mt/92051989/1686489__;!!FbZ0ZwI3Qg!qc0xbL3QBz_illnPIJoeHb6mGA1kB
> LndLjrGDjlfDwR7rkQcM8i7ZTte5y_GL4XNQru-qSvIV3p_DxpS6tCIs81jASw$>
>       Group Owner: openembedded-core+owner@lists.openembedded.org <mailto:openembedded-
> core%2Bowner@lists.openembedded.org>
>       Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> <https://urldefense.com/v3/__https://lists.openembedded.org/g/openembedded-
> core/unsub__;!!FbZ0ZwI3Qg!qc0xbL3QBz_illnPIJoeHb6mGA1kBLndLjrGDjlfDwR7rkQcM8i7ZTte5y_GL4XNQru-qSvIV3p_DxpS6tCIADJRjJc$>
> [alex.kanavin@gmail.com <mailto:alex.kanavin@gmail.com> ]
>       -=-=-=-=-=-=-=-=-=-=-=-
>
>

INTERNAL - NI CONFIDENTIAL

^ permalink raw reply	[flat|nested] 6+ messages in thread