From: Sunil Muthuswamy <sunilmut@microsoft.com>
To: Sunil Muthuswamy <sunilmut@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Cc: "will@kernel.org" <will@kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"ardb@kernel.org" <ardb@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH v8 1/6] arm64: hyperv: Add Hyper-V hypercall and register access utilities
Date: Wed, 3 Mar 2021 18:28:16 +0000 [thread overview]
Message-ID: <SN4PR2101MB0880BC201B64BF4274539951C0989@SN4PR2101MB0880.namprd21.prod.outlook.com> (raw)
In-Reply-To: <SN4PR2101MB0880C47188DAC6446BF5E156C0989@SN4PR2101MB0880.namprd21.prod.outlook.com>
> > +
> > + /*
> > + * Allocate a power of 2 size so alignment to that size is
> > + * guaranteed, since the hypercall input and output areas
> > + * must not cross a page boundary.
> > + */
> > + input = kzalloc(roundup_pow_of_two(sizeof(input->header) +
> > + sizeof(input->element[0])), GFP_ATOMIC);
> > + output = kmalloc(roundup_pow_of_two(sizeof(*output)), GFP_ATOMIC);
> > +
> Check for null from these malloc routines? Here and in other places.
Between, is there a plan to setup a percpu input/output page for hypercall
input/output on ARM (like we do for x64)? I didn't check the specific size requirement
for this particular call, but, that generally will remove the need for these
allocations.
WARNING: multiple messages have this Message-ID (diff)
From: Sunil Muthuswamy <sunilmut@microsoft.com>
To: Sunil Muthuswamy <sunilmut@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>
Cc: "will@kernel.org" <will@kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
Mark Rutland <Mark.Rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"ardb@kernel.org" <ardb@kernel.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
KY Srinivasan <kys@microsoft.com>
Subject: RE: [PATCH v8 1/6] arm64: hyperv: Add Hyper-V hypercall and register access utilities
Date: Wed, 3 Mar 2021 18:28:16 +0000 [thread overview]
Message-ID: <SN4PR2101MB0880BC201B64BF4274539951C0989@SN4PR2101MB0880.namprd21.prod.outlook.com> (raw)
In-Reply-To: <SN4PR2101MB0880C47188DAC6446BF5E156C0989@SN4PR2101MB0880.namprd21.prod.outlook.com>
> > +
> > + /*
> > + * Allocate a power of 2 size so alignment to that size is
> > + * guaranteed, since the hypercall input and output areas
> > + * must not cross a page boundary.
> > + */
> > + input = kzalloc(roundup_pow_of_two(sizeof(input->header) +
> > + sizeof(input->element[0])), GFP_ATOMIC);
> > + output = kmalloc(roundup_pow_of_two(sizeof(*output)), GFP_ATOMIC);
> > +
> Check for null from these malloc routines? Here and in other places.
Between, is there a plan to setup a percpu input/output page for hypercall
input/output on ARM (like we do for x64)? I didn't check the specific size requirement
for this particular call, but, that generally will remove the need for these
allocations.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-03 20:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1614649360-5087-1-git-send-email-mikelley@microsoft.com>
[not found] ` <1614649360-5087-2-git-send-email-mikelley@microsoft.com>
2021-03-03 0:34 ` [PATCH v8 1/6] arm64: hyperv: Add Hyper-V hypercall and register access utilities Sunil Muthuswamy
2021-03-03 0:34 ` Sunil Muthuswamy
2021-03-03 18:28 ` Sunil Muthuswamy [this message]
2021-03-03 18:28 ` Sunil Muthuswamy
2021-03-05 20:58 ` Michael Kelley
2021-03-05 20:58 ` Michael Kelley
2021-03-05 20:56 ` Michael Kelley
2021-03-05 20:56 ` Michael Kelley
[not found] ` <1614649360-5087-7-git-send-email-mikelley@microsoft.com>
2021-03-03 19:22 ` [PATCH v8 6/6] Drivers: hv: Enable Hyper-V code to be built on ARM64 Sunil Muthuswamy
2021-03-03 19:22 ` Sunil Muthuswamy
[not found] ` <1614649360-5087-3-git-send-email-mikelley@microsoft.com>
2021-03-03 19:29 ` [PATCH v8 2/6] arm64: hyperv: Add Hyper-V clocksource/clockevent support Sunil Muthuswamy
2021-03-03 19:29 ` Sunil Muthuswamy
[not found] ` <1614649360-5087-5-git-send-email-mikelley@microsoft.com>
2021-03-03 20:21 ` [PATCH v8 4/6] arm64: hyperv: Initialize hypervisor on boot Sunil Muthuswamy
2021-03-03 20:21 ` Sunil Muthuswamy
2021-03-05 21:03 ` Michael Kelley
2021-03-05 21:03 ` Michael Kelley
[not found] ` <1614649360-5087-4-git-send-email-mikelley@microsoft.com>
2021-03-03 21:29 ` [PATCH v8 3/6] arm64: hyperv: Add kexec and panic handlers Sunil Muthuswamy
2021-03-03 21:29 ` Sunil Muthuswamy
2021-02-18 23:16 [PATCH v8 0/6] Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2021-02-18 23:16 ` [PATCH v8 1/6] arm64: hyperv: Add Hyper-V hypercall and register access utilities Michael Kelley
2021-02-18 23:16 ` Michael Kelley
2021-02-22 10:20 ` Wei Liu
2021-02-22 10:20 ` Wei Liu
2021-02-24 2:37 ` Boqun Feng
2021-02-24 2:37 ` Boqun Feng
2021-03-05 20:50 ` Michael Kelley
2021-03-05 20:50 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR2101MB0880BC201B64BF4274539951C0989@SN4PR2101MB0880.namprd21.prod.outlook.com \
--to=sunilmut@microsoft.com \
--cc=Mark.Rutland@arm.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.