From: Chris Morgan <macromorgan@hotmail.com>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
robh+dt@kernel.org, heiko@sntech.de, jbx6244@gmail.com,
hjc@rock-chips.com, yifeng.zhao@rock-chips.com,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, p.yadav@ti.com,
macroalpha82@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v11 10/10] arm64: dts: rockchip: Enable SFC for Odroid Go Advance
Date: Wed, 7 Jul 2021 12:04:32 -0500 [thread overview]
Message-ID: <SN6PR06MB534224A3D7A26D2AE5275331A51A9@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20210707090925.6203-1-jon.lin@rock-chips.com>
On Wed, Jul 07, 2021 at 05:09:25PM +0800, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This enables the Rockchip Serial Flash Controller for the Odroid Go
> Advance. Note that while the attached SPI NOR flash and the controller
> both support quad read mode, only 2 of the required 4 pins are present.
> The rx bus width is set to 2 for this reason, and tx bus width is set
> to 1 for compatibility reasons.
Thank you, I just tested this patch again and all seems to be well.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>
> Changes in v11:
> - The tx is set to 1 for Odroid Go Advance device
>
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
>
> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> index 49c97f76df77..4410a6ef5ada 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> @@ -484,6 +484,22 @@
> status = "okay";
> };
>
> +&sfc {
> + pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus2>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <108000000>;
> + spi-rx-bus-width = <2>;
> + spi-tx-bus-width = <1>;
> + };
> +};
> +
> &tsadc {
> status = "okay";
> };
> --
> 2.17.1
>
>
>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macromorgan@hotmail.com>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
robh+dt@kernel.org, heiko@sntech.de, jbx6244@gmail.com,
hjc@rock-chips.com, yifeng.zhao@rock-chips.com,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, p.yadav@ti.com,
macroalpha82@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v11 10/10] arm64: dts: rockchip: Enable SFC for Odroid Go Advance
Date: Wed, 7 Jul 2021 12:04:32 -0500 [thread overview]
Message-ID: <SN6PR06MB534224A3D7A26D2AE5275331A51A9@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20210707090925.6203-1-jon.lin@rock-chips.com>
On Wed, Jul 07, 2021 at 05:09:25PM +0800, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This enables the Rockchip Serial Flash Controller for the Odroid Go
> Advance. Note that while the attached SPI NOR flash and the controller
> both support quad read mode, only 2 of the required 4 pins are present.
> The rx bus width is set to 2 for this reason, and tx bus width is set
> to 1 for compatibility reasons.
Thank you, I just tested this patch again and all seems to be well.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>
> Changes in v11:
> - The tx is set to 1 for Odroid Go Advance device
>
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
>
> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> index 49c97f76df77..4410a6ef5ada 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> @@ -484,6 +484,22 @@
> status = "okay";
> };
>
> +&sfc {
> + pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus2>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <108000000>;
> + spi-rx-bus-width = <2>;
> + spi-tx-bus-width = <1>;
> + };
> +};
> +
> &tsadc {
> status = "okay";
> };
> --
> 2.17.1
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macromorgan@hotmail.com>
To: Jon Lin <jon.lin@rock-chips.com>
Cc: linux-spi@vger.kernel.org, broonie@kernel.org,
robh+dt@kernel.org, heiko@sntech.de, jbx6244@gmail.com,
hjc@rock-chips.com, yifeng.zhao@rock-chips.com,
sugar.zhang@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-mtd@lists.infradead.org, p.yadav@ti.com,
macroalpha82@gmail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, linux-clk@vger.kernel.org
Subject: Re: [RFC PATCH v11 10/10] arm64: dts: rockchip: Enable SFC for Odroid Go Advance
Date: Wed, 7 Jul 2021 12:04:32 -0500 [thread overview]
Message-ID: <SN6PR06MB534224A3D7A26D2AE5275331A51A9@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <20210707090925.6203-1-jon.lin@rock-chips.com>
On Wed, Jul 07, 2021 at 05:09:25PM +0800, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This enables the Rockchip Serial Flash Controller for the Odroid Go
> Advance. Note that while the attached SPI NOR flash and the controller
> both support quad read mode, only 2 of the required 4 pins are present.
> The rx bus width is set to 2 for this reason, and tx bus width is set
> to 1 for compatibility reasons.
Thank you, I just tested this patch again and all seems to be well.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---
>
> Changes in v11:
> - The tx is set to 1 for Odroid Go Advance device
>
> Changes in v10: None
> Changes in v9: None
> Changes in v8: None
> Changes in v7: None
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
> Changes in v1: None
>
> .../boot/dts/rockchip/rk3326-odroid-go2.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> index 49c97f76df77..4410a6ef5ada 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
> @@ -484,6 +484,22 @@
> status = "okay";
> };
>
> +&sfc {
> + pinctrl-0 = <&sfc_clk &sfc_cs0 &sfc_bus2>;
> + pinctrl-names = "default";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <108000000>;
> + spi-rx-bus-width = <2>;
> + spi-tx-bus-width = <1>;
> + };
> +};
> +
> &tsadc {
> status = "okay";
> };
> --
> 2.17.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-07 17:05 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 9:08 [RFC PATCH v11 00/10] Add Rockchip SFC(serial flash controller) support Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 01/10] dt-bindings: rockchip-sfc: Bindings for Rockchip serial flash controller Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-12 16:19 ` Rob Herring
2021-07-12 16:19 ` Rob Herring
2021-07-12 16:19 ` Rob Herring
2021-07-12 16:19 ` Rob Herring
2021-07-07 9:08 ` [RFC PATCH v11 02/10] spi: rockchip-sfc: add rockchip " Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 17:47 ` Mark Brown
2021-07-07 17:47 ` Mark Brown
2021-07-07 17:47 ` Mark Brown
2021-07-07 17:47 ` Mark Brown
2021-07-07 9:08 ` [RFC PATCH v11 03/10] arm64: dts: rockchip: Add SFC to PX30 Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 04/10] clk: rockchip: rk3036: fix up the sclk_sfc parent error Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 05/10] clk: rockchip: add dt-binding for hclk_sfc on rk3036 Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 06/10] clk: rockchip: Add support " Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 07/10] arm: dts: rockchip: Add SFC to RK3036 Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 08/10] arm: dts: rockchip: Add SFC to RV1108 Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` [RFC PATCH v11 09/10] arm64: dts: rockchip: Add SFC to RK3308 Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:08 ` Jon Lin
2021-07-07 9:09 ` [RFC PATCH v11 10/10] arm64: dts: rockchip: Enable SFC for Odroid Go Advance Jon Lin
2021-07-07 9:09 ` Jon Lin
2021-07-07 9:09 ` Jon Lin
2021-07-07 9:09 ` Jon Lin
2021-07-07 17:04 ` Chris Morgan [this message]
2021-07-07 17:04 ` Chris Morgan
2021-07-07 17:04 ` Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR06MB534224A3D7A26D2AE5275331A51A9@SN6PR06MB5342.namprd06.prod.outlook.com \
--to=macromorgan@hotmail.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jbx6244@gmail.com \
--cc=jon.lin@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.